asomers bc772d7de2 Fix misc Coverity defects in camdd(8) ...

CID 1341620	Fix a small memory leak
CID 1341630	Though this is technically a false positive, rearrange the
		code for clarity.
CID 1341635	Eliminate dead code
CID 1368663	Fix a double mutex unlock in the error path

Also:
* Use sig_atomic_t for variables accessed from signal handlers
* Don't conditionalize free(3) on its argument being non-null

Reported by:	Coverity
CID:		1341620 1341630 1341635 1368663
Reviewed by:	ken
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9237

2017-01-20 21:40:04 +00:00

..

ac

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

accton

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

acpi

Merge ACPICA 20161222.

2017-01-05 21:28:25 +00:00

adduser

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

amd

Conditionalize wrap(3) use based on MK_TCP_WRAPPERS instead of

2017-01-06 04:22:25 +00:00

ancontrol

ancontrol(8): replace comma with semicolon when pertinent.

2016-08-09 19:46:05 +00:00

apm

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

apmd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

arp

Additional cleanup of the arp(4) man page after r306652

2016-10-07 22:17:25 +00:00

asf

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

audit

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

auditd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

auditdistd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

auditreduce

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

authpf

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

autofs

Make autounmountd(8) not die when traced with "truss -p".

2016-11-02 08:12:37 +00:00

bhyve

Use correct PCI device id for virtio-rng.

2017-01-08 20:58:58 +00:00

bhyvectl

Fix typo.

2016-11-13 17:55:27 +00:00

bhyveload

bhyve: improve memory size documentation

2016-06-26 14:44:01 +00:00

binmiscctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

blacklistctl

DIRDEPS_BUILD: Connect new directories and update dependencies.

2016-06-03 19:25:30 +00:00

blacklistd

DIRDEPS_BUILD: Connect new directories and update dependencies.

2016-06-03 19:25:30 +00:00

bluetooth

Avoid undefined behavior when calling va_start() in bnep_send_control(),

2016-08-29 19:40:46 +00:00

boot0cfg

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

boot98cfg

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

bootparamd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

bsdconfig

Guard against bad service name argument(s) to load_rc_config()

2016-10-16 20:59:28 +00:00

bsdinstall

Revert r309918 -- modern POSIX has deprecated -<#>/+<#> syntax

2016-12-13 22:31:49 +00:00

bsnmpd

Add smilint target to subdir targets so "make smilint" here will run

2017-01-17 03:44:45 +00:00

btxld

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

camdd

Fix misc Coverity defects in camdd(8)

2017-01-20 21:40:04 +00:00

cdcontrol

Remove last remnants of acd(4), mcd(4), and scd(4) drivers.

2016-08-25 19:36:58 +00:00

chkgrp

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

chown

chown/chgrp: Add SIGINFO handler

2017-01-08 06:58:42 +00:00

chroot

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ckdist

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

clear_locks

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

config

Allow config to be compiled from another source directory, such as one

2016-10-26 15:58:41 +00:00

cpucontrol

Add support for microcode update on newer AMD CPUs (10h+)

2016-11-02 16:15:49 +00:00

crashinfo

Update crashinfo to work with newer gdb from ports.

2016-07-20 18:41:47 +00:00

cron

Add a 'force' option for non-interactive crontab removal

2016-12-20 17:12:17 +00:00

crunch

Teach crunchide about EM_S390 to make bootstrapping from future

2017-01-10 14:40:30 +00:00

ctladm

Add support for locally assigned RFC 4122 UUID LUN identifiers.

2016-12-21 09:05:30 +00:00

ctld

Fix build with ICL_KERNEL_PROXY.

2017-01-20 17:43:36 +00:00

ctm

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

daemon

DIRDEPS_BUILD: Update dependencies.

2016-11-13 00:11:30 +00:00

dconschat

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

devctl

Implement 'devctl clear driver' to undo a previous 'devctl set driver'.

2016-08-29 22:48:36 +00:00

devinfo

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

digictl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

diskinfo

Quell Coverity for diskinfo(8)

2017-01-04 00:39:06 +00:00

dumpcis

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

editmap

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

edquota

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

eeprom

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

efivar

DIRDEPS_BUILD: Connect new dependencies.

2016-11-13 00:11:23 +00:00

etcupdate

etcupdate: preserve the metadata of the destination file

2016-09-08 15:53:49 +00:00

extattr

Disable extattr test on UFS1.

2016-09-21 10:58:58 +00:00

extattrctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fdcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fdformat

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fdread

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fdwrite

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fifolog

Pass the correct size argument to ioctl(DIOCGSECTORSIZE)

2016-11-22 22:10:58 +00:00

flowctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fmtree

Use type-independent formats for printing nlink_t and ino_t.

2017-01-06 16:59:33 +00:00

freebsd-update

MFportsnap r264740: Use case insensitive match when parsing host(1) output.

2016-10-12 20:24:33 +00:00

fstyp

Fix broken fstyp exfat testcase

2017-01-14 01:08:04 +00:00

ftp-proxy

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

fwcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

getfmac

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

getpmac

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

gpioctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

gssd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

gstat

Add flag -B which does the same like batch mode but without exiting after

2016-11-09 07:31:39 +00:00

hyperv

hyperv/vss: Install the userland daemon to /usr/sbin instead of /

2016-11-17 03:02:35 +00:00

i2c

More typos in strings.

2016-12-02 11:30:21 +00:00

ifmcstat

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

inetd

Fix up r312105

2017-01-14 10:20:38 +00:00

iostat

Make the "r/s" and "w/s" fields in "iostat -x" a little bit wider;

2016-09-21 11:22:19 +00:00

iovctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ip6addrctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ipfwpcap

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

iscsid

Remove ISCSI_MAX_DATA_SEGMENT_LENGTH, using negotiated value.

2017-01-20 17:14:10 +00:00

jail

Don't assign rtjp twice.

2016-12-26 19:27:12 +00:00

jexec

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

jls

Improve IP address list representation in libxo output.

2016-12-24 23:51:27 +00:00

kbdcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

kbdmap

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

keyserv

keyserv(1): drop useless comparison.

2016-05-30 20:41:55 +00:00

kgmon

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

kgzip

kgzip.8: note that it is deprecated and clarify BUGS section

2016-08-02 21:48:26 +00:00

kldxref

Use roundup2() from sys/param.h.

2016-08-23 13:43:43 +00:00

lastlogin

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

lmcconfig

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

lpr

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

lptcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mailstats

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mailwrapper

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

makefs

Fix null dereference when running out of nodes during rename.

2016-11-26 13:26:29 +00:00

makemap

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

manctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

memcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mergemaster

META_MODE: Don't require filemon(4) for mergemaster(8)/etcupdate(8)

2016-07-12 19:47:01 +00:00

mfiutil

Avoid taking the address of a packed struct member in mfiutil

2017-01-09 19:39:35 +00:00

mixer

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mld6query

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mlxcontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mount_smbfs

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mountd

Fix the man page to reflect the change done by r307890 to mountd.c

2016-10-25 00:59:23 +00:00

moused

Add Elantech trackpad to the list of known models

2016-09-26 22:07:45 +00:00

mpsutil

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mptable

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

mptutil

"Buses" is the preferred plural of "bus"

2017-01-15 17:54:01 +00:00

mtest

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nandsim

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nandtool

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ndiscvt

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ndp

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

newsyslog

Fix improper use of "its".

2016-11-08 23:59:41 +00:00

nfscbd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nfsd

Patch the nfsd so that it doesn't register with rpcbind for an NFSv4 only

2016-12-08 23:29:56 +00:00

nfsdumpstate

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nfsrevoke

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nfsuserd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ngctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nghook

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nmtree

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nologin

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

nscd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ntp

Fix up grammar.

2017-01-01 10:37:10 +00:00

nvram

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ofwdump

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

pc-sysinstall

Remove last remnants of acd(4), mcd(4), and scd(4) drivers.

2016-08-25 19:36:58 +00:00

pciconf

pciconf(8): Reallow trailing colon in selectors

2017-01-12 00:34:37 +00:00

periodic

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

pkg

Remove usage of _WITH_GETLINE from usr.sbin

2016-07-30 01:10:05 +00:00

pmcannotate

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

pmccontrol

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

pmcstat

Remove an unused field from struct pmcstat_image.

2016-10-15 23:46:55 +00:00

pmcstudy

DIRDEPS_BUILD: Add some missing dirctories to the build.

2016-08-31 19:30:59 +00:00

pnpinfo

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

portsnap

Avoid division by zero in the rare case that portsnap needs to fetch

2016-12-16 22:37:16 +00:00

powerd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ppp

Fix build of ppp when WITHOUT_PAM is set

2016-07-04 21:18:57 +00:00

pppctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

praliases

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

praudit

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

procctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

prometheus_sysctl_exporter

Add a Prometheus exporter for sysctl values.

2016-12-21 08:29:44 +00:00

pstat

- pstat(8) does not accept any arguments other than getopt() args,

2016-12-26 17:34:27 +00:00

pw

Fix pkg groupshow <gid>

2016-12-10 12:48:48 +00:00

pwd_mkdb

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

quot

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

quotaon

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rarpd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

repquota

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rip6query

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rmt

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

route6d

Purge varargs.h in favor of stdarg.h.

2017-01-13 08:01:27 +00:00

rpc.lockd

Add missing break in lock_partialfilelock(..) with NFS_RESERR

2016-06-13 11:19:06 +00:00

rpc.statd

Mark out_of_mem(..) and usage(..) with __dead2 as they both directly call exit

2016-05-29 04:18:47 +00:00

rpc.umntall

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rpc.yppasswdd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rpc.ypupdated

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rpc.ypxfrd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rpcbind

Conditionalize wrap(3) use based on MK_TCP_WRAPPERS instead of

2017-01-06 04:13:08 +00:00

rrenumd

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rtadvctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rtadvd

Add link-layer address option in RA even for IFT_L2VLAN and IFT_BRIDGE.

2016-11-05 19:51:13 +00:00

rtprio

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

rtsold

rtsold: Log messages about unexpected RAs at LOG_DEBUG.

2016-10-02 00:56:21 +00:00

rwhod

Style(9) fixes

2017-01-09 00:25:33 +00:00

sa

Skip lastcomm and sa tests on unsupported architectures

2016-06-26 00:53:31 +00:00

sendmail

Conditionalize wrap(3) use based on MK_TCP_WRAPPERS instead of

2017-01-06 04:16:03 +00:00

service

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

services_mkdb

Remove usage of _WITH_GETLINE from usr.sbin

2016-07-30 01:10:05 +00:00

sesutil

Fix sesutil fault operation.

2016-09-30 20:35:12 +00:00

setfib

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

setfmac

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

setpmac

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

smbmsg

smbmsg: use a more convenient way of accessing data read from a slave

2016-11-11 15:00:13 +00:00

snapinfo

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

spkrtest

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

spray

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

syslogd

Add more #ifdef INET and INET6.

2017-01-11 07:21:59 +00:00

sysrc

Change my given name from "Garrett" to "Ngie"

2016-06-13 10:35:11 +00:00

tcpdchk

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

tcpdmatch

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

tcpdrop

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

tcpdump

Fix spelling of the casper introduced in the r296047.

2016-06-08 22:30:21 +00:00

tests

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

timed

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

traceroute

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

traceroute6

Fix an infinite loop at an non-responding hop when other echo replies

2016-11-05 18:00:36 +00:00

trpt

Remove "long" variables from the TCP stack (not including the modular

2016-10-06 16:28:34 +00:00

tzsetup

Fix build of tzsetup when WITHOUT_DIALOG is set

2016-10-22 22:35:39 +00:00

uathload

Rename devname to udevname after including stdlib.h in r303445

2016-07-30 20:39:39 +00:00

uefisign

uefisign: Remove backwards-compatibility sys/capability.h support

2016-09-19 16:07:32 +00:00

ugidfw

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

uhsoctl

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

unbound

Upgrade to Unbound 1.5.9.

2016-09-04 12:17:57 +00:00

usbconfig

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

usbdump

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

utx

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

vidcontrol

vidcontrol: use calloc where appropriate

2016-11-05 11:19:55 +00:00

vigr

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

vipw

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

wake

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

watch

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

watchdogd

fix a watchdogd regression introduced in r308040

2016-11-10 10:45:12 +00:00

wlandebug

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

wpa

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

yp_mkdb

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ypbind

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ypldap

Use memset(3) instead of bzero(3).

2016-12-02 06:07:27 +00:00

yppoll

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

yppush

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

ypserv

Conditionalize wrap(3) use based on MK_TCP_WRAPPERS instead of

2017-01-06 04:10:33 +00:00

ypset

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

zic

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

zonectl

DIRDEPS_BUILD: Connect new directories and update dependencies.

2016-06-03 19:25:30 +00:00

zzz

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

Makefile

Add a Prometheus exporter for sysctl values.

2016-12-21 08:29:44 +00:00

Makefile.amd64

Remove the si(4) driver and sicontrol(8) for Specialix serial cards.

2016-08-19 21:14:27 +00:00

Makefile.arm

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

Makefile.arm64

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

Makefile.i386

Remove the wl(4) driver and wlconfig(8) utility.

2016-08-19 22:27:14 +00:00

Makefile.inc

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

Makefile.mips

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00

Makefile.powerpc

Create a new MACHINE_ARCH for Freescale PowerPC e500v2

2016-10-22 01:57:15 +00:00

Makefile.sparc64

Create branch for bhyve graphics import.

2016-05-27 06:22:24 +00:00