Don Lewis 98e82c02e5 Fix problems in the FQ-PIE AQM cleanup code that could leak memory or ... cause a crash. Because dummynet calls pie_cleanup() while holding a mutex, pie_cleanup() is not able to use callout_drain() to make sure that all callouts are finished before it returns, and callout_stop() is not sufficient to make that guarantee. After pie_cleanup() returns, dummynet will free a structure that any remaining callouts will want to access. Fix these problems by allocating a separate structure to contain the data used by the callouts. In pie_cleanup(), call callout_reset_sbt() to replace the normal callout with a cleanup callout that does the cleanup work for each sub-queue. The instance of the cleanup callout that destroys the last flow will also free the extra allocated block of memory. Protect the reference count manipulation in the cleanup callout with DN_BH_WLOCK() to be consistent with all of the other usage of the reference count where this lock is held by the dummynet code. Submitted by: Rasool Al-Saadi <ralsaadi@swin.edu.au> MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D7174		2016-07-12 17:32:40 +00:00
..
ipfw	Fix problems in the FQ-PIE AQM cleanup code that could leak memory or	2016-07-12 17:32:40 +00:00
pf	pf: Map hook returns onto the correct error values	2016-07-09 12:17:01 +00:00