4b81ce6dd2
(sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet <ubm at u-boot-man dot de> Reported by: Vlad <marchenko at gmail dot com> |
||
|---|---|---|
| .. | ||
| ipatm | ||
| sigpvc | ||
| spans | ||
| uni | ||
| atm_aal5.c | ||
| atm_cm.c | ||
| atm_cm.h | ||
| atm_device.c | ||
| atm_if.c | ||
| atm_if.h | ||
| atm_ioctl.h | ||
| atm_pcb.h | ||
| atm_proto.c | ||
| atm_sap.h | ||
| atm_sigmgr.h | ||
| atm_signal.c | ||
| atm_socket.c | ||
| atm_stack.h | ||
| atm_subr.c | ||
| atm_sys.h | ||
| atm_usrreq.c | ||
| atm_var.h | ||
| atm_vc.h | ||
| atm.h | ||
| port.h | ||
| queue.h | ||