6d9fc58bbb
Back in 2015 when I reimplemented these functions to use an AVL tree, I was annoyed by the weakness of the typing of these functions. Both tree nodes and keys are represented by 'void *', meaning that things like the documentation for these functions are an absolute train wreck. To make things worse, users of these functions need to cast the return value of tfind()/tsearch() from 'void *' to 'type_of_key **' in order to access the key. Technically speaking such casts violate aliasing rules. I've observed actual breakages as a result of this by enabling features like LTO. I've filed a bug report at the Austin Group. Looking at the way the bug got resolved, they made a pretty good step in the right direction. A new type 'posix_tnode' has been added to correspond to tree nodes. It is still defined as 'void' for source-level compatibility, but in the very far future it could be replaced by a proper structure type containing a key pointer. MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D8205
51 lines
1.2 KiB
C
51 lines
1.2 KiB
C
/* $NetBSD: twalk.c,v 1.4 2012/03/20 16:38:45 matt Exp $ */
|
|
|
|
/*
|
|
* Tree search generalized from Knuth (6.2.2) Algorithm T just like
|
|
* the AT&T man page says.
|
|
*
|
|
* Written by reading the System V Interface Definition, not the code.
|
|
*
|
|
* Totally public domain.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
#if 0
|
|
#if defined(LIBC_SCCS) && !defined(lint)
|
|
__RCSID("$NetBSD: twalk.c,v 1.4 2012/03/20 16:38:45 matt Exp $");
|
|
#endif /* LIBC_SCCS and not lint */
|
|
#endif
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#define _SEARCH_PRIVATE
|
|
#include <search.h>
|
|
#include <stdlib.h>
|
|
|
|
typedef void (*cmp_fn_t)(const posix_tnode *, VISIT, int);
|
|
|
|
/* Walk the nodes of a tree */
|
|
static void
|
|
trecurse(const posix_tnode *root, cmp_fn_t action, int level)
|
|
{
|
|
|
|
if (root->llink == NULL && root->rlink == NULL)
|
|
(*action)(root, leaf, level);
|
|
else {
|
|
(*action)(root, preorder, level);
|
|
if (root->llink != NULL)
|
|
trecurse(root->llink, action, level + 1);
|
|
(*action)(root, postorder, level);
|
|
if (root->rlink != NULL)
|
|
trecurse(root->rlink, action, level + 1);
|
|
(*action)(root, endorder, level);
|
|
}
|
|
}
|
|
|
|
/* Walk the nodes of a tree */
|
|
void
|
|
twalk(const posix_tnode *vroot, cmp_fn_t action)
|
|
{
|
|
if (vroot != NULL && action != NULL)
|
|
trecurse(vroot, action, 0);
|
|
}
|