freebsd-skq

Go to file

Alexander Motin 64f15aa65b 9187 racing condition between vdev label and spa_last_synced_txg in vdev_validate

illumos/illumos-gate@d1de72cfa2

ztest failed with uncorrectable IO error despite having the fix for #7163.
Both sides of the mirror have CANT_OPEN_BAD_LABEL, which also distinguishes
it from that issue.

Definitely seems like a racing condition between the vdev_validate and spa_sync:
1. Thread A (spa_sync): vdev label is updated to latest txg
2. Thread B (vdev_validate): vdev label's txg is compared to spa_last_synced_txg and is ahead.
3. Thread A (spa_sync): spa_last_synced_txg is updated to latest txg.

Solution: do not check txg in vdev_validate unless config lock is held.

Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Matt Ahrens <matthew.ahrens@delphix.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Author: Pavel Zakharov <pavel.zakharov@delphix.com>

2018-03-28 22:06:12 +00:00

cmd

9166 zfs storage pool checkpoint

2018-03-28 18:12:06 +00:00

common

9166 zfs storage pool checkpoint

2018-03-28 18:12:06 +00:00

head

5066 remove support for non-ANSI compilation

2014-08-20 06:29:42 +00:00

lib

9166 zfs storage pool checkpoint