e0724fd324
objects used to provide per-thread storage in the RPC code. Almost all of these used double-checking with a dedicated mutex (tsd_lock) to do this before. However, that is not always safe with more relaxed memory orders. There were also other bugs, such as one in __rpc_createrr() that caused a new key to be allocated each time __rpc_createrr() was invoked. PR: threads/144558 Reported by: Sam Robb samrobb of averesystems com (key leak) MFC after: 1 week
207 lines
5.9 KiB
C
207 lines
5.9 KiB
C
/* $NetBSD: clnt_simple.c,v 1.21 2000/07/06 03:10:34 christos Exp $ */
|
|
|
|
/*
|
|
* Sun RPC is a product of Sun Microsystems, Inc. and is provided for
|
|
* unrestricted use provided that this legend is included on all tape
|
|
* media and as a part of the software program in whole or part. Users
|
|
* may copy or modify Sun RPC without charge, but are not authorized
|
|
* to license or distribute it to anyone else except as part of a product or
|
|
* program developed by the user.
|
|
*
|
|
* SUN RPC IS PROVIDED AS IS WITH NO WARRANTIES OF ANY KIND INCLUDING THE
|
|
* WARRANTIES OF DESIGN, MERCHANTIBILITY AND FITNESS FOR A PARTICULAR
|
|
* PURPOSE, OR ARISING FROM A COURSE OF DEALING, USAGE OR TRADE PRACTICE.
|
|
*
|
|
* Sun RPC is provided with no support and without any obligation on the
|
|
* part of Sun Microsystems, Inc. to assist in its use, correction,
|
|
* modification or enhancement.
|
|
*
|
|
* SUN MICROSYSTEMS, INC. SHALL HAVE NO LIABILITY WITH RESPECT TO THE
|
|
* INFRINGEMENT OF COPYRIGHTS, TRADE SECRETS OR ANY PATENTS BY SUN RPC
|
|
* OR ANY PART THEREOF.
|
|
*
|
|
* In no event will Sun Microsystems, Inc. be liable for any lost revenue
|
|
* or profits or other special, indirect and consequential damages, even if
|
|
* Sun has been advised of the possibility of such damages.
|
|
*
|
|
* Sun Microsystems, Inc.
|
|
* 2550 Garcia Avenue
|
|
* Mountain View, California 94043
|
|
*/
|
|
/*
|
|
* Copyright (c) 1986-1991 by Sun Microsystems Inc.
|
|
*/
|
|
|
|
#if defined(LIBC_SCCS) && !defined(lint)
|
|
static char *sccsid2 = "from: @(#)clnt_simple.c 1.35 87/08/11 Copyr 1984 Sun Micro";
|
|
static char *sccsid = "from: @(#)clnt_simple.c 2.2 88/08/01 4.0 RPCSRC";
|
|
#endif
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
/*
|
|
* clnt_simple.c
|
|
* Simplified front end to client rpc.
|
|
*
|
|
*/
|
|
|
|
#include "namespace.h"
|
|
#include "reentrant.h"
|
|
#include <sys/param.h>
|
|
#include <stdio.h>
|
|
#include <errno.h>
|
|
#include <rpc/rpc.h>
|
|
#include <string.h>
|
|
#include <stdlib.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include "un-namespace.h"
|
|
#include "mt_misc.h"
|
|
|
|
#ifndef MAXHOSTNAMELEN
|
|
#define MAXHOSTNAMELEN 64
|
|
#endif
|
|
|
|
#ifndef NETIDLEN
|
|
#define NETIDLEN 32
|
|
#endif
|
|
|
|
struct rpc_call_private {
|
|
int valid; /* Is this entry valid ? */
|
|
CLIENT *client; /* Client handle */
|
|
pid_t pid; /* process-id at moment of creation */
|
|
rpcprog_t prognum; /* Program */
|
|
rpcvers_t versnum; /* Version */
|
|
char host[MAXHOSTNAMELEN]; /* Servers host */
|
|
char nettype[NETIDLEN]; /* Network type */
|
|
};
|
|
static struct rpc_call_private *rpc_call_private_main;
|
|
static thread_key_t rpc_call_key;
|
|
static once_t rpc_call_once = ONCE_INITIALIZER;
|
|
static int rpc_call_key_error;
|
|
|
|
static void rpc_call_key_init(void);
|
|
static void rpc_call_destroy(void *);
|
|
|
|
static void
|
|
rpc_call_destroy(void *vp)
|
|
{
|
|
struct rpc_call_private *rcp = (struct rpc_call_private *)vp;
|
|
|
|
if (rcp) {
|
|
if (rcp->client)
|
|
CLNT_DESTROY(rcp->client);
|
|
free(rcp);
|
|
}
|
|
}
|
|
|
|
static void
|
|
rpc_call_key_init(void)
|
|
{
|
|
|
|
rpc_call_key_error = thr_keycreate(&rpc_call_key, rpc_call_destroy);
|
|
}
|
|
|
|
/*
|
|
* This is the simplified interface to the client rpc layer.
|
|
* The client handle is not destroyed here and is reused for
|
|
* the future calls to same prog, vers, host and nettype combination.
|
|
*
|
|
* The total time available is 25 seconds.
|
|
*/
|
|
enum clnt_stat
|
|
rpc_call(host, prognum, versnum, procnum, inproc, in, outproc, out, nettype)
|
|
const char *host; /* host name */
|
|
rpcprog_t prognum; /* program number */
|
|
rpcvers_t versnum; /* version number */
|
|
rpcproc_t procnum; /* procedure number */
|
|
xdrproc_t inproc, outproc; /* in/out XDR procedures */
|
|
const char *in;
|
|
char *out; /* recv/send data */
|
|
const char *nettype; /* nettype */
|
|
{
|
|
struct rpc_call_private *rcp = (struct rpc_call_private *) 0;
|
|
enum clnt_stat clnt_stat;
|
|
struct timeval timeout, tottimeout;
|
|
int main_thread = 1;
|
|
|
|
if ((main_thread = thr_main())) {
|
|
rcp = rpc_call_private_main;
|
|
} else {
|
|
if (thr_once(&rpc_call_once, rpc_call_key_init) != 0 ||
|
|
rpc_call_key_error != 0) {
|
|
rpc_createerr.cf_stat = RPC_SYSTEMERROR;
|
|
rpc_createerr.cf_error.re_errno = rpc_call_key_error;
|
|
return (rpc_createerr.cf_stat);
|
|
}
|
|
rcp = (struct rpc_call_private *)thr_getspecific(rpc_call_key);
|
|
}
|
|
if (rcp == NULL) {
|
|
rcp = malloc(sizeof (*rcp));
|
|
if (rcp == NULL) {
|
|
rpc_createerr.cf_stat = RPC_SYSTEMERROR;
|
|
rpc_createerr.cf_error.re_errno = errno;
|
|
return (rpc_createerr.cf_stat);
|
|
}
|
|
if (main_thread)
|
|
rpc_call_private_main = rcp;
|
|
else
|
|
thr_setspecific(rpc_call_key, (void *) rcp);
|
|
rcp->valid = 0;
|
|
rcp->client = NULL;
|
|
}
|
|
if ((nettype == NULL) || (nettype[0] == 0))
|
|
nettype = "netpath";
|
|
if (!(rcp->valid && rcp->pid == getpid() &&
|
|
(rcp->prognum == prognum) &&
|
|
(rcp->versnum == versnum) &&
|
|
(!strcmp(rcp->host, host)) &&
|
|
(!strcmp(rcp->nettype, nettype)))) {
|
|
int fd;
|
|
|
|
rcp->valid = 0;
|
|
if (rcp->client)
|
|
CLNT_DESTROY(rcp->client);
|
|
/*
|
|
* Using the first successful transport for that type
|
|
*/
|
|
rcp->client = clnt_create(host, prognum, versnum, nettype);
|
|
rcp->pid = getpid();
|
|
if (rcp->client == NULL) {
|
|
return (rpc_createerr.cf_stat);
|
|
}
|
|
/*
|
|
* Set time outs for connectionless case. Do it
|
|
* unconditionally. Faster than doing a t_getinfo()
|
|
* and then doing the right thing.
|
|
*/
|
|
timeout.tv_usec = 0;
|
|
timeout.tv_sec = 5;
|
|
(void) CLNT_CONTROL(rcp->client,
|
|
CLSET_RETRY_TIMEOUT, (char *)(void *)&timeout);
|
|
if (CLNT_CONTROL(rcp->client, CLGET_FD, (char *)(void *)&fd))
|
|
_fcntl(fd, F_SETFD, 1); /* make it "close on exec" */
|
|
rcp->prognum = prognum;
|
|
rcp->versnum = versnum;
|
|
if ((strlen(host) < (size_t)MAXHOSTNAMELEN) &&
|
|
(strlen(nettype) < (size_t)NETIDLEN)) {
|
|
(void) strcpy(rcp->host, host);
|
|
(void) strcpy(rcp->nettype, nettype);
|
|
rcp->valid = 1;
|
|
} else {
|
|
rcp->valid = 0;
|
|
}
|
|
} /* else reuse old client */
|
|
tottimeout.tv_sec = 25;
|
|
tottimeout.tv_usec = 0;
|
|
/*LINTED const castaway*/
|
|
clnt_stat = CLNT_CALL(rcp->client, procnum, inproc, (char *) in,
|
|
outproc, out, tottimeout);
|
|
/*
|
|
* if call failed, empty cache
|
|
*/
|
|
if (clnt_stat != RPC_SUCCESS)
|
|
rcp->valid = 0;
|
|
return (clnt_stat);
|
|
}
|