freebsd-skq/lib/libarchive
Alex Richardson 72f97a2d09 libarchive: fix mismatch between library and test configuration
I was investigating libarchive test failures on CheriBSD and it turns out
we get a reproducible SIGBUS for test_archive_m5, etc. Debugging this shows
that libarchive and the tests disagree when it comes to the definition of
archive_md5_ctx: libarchive assumes it's the OpenSSL type whereas the test
use the libmd type. The latter is not necessarily aligned enough to store
a pointer (16 bytes for CHERI RISC-V), so we were crashing when storing
EVP_MD_CTX* to an 8-byte-aligned archive_md5_ctx.

To avoid problems like this in the future, factor out the common compiler
flags into a Makefile.inc and include that from the tests Makefile.

Reviewed By:	lwhsu
Differential Revision: https://reviews.freebsd.org/D26469
2020-09-18 11:22:34 +00:00
..
tests libarchive: fix mismatch between library and test configuration 2020-09-18 11:22:34 +00:00
config_freebsd.h MFV r348971,r348977: 2019-06-12 13:34:12 +00:00
Makefile libarchive: fix mismatch between library and test configuration 2020-09-18 11:22:34 +00:00
Makefile.depend Update Makefile.depend files 2019-12-11 17:37:53 +00:00
Makefile.depend.options Add Makefile.depend.options 2019-12-11 17:37:37 +00:00
Makefile.inc libarchive: fix mismatch between library and test configuration 2020-09-18 11:22:34 +00:00