freebsd kernel with SKQ
Go to file
John Baldwin 74aa2d49d6 Don't directly dereference a user pointer in the VPD ioctl.
The PCIOCLISTVPD ioctl on /dev/pci is used to fetch a list of VPD
key-value pairs for a specific PCI function.  It is used by
'pciconf -l -V'.  The list is stored in a userland-supplied buffer as
an array of variable-length structures where the key and data length
are stored in a fixed-size header followed by the variable-length
value as a byte array.  To facilitate walking this array in userland,
<sys/pciio.h> provides a PVE_NEXT() helper macro to return a pointer
to the next array element by reading the the length out of the current
header and using it to compute the address of the next header.

To simplify the implementation, the ioctl handler was also using
PVE_NEXT() when on the user address of the user buffer to compute the
user address of the next array element.  However, the PVE_NEXT() macro
when used with a user address was reading the value's length by
indirecting the user pointer.  The value was ready after the current
record had been copied out to the user buffer, so it appeared to work
on architectures where user addresses are directly dereferencable from
the kernel (all but powerpc and i386 after the 4:4 split).  The recent
enablement of SMAP on amd64 caught this violation however.  To fix,
add a variant of PVE_NEXT() for use in the ioctl handler that takes an
explicit value length.

Reported by:	Jeffrey Pieper @ Intel
Reviewed by:	kib
Approved by:	re (gjb)
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D16800
2018-08-31 16:10:01 +00:00
bin Finish moving dot.cshrc and dot.profile to bin/csh/ and bin/sh/. 2018-08-29 16:59:19 +00:00
cddl Add support for send, receive and state-change DTrace providers for 2018-08-22 21:23:32 +00:00
contrib Reduce the log level of tcpd_warn calls from ERR to WARNING. 2018-08-23 20:44:26 +00:00
crypto Avoid printing extraneous function names when searching man page 2018-08-29 06:04:54 +00:00
etc Move fbtab, login.conf, and motd to usr.bin/login/ 2018-08-30 15:52:03 +00:00
gnu Update libstdc++ configuration. 2018-07-16 18:53:28 +00:00
include Remove arc4random_stir and arc4random_addrandom from stdlib.h. 2018-08-26 18:04:54 +00:00
kerberos5 krb5-config build: Remove gratuitous escaping 2018-08-12 00:06:21 +00:00
lib r338270 had the side effect of no longer installing libmd.so into /lib. 2018-08-26 17:05:43 +00:00
libexec Fix wrong offset calculation for R_ARM_TLS_TPOFF32 relocations. 2018-08-25 16:54:37 +00:00
release release.sh: disable colors and the beastie menu for ARM/ARM64 targets 2018-08-30 18:00:28 +00:00
rescue Avoid referencing private lib names directly. 2017-11-10 07:53:02 +00:00
sbin Add in a missing newline 2018-08-25 15:47:52 +00:00
secure Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c 2018-08-16 19:48:07 +00:00
share Add beforeinstallconfig to bsd.confs.mk to enable running commands prior to 2018-08-28 22:22:06 +00:00
stand lualoader: Print error messages from command failures at the prompt 2018-08-31 15:02:53 +00:00
sys Don't directly dereference a user pointer in the VPD ioctl. 2018-08-31 16:10:01 +00:00
targets send-pr: wave goodbye 2018-08-19 07:12:35 +00:00
tests Vendor import of ntp-4.2.8p12. 2018-08-20 06:07:33 +00:00
tools Put building of drm and drm2 modules behind options. 2018-08-28 14:46:49 +00:00
usr.bin Move fbtab, login.conf, and motd to usr.bin/login/ 2018-08-30 15:52:03 +00:00
usr.sbin Add libxo(3) support to lastlogin(8). 2018-08-28 17:12:37 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.gitattributes Remove spuriously added svn properties 2018-08-02 18:37:02 +00:00
.gitignore Ignore _.universe-toolchain file. 2018-07-01 13:50:37 +00:00
COPYRIGHT Remove 'All Rights Reserved' from the collection copyright and templates. 2018-05-09 02:02:49 +00:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Add pointer to freebsd-numerics for libm. 2018-07-16 15:29:32 +00:00
Makefile Import OpenSSL 1.0.2p. 2018-08-14 16:18:14 +00:00
Makefile.inc1 Fix 'install: symlink usr/src/sys -> /sys: File exists' in distributeworld 2018-08-28 23:56:52 +00:00
Makefile.libcompat Fix non-FreeBSD host lib32 build for TARGET=amd64 2018-08-23 18:19:10 +00:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc libbe(3)/bectl(8): Make consistent with beadm 2018-08-24 20:44:58 +00:00
README Import OpenSSL 1.0.2p. 2018-08-14 16:18:14 +00:00
README.md README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
UPDATING Tweak typos in UPDATING 2018-08-29 17:37:23 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html