d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
74fd15a8f4
freebsd-skq/sbin
History
ken 74fd15a8f4 Fix a problem in camcontrol(8) that cropped up with r307684. 
In r307684, I changed rescan_or_reset_bus() to bzero stack-allocated CCBs
before sending them to the kernel because there was stack garbage in there
that wound up meaning that bogus CCB flags were set.

While this fixed the 'camcontrol rescan all' case (XPT_DEV_MATCH CCBs were
failing previously), it broke the 'camcontrol rescan 0' (or any other
number) case when INVARIANTS are turned on.  Rescanning a single bus
reliably produced an assert in cam_periph_runccb():

panic: cam_periph_runccb: ccb=0xfffff80044ffe000, func_code=0x708, flags=0xffffdde0

The flags values don't make sense from the code.  Changing the CCBs in
rescan_or_reset_bus() from stack to heap allocated avoids the problem.

It would be better to understand why userland stack allocated CCBs don't
work properly, since there may be other code that breaks if stack allocated
CCBs don't work.

sbin/camcontrol/camcontrol.c:
	In rescan_or_reset_bus(), allocate the CCBs using malloc(3) instead
	of on the stack to avoid an assertion in cam_periph_runccb().

MFC after:	3 days
Sponsored by:	Spectra Logic
2016-10-21 18:54:56 +00:00
..
adjkerntz
atm Add history section for atmconfig(8) 2016-10-05 19:49:48 +00:00
badsect
bsdlabel Add history section for bsdlabel(8) 2016-10-05 19:56:10 +00:00
camcontrol Fix a problem in camcontrol(8) that cropped up with r307684. 2016-10-21 18:54:56 +00:00
ccdconfig ccdconfig first appeared in NetBSD 1.1 2016-10-02 23:19:05 +00:00
clri Add history section for clri(8) 2016-10-05 20:01:09 +00:00
comcontrol
conscontrol
ddb
devd Sort SEE ALSO section sequentially. 2016-10-08 12:53:23 +00:00
devfs Add history section for devfs(8) 2016-10-05 20:08:07 +00:00
dhclient dhclient(8): Enable numbered user class ID option 2016-09-20 19:21:41 +00:00
dmesg dmesg(8) first appeared in 3BSD. 2016-10-02 23:26:41 +00:00
dump dump(8) first appeared in V4 UNIX 2016-10-02 23:30:28 +00:00
dumpfs
dumpon dumpon(8) appears to be present in FreeBSD 2.0.5, 2016-10-02 23:35:45 +00:00
etherswitchcfg Igor suggested moving sentence to new line. 2016-10-02 14:32:04 +00:00
fdisk Document the history of fdisk based on the original post to comp.unix.bsd by Julian Elischer [1] and the Mach 2.5 Installation notes [2]. 2016-10-05 20:21:06 +00:00
fdisk_pc98 Document the history of fdisk based on the original post to comp.unix.bsd by Julian Elischer [1] and the Mach 2.5 Installation notes [2]. 2016-10-05 20:28:04 +00:00
ffsinfo
fsck Add history section to fsck(8) 2016-10-05 20:31:44 +00:00
fsck_ffs Add history section to fsck_ffs(8) 2016-10-05 20:38:49 +00:00
fsck_msdosfs Mention the version of NetBSD the utility originated from. 2016-10-02 23:40:17 +00:00
fsdb Document which version of BSD first showed up in and add the version info 2016-10-02 23:44:52 +00:00
fsirand
gbde gbde first appeared in FreeBSD 5.0 2016-10-02 23:48:33 +00:00
geom Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
ggate Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
growfs Use bsdlabel as we don't have hardlink disklabel -> bsdlabel on MIPS. 2016-09-26 14:01:41 +00:00
gvinum
hastctl Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
hastd Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
ifconfig Fix spurious white space introduced in r301059 2016-10-09 03:20:58 +00:00
init Add verbosity around failed reboot(2) call. 2016-10-07 13:43:38 +00:00
ipf
ipfw Add support for non-contiguous IPv6 masks in ipfw(8) rules. 2016-10-18 15:14:46 +00:00
iscontrol Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
kldconfig
kldload
kldstat
kldunload
ldconfig
md5 md5: enter capability on last fd or when acting as a filter 2016-10-19 21:07:17 +00:00
mdconfig
mdmfs Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
mknod mknod appeared in V4 UNIX 2016-10-02 23:56:08 +00:00
mksnap_ffs mksnap_ffs appeared in FreeBSD 5.1. 2016-10-02 23:59:31 +00:00
mount mount(1): Simplify by using asprintf(3) 2016-09-19 18:42:58 +00:00
mount_cd9660
mount_fusefs Note mount_fusefs appeared in FreeBSD 10. 2016-10-03 00:16:16 +00:00
mount_msdosfs Amend history to mention predecessor originated from 386BSD[1] & current implementation from NetBSD[2]. 2016-10-03 00:25:15 +00:00
mount_nfs Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
mount_nullfs Note the name change from mount_null to mount_nullfs in FreeBSD 5.0. 2016-10-03 00:28:42 +00:00
mount_udf
mount_unionfs Note the change of name in FreeBSD 5.0. 2016-10-03 00:31:58 +00:00
nandfs Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
natd Add history section to natd(8) 2016-10-05 20:42:35 +00:00
newfs
newfs_msdos The code only converts from bpbHugeSectors to bpbSectors if the sum of 2016-08-30 18:01:26 +00:00
newfs_nandfs
nfsiod
nos-tun Add history section to nos-tun(8) 2016-10-05 20:45:21 +00:00
nvmecontrol Add missing history sections to a number of storage related man pages 2016-09-16 04:28:31 +00:00
pfctl pf: port extended DSCP support from OpenBSD 2016-10-13 20:34:44 +00:00
pflogd
ping
ping6 Fix a regression introduced on revision r271909, when using argument -g 2016-07-05 07:01:42 +00:00
quotacheck For pointers use NULL instead of 0. 2016-05-16 00:36:12 +00:00
rcorder sbin/rcorder/rcorder.8: Amend HISTORY 2016-09-16 04:08:34 +00:00
reboot sbin/reboot/reboot.8: Amend HISTORY 2016-09-16 04:11:04 +00:00
recoverdisk
resolvconf Fix missing substitution of @SBINDIR@ in resolvconf scripts 2016-08-23 02:06:20 +00:00
restore
route Due to dropped mbuf in netisr queue route(8) can fall into infinity 2016-07-27 08:26:34 +00:00
routed
rtsol
savecore savecore(8): Fix buffer overrun inspecting disks with varying sector size 2016-10-06 05:16:44 +00:00
sconfig sconfig appeared in FreeBSD 5.2. 2016-10-03 00:40:20 +00:00
setkey setkey appeared in FreeBSD 4.0 2016-10-03 00:42:25 +00:00
shutdown shutdown appeared as a standalone utility in 4.1BSD. 2016-10-03 00:55:18 +00:00
spppcontrol
sunlabel
swapon swapon(8): Update to reality: swapoff ignores -L and the late option in fstab. 2016-10-02 15:01:31 +00:00
sysctl Consolidate four efi_next_descriptor() definitions. 2016-09-18 17:38:02 +00:00
tests
tunefs
umount sbin/umount/umount.8: Amend HISTORY 2016-09-16 04:12:32 +00:00
Makefile
Makefile.amd64
Makefile.arm
Makefile.i386
Makefile.inc
Makefile.mips
Makefile.pc98
Makefile.sparc64