7a731ac2d2
Before, we were using while (*p++ && --len > 0); to do this. However, len doesn't get decremented for the NUL byte, so when we used len later to see if we still have CIS left for some optional fields, we'd run off the end of an array and dump core. Instead, replace it with len -= strlen(p) + 1; p += strlen(p) + 1; which is more correct. It is a little bogus to assume that p points to a valid C string, but only a little. The PC Card SPEC mandates that it does, and we already depend on that with the use of strdup a few lines earlier. Since much of the rest of the cis parsing code isn't hyper retentive about error checking, I'll leave that level of checking for another time and/or another committer :-). |
||
|---|---|---|
| .. | ||
| cardd.c | ||
| cardd.h | ||
| file.c | ||
| Makefile | ||
| pccard.conf.5 | ||
| pccardd.8 | ||
| pccardd.c | ||
| readcis.c | ||
| readcis.h | ||
| server.c | ||
| util.c | ||