freebsd kernel with SKQ
Go to file
Mitchell Horne 7e7f7beee7 ns8250: don't drop IER_TXRDY on bus_grab/ungrab
It has been observed that some systems are often unable to resume from
ddb after entering with debug.kdb.enter=1. Checking the status further
shows the terminal is blocked waiting in tty_drain(), but it never makes
progress in clearing the output queue, because sc->sc_txbusy is high.

I noticed that when entering polling mode for the debugger, IER_TXRDY is
set in the failure case. Since this bit is never tracked by the softc,
it will not be restored by ns8250_bus_ungrab(). This creates a race in
which a TX interrupt can be lost, creating the hang described above.
Ensuring that this bit is restored is enough to prevent this, and resume
from ddb as expected.

The solution is to track this bit in the sc->ier field, for the same
lifetime that TX interrupts are enabled.

PR:		223917, 240122
Reviewed by:	imp, manu
Tested by:	bz
MFC after:	5 days
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D29130
2021-03-10 11:04:42 -04:00
.github/workflows GitHub actions: unbreak macOS build 2021-01-08 15:36:38 +01:00
bin bin/pkill: Fix {pgrep,pkill}-j_test.sh 2021-02-13 13:53:51 +00:00
cddl openzfs: attach pam_zfs_key to build 2021-03-02 07:26:59 -05:00
contrib bc: Vendor import new version 3.3.3 2021-03-05 12:33:01 +01:00
crypto openssh: document two changes that are now upstream 2021-02-22 14:03:28 -05:00
etc Restore /boot/efi to mtree. 2021-03-05 21:01:11 -05:00
gnu dialog: fix macro redefinition 2021-03-01 16:01:44 +01:00
include Remove xform_poly1305.h from the build, it is not necessary. 2021-03-05 21:28:10 +00:00
kerberos5 kerberos5: fix the WITH_OPENLDAP build 2021-01-30 00:07:50 -06:00
lib lib/msun: Avoid FE_INEXACT for x86 log2l/log10l 2021-03-08 09:39:32 +00:00
libexec Revert "rc: implement parallel boot" 2021-03-09 14:26:07 +01:00
release release: sprinkle UNAME_r hacks following c883b6fd8c 2021-03-04 09:25:18 -05:00
rescue ping: add a ping6 hard link for backwards compatibility 2020-11-26 18:33:04 +00:00
sbin ifconfig: allow displaying/setting persistent-keepalive 2021-03-09 05:16:42 -06:00
secure OpenSSL: Regen manual page for the previous commit 2021-02-17 18:19:13 -05:00
share wg(4): note the persistent-keepalive ifconfig(8) option 2021-03-09 14:21:35 -06:00
stand loader: cursor off should restore display content 2021-03-06 12:23:54 +02:00
sys ns8250: don't drop IER_TXRDY on bus_grab/ungrab 2021-03-10 11:04:42 -04:00
targets ndis(4): remove as previous announced 2021-01-25 21:45:03 +00:00
tests tests/sys/cddl: correctly quote atf_set "require.progs" 2021-03-08 09:38:27 +00:00
tools stress2: open(2) tests with BENEATH flags. 2021-03-08 09:19:37 +01:00
usr.bin Remove the never-installed setchannel(1) utility. It only work(s|ed) 2021-03-07 00:06:42 +00:00
usr.sbin mountd(8): generate a syslog message when the "V4:" line is missing 2021-03-08 16:08:02 -08:00
.arcconfig arcconfig: add callsign again 2020-11-23 04:39:29 +00:00
.arclint
.cirrus.yml Cirrus-CI: Add more information to help track down disk full issues 2021-03-03 11:51:08 -05:00
.clang-format clang-format: Avoid breaking after the opening paren of function definitions 2020-10-28 11:54:00 +00:00
.gitattributes
.gitignore gitignore: expand list of ignored files 2021-01-14 17:03:57 +01:00
COPYRIGHT copyrights: Happy New Year 2021 2020-12-31 10:29:44 -05:00
LOCKS
MAINTAINERS Add a pointer to csprng@ for the CSPRNG driver. This is enforced anyway by 2020-09-01 08:02:12 +00:00
Makefile Fix 'make bmake' top-level bootstrapping. 2021-03-06 09:45:08 -08:00
Makefile.inc1 Makefile.inc1 "Avoid duplicate script for target" warning 2021-03-01 13:22:15 +00:00
Makefile.libcompat libcompat: remove redundant path for ncurses 2021-01-07 15:14:52 +01:00
Makefile.sys.inc
ObsoleteFiles.inc Add ObsoleteFiles.inc entries for various OCF headers removed in 13. 2021-03-08 11:17:21 -08:00
README Revert "TEST gitrepo-dev" 2021-03-07 17:34:21 +00:00
README.md Mark the repository has been converted to Git 2020-12-23 12:27:27 +08:00
RELNOTES Bump CURRENT to 14.0 2021-01-21 19:10:07 -05:00
UPDATING Add UPDATING entry for PIE default 2021-02-25 11:02:09 -05:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html