d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
88f7208f58
freebsd-skq/lib/libfetch
History
dim d3e521cfec MFC r284346: 
Fix the following clang 3.7.0 warnings in lib/libfetch/http.c:

    lib/libfetch/http.c:1628:26: error: address of array 'purl->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = purl->user ?
                                                   ~~~~~~^~~~ ~
    lib/libfetch/http.c:1630:30: error: address of array 'purl->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = purl->pwd?
                                                       ~~~~~~^~~~
    lib/libfetch/http.c:1657:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1659:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~
    lib/libfetch/http.c:1669:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1671:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~

Since url->user and url->pwd are arrays, they can never be NULL, so the
checks can be removed.

Reviewed by:	bapt
Differential Revision: https://reviews.freebsd.org/D2673
2015-06-20 13:30:09 +00:00
..
common.c MFH (r273114, r273124): disable SSLv3 by default. 2015-01-12 10:02:23 +00:00
common.h MFC: r267131, r267132, r267133, r268493, r268671 2014-07-20 00:29:41 +00:00
fetch.3 MFH (r273114, r273124): disable SSLv3 by default. 2015-01-12 10:02:23 +00:00
fetch.c Fix -Wunsequenced warning. 2013-06-29 15:51:27 +00:00
fetch.h MFC: r267131, r267132, r267133, r268493, r268671 2014-07-20 00:29:41 +00:00
file.c Adding missing return statements during error conditions. 2012-09-14 12:15:13 +00:00
ftp.c latin1 -> utf8 2011-10-19 11:43:51 +00:00
ftp.errors
http.c MFC r284346: 2015-06-20 13:30:09 +00:00
http.errors Don't deny non-temporary redirects if the -A option is set (per 2012-10-22 03:00:10 +00:00
Makefile Use libmd if and only if OpenSSL is not available. 2012-09-14 13:00:43 +00:00