8c0fec805f
rather than pointers, requiring callers to properly dispose of those references. The following routines now return references: ifaddr_byindex ifa_ifwithaddr ifa_ifwithbroadaddr ifa_ifwithdstaddr ifa_ifwithnet ifaof_ifpforaddr ifa_ifwithroute ifa_ifwithroute_fib rt_getifa rt_getifa_fib IFP_TO_IA ip_rtaddr in6_ifawithifp in6ifa_ifpforlinklocal in6ifa_ifpwithaddr in6_ifadd carp_iamatch6 ip6_getdstifaddr Remove unused macro which didn't have required referencing: IFP_TO_IA6 This closes many small races in which changes to interface or address lists while an ifaddr was in use could lead to use of freed memory (etc). In a few cases, add missing if_addr_list locking required to safely acquire references. Because of a lack of deep copying support, we accept a race in which an in6_ifaddr pointed to by mbuf tags and extracted with ip6_getdstifaddr() doesn't hold a reference while in transmit. Once we have mbuf tag deep copy support, this can be fixed. Reviewed by: bz Obtained from: Apple, Inc. (portions) MFC after: 6 weeks (portions) |
||
|---|---|---|
| .. | ||
| ipx_cksum.c | ||
| ipx_if.h | ||
| ipx_input.c | ||
| ipx_outputfl.c | ||
| ipx_pcb.c | ||
| ipx_pcb.h | ||
| ipx_proto.c | ||
| ipx_usrreq.c | ||
| ipx_var.h | ||
| ipx.c | ||
| ipx.h | ||
| README | ||
| spx_debug.c | ||
| spx_debug.h | ||
| spx_reass.c | ||
| spx_timer.h | ||
| spx_usrreq.c | ||
| spx_var.h | ||
| spx.h | ||
$FreeBSD$
This protocol implements IPX/SPX over Ethernet_II frame type 0x8137.
Please note: the SPX implementation may require further work and testing
to insure proper operation.
Mike Mitchell, Network Engineer
AMTECH Systems Corporation, Technology and Manufacturing
8600 Jefferson Street, Albuquerque, New Mexico 87113 (505) 856-8000
supervisor@alb.asctmd.com
John Hay
Some Company
Some Address
jhay@mikom.csir.co.za
Adapted for multi-processor, multi-threaded network stack by Robert N. M.
Watson, Computer Laboratory, University of Cambridge.
--- Copyright Information ---
/*-
Copyright (c) 1984, 1985, 1986, 1987, 1993
The Regents of the University of California. All rights reserved.
Modifications Copyright (c) 1995, Mike Mitchell
Modifications Copyright (c) 1995, John Hay
Modifications Copyright (c) 2004-2009 Robert N. M. Watson
*/
--- TODO ---
(1) netipx default socket buffer sizes are very small by contemporary
standards, and should be increased following testing and measurement.
(2) SPX will free the PCB and socket buffer memory on close(), which means
close() in effects terminates the transfer of any outstanding buffered
but unsent data. As with TCP, it should instead grab its own
reference to the socket so that it is not released, as hold onto it
until the data transfer is complete.