d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8d87c98801
freebsd-skq/lib/libfetch
History
dim 8cd240ced1 Fix the following clang 3.7.0 warnings in lib/libfetch/http.c: 
lib/libfetch/http.c:1628:26: error: address of array 'purl->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = purl->user ?
                                                   ~~~~~~^~~~ ~
    lib/libfetch/http.c:1630:30: error: address of array 'purl->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = purl->pwd?
                                                       ~~~~~~^~~~
    lib/libfetch/http.c:1657:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1659:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~
    lib/libfetch/http.c:1669:25: error: address of array 'url->user'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.user = url->user ?
                                                   ~~~~~^~~~ ~
    lib/libfetch/http.c:1671:29: error: address of array 'url->pwd'
    will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                                    aparams.password = url->pwd ?
                                                       ~~~~~^~~ ~

Since url->user and url->pwd are arrays, they can never be NULL, so the
checks can be removed.

Reviewed by:	bapt
MFC after:	3 days
Differential Revision: https://reviews.freebsd.org/D2673
2015-06-13 19:26:48 +00:00
..
common.c Remove defunct SSLv2 support from fetch(1) and fetch(3). 2015-03-25 18:56:36 +00:00
common.h Add support for arbitrary http requests 2014-06-05 22:16:26 +00:00
fetch.3 Remove defunct SSLv2 support from fetch(1) and fetch(3). 2015-03-25 18:56:36 +00:00
fetch.c Fix -Wunsequenced warning. 2013-06-29 15:51:27 +00:00
fetch.h Add support for arbitrary http requests 2014-06-05 22:16:26 +00:00
file.c Adding missing return statements during error conditions. 2012-09-14 12:15:13 +00:00
ftp.c
ftp.errors
http.c Fix the following clang 3.7.0 warnings in lib/libfetch/http.c: 2015-06-13 19:26:48 +00:00
http.errors Don't deny non-temporary redirects if the -A option is set (per 2012-10-22 03:00:10 +00:00
Makefile Convert libraries to use LIBADD 2014-11-25 11:07:26 +00:00
Makefile.depend Add META_MODE support. 2015-06-13 19:20:56 +00:00