9e66c6e8f0
r285050 fixed a bug in pw that could lead to /etc/passwd or /etc/group corruption on power loss. However, it fixed it by opening those files with O_SYNC, which is very slow, especially on ZFS. This change replaces O_SYNC with appropriately placed fsync()s instead, which is much faster. Using a ZFS tmpdir, the time to run pw's kyua tests drops from 245s to 35s. Reviewed by: allanjude, bapt, vangyzen, garga Tested on pfSense by: garga MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D8319
110 lines
2.6 KiB
C
110 lines
2.6 KiB
C
/*-
|
|
* Copyright (C) 1996
|
|
* David L. Nugent. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY DAVID L. NUGENT AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL DAVID L. NUGENT OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef lint
|
|
static const char rcsid[] =
|
|
"$FreeBSD$";
|
|
#endif /* not lint */
|
|
|
|
#include <err.h>
|
|
#include <grp.h>
|
|
#include <libutil.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
|
|
#include "pwupd.h"
|
|
|
|
char *
|
|
getgrpath(const char * file)
|
|
{
|
|
static char pathbuf[MAXPATHLEN];
|
|
|
|
snprintf(pathbuf, sizeof pathbuf, "%s/%s", conf.etcpath, file);
|
|
|
|
return (pathbuf);
|
|
}
|
|
|
|
static int
|
|
gr_update(struct group * grp, char const * group)
|
|
{
|
|
int pfd, tfd;
|
|
struct group *gr = NULL;
|
|
struct group *old_gr = NULL;
|
|
|
|
if (grp != NULL)
|
|
gr = gr_dup(grp);
|
|
|
|
if (group != NULL)
|
|
old_gr = GETGRNAM(group);
|
|
|
|
if (gr_init(conf.etcpath, NULL))
|
|
err(1, "gr_init()");
|
|
|
|
if ((pfd = gr_lock()) == -1) {
|
|
gr_fini();
|
|
err(1, "gr_lock()");
|
|
}
|
|
if ((tfd = gr_tmp(-1)) == -1) {
|
|
gr_fini();
|
|
err(1, "gr_tmp()");
|
|
}
|
|
if (gr_copy(pfd, tfd, gr, old_gr) == -1) {
|
|
gr_fini();
|
|
close(tfd);
|
|
err(1, "gr_copy()");
|
|
}
|
|
fsync(tfd);
|
|
close(tfd);
|
|
if (gr_mkdb() == -1) {
|
|
gr_fini();
|
|
err(1, "gr_mkdb()");
|
|
}
|
|
free(gr);
|
|
gr_fini();
|
|
return 0;
|
|
}
|
|
|
|
|
|
int
|
|
addgrent(struct group * grp)
|
|
{
|
|
return gr_update(grp, NULL);
|
|
}
|
|
|
|
int
|
|
chggrent(char const * login, struct group * grp)
|
|
{
|
|
return gr_update(grp, login);
|
|
}
|
|
|
|
int
|
|
delgrent(struct group * grp)
|
|
{
|
|
|
|
return (gr_update(NULL, grp->gr_name));
|
|
}
|