Mateusz Guzik a21018063b locks: ensure proper barriers are used with atomic ops when necessary ...

Unclear how, but the locking routine for mutexes was using the *release*
barrier instead of acquire. This must have been either a copy-pasto or bad
completion.

Going through other uses of atomics shows no barriers in:
- upgrade routines (addressed in this patch)
- sections protected with turnstile locks - this should be fine as necessary
  barriers are in the worst case provided by turnstile unlock

I would like to thank Mark Millard and andreast@ for reporting the problem and
testing previous patches before the issue got identified.

ps.
  .-'---`-.
,'          `.
|             \
|              \
\           _  \
,\  _    ,'-,/-)\
( * \ \,' ,' ,'-)
 `._,)     -',-')
   \/         ''/
    )        / /
   /       ,'-'

Hardware provided by: IBM LTC

2017-03-01 05:06:21 +00:00

..

bus_if.m

"Buses" is the preferred plural of "bus"

2017-01-15 17:54:01 +00:00

capabilities.conf

Update capabilities.conf comment

2016-09-08 14:04:04 +00:00

clock_if.m

…

cpufreq_if.m

…

device_if.m

Import the 'iflib' API library for network drivers. From the author:

2016-05-18 04:35:58 +00:00

genassym.sh

…

imgact_aout.c

Implement vsyscall hack. Prior to 2.13 glibc uses vsyscall

2016-01-09 20:18:53 +00:00

imgact_binmisc.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

imgact_elf32.c

…

imgact_elf64.c

…

imgact_elf.c

Copy the e_machine and e_flags fields from the binary into an ELF core dump.

2017-02-07 20:34:03 +00:00

imgact_gzip.c

…

imgact_shell.c

…

inflate.c

ANSIfy inflate.c

2016-10-04 17:57:30 +00:00

init_main.c

Bump struct thread alignment to 32.

2017-02-07 17:03:22 +00:00

init_sysent.c

Regenerate all the system call tables to drop "created from" lines.

2017-02-10 19:45:02 +00:00

kern_acct.c

Revert r312119 and reword the intent to fix -Wshadow issues

2017-01-15 09:25:33 +00:00

kern_alq.c

Use SI_SUB_LAST instead of SI_SUB_SMP as the "catch-all" subsystem.

2016-03-11 23:18:06 +00:00

kern_clock.c

Initialize 'ticks' earlier in boot after 'hz' is set.

2016-11-22 01:02:59 +00:00

kern_clocksource.c

Remove cpu_deepest_sleep variable.

2017-02-24 16:11:55 +00:00

kern_condvar.c

Introduce SCHEDULER_STOPPED_TD for use when the thread pointer was already read

2017-02-17 06:45:04 +00:00

kern_conf.c

Undo r309891. Konstantin is right in that this condition normally

2016-12-12 19:11:04 +00:00

kern_cons.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

kern_context.c

…

kern_cpu.c

Add an EARLY_AP_STARTUP option to start APs earlier during boot.

2016-05-14 18:22:52 +00:00

kern_cpuset.c

Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity(),

2017-02-05 13:24:54 +00:00

kern_ctf.c

Fix improper use of "its".

2016-11-08 23:59:41 +00:00

kern_descrip.c

fd: switch fget_unlocked to atomic_fcmpset

2017-02-05 01:40:27 +00:00

kern_dtrace.c

…

kern_dump.c

Add support for encrypted kernel crash dumps.

2016-12-10 16:20:39 +00:00

kern_environment.c

Create wrappers for uint64_t and int64_t for the tunables. While not

2016-04-15 03:09:55 +00:00

kern_et.c

Add labels to sysctls related to clocks.

2016-12-14 12:56:58 +00:00

kern_event.c

Add kevent EVFILT_EMPTY for notification when a client has received all data

2017-01-16 08:25:33 +00:00

kern_exec.c

Apply MADV_FREE to exec_map entries only after a lowmem event.

2017-02-15 01:50:58 +00:00

kern_exit.c

Do not leak mount references for dying threads.

2017-02-25 10:38:18 +00:00

kern_fail.c

Fix some cosmetic issues in kern_fail.c omitted from r296927.

2016-06-09 13:17:08 +00:00

kern_ffclock.c

kernel: use our nitems() macro when it is available through param.h.

2016-04-19 23:48:27 +00:00

kern_fork.c

Defer ptracestop() signals that cannot be delivered immediately

2017-02-20 15:53:16 +00:00

kern_gzio.c

…

kern_hhook.c

Get closer to a VIMAGE network stack teardown from top to bottom rather

2016-06-21 13:48:49 +00:00

kern_idle.c

…

kern_intr.c

…

kern_jail.c

Use inet_ntoa_r() instead of inet_ntoa() throughout the kernel

2017-02-16 20:47:41 +00:00

kern_khelp.c

…

kern_kthread.c

Re-schedule signals after kthread exits, since apparently there are

2016-08-10 13:47:12 +00:00

kern_ktr.c

Fix the logic in the ddb command 'show ktr /a'. Prior to r118269 it would

2016-01-31 17:32:20 +00:00

kern_ktrace.c

ANSYfy kern_ktrace.c and remove archaic register keyword

2017-01-20 14:59:56 +00:00

kern_linker.c

kern_linker: Handle module-loading failures in preloaded .ko files

2016-10-13 02:06:23 +00:00

kern_lock.c

lockmgr: implement fast path

2017-02-12 09:49:44 +00:00

kern_lockf.c

put very expensive sanity checks of advisory locks under DIAGNOSTIC

2017-01-30 15:20:13 +00:00

kern_lockstat.c

mtx: microoptimize lockstat handling in __mtx_lock_sleep

2017-02-17 14:55:59 +00:00

kern_loginclass.c

Speed up rctl operation with large rulesets, by holding the lock

2015-11-15 12:10:51 +00:00

kern_malloc.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

kern_mbuf.c

Import the 'iflib' API library for network drivers. From the author:

2016-05-18 04:35:58 +00:00

kern_mib.c

Mark a bunch of mpsafe sysctls as such.

2016-10-19 19:42:01 +00:00

kern_module.c

Provide better debug message on kernel module name clash.

2015-10-10 09:21:55 +00:00

kern_mtxpool.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

kern_mutex.c

KDTRACE_HOOKS isn't guaranteed to be defined. Change to check to see

2017-02-24 01:39:08 +00:00

kern_ntptime.c

ANSIfy kern_ntptime.c

2017-01-25 20:22:32 +00:00

kern_numa.c

…

kern_osd.c

osd(9): Change array pointer to array pointer type from void*

2016-04-26 19:57:35 +00:00

kern_physio.c

Add four new RCTL resources - readbps, readiops, writebps and writeiops,

2016-04-07 04:23:25 +00:00

kern_pmc.c

Cast values to (int) before comparing them to the range of the

2017-02-24 01:39:12 +00:00

kern_poll.c

…

kern_priv.c

…

kern_proc.c

Make sure the thread constructor and destructor eventhandlers are

2017-02-19 13:15:33 +00:00

kern_procctl.c

reaper: Make REAPER_KILL_SUBTREE actually work.

2016-12-14 22:49:20 +00:00

kern_prot.c

proc: perform a lockless check in sys_issetugid

2017-01-24 21:48:57 +00:00

kern_racct.c

try to fix RACCT_RSS accounting

2017-02-14 13:54:05 +00:00

kern_rangelock.c

…

kern_rctl.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

kern_resource.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

kern_rmlock.c

Bring back r313037, with fixes for mips:

2017-02-19 02:03:09 +00:00

kern_rwlock.c

locks: ensure proper barriers are used with atomic ops when necessary

2017-03-01 05:06:21 +00:00

kern_sdt.c

…

kern_sema.c

…

kern_sendfile.c

Move bogus_page declaration to vm_page.h and initialization to vm_page.c.

2017-01-04 22:27:19 +00:00

kern_sharedpage.c

Split kerne timekeep ABI structure vdso_sv_tk out of the struct

2015-11-23 07:09:35 +00:00

kern_shutdown.c

Revert crap accidentally committed

2017-01-28 16:31:23 +00:00

kern_sig.c

Defer ptracestop() signals that cannot be delivered immediately

2017-02-20 15:53:16 +00:00

kern_switch.c

Add comments explaining unobvious td_critnest adjustments in

2017-01-22 19:41:42 +00:00

kern_sx.c

locks: ensure proper barriers are used with atomic ops when necessary

2017-03-01 05:06:21 +00:00

kern_synch.c

Introduce SCHEDULER_STOPPED_TD for use when the thread pointer was already read

2017-02-17 06:45:04 +00:00

kern_syscalls.c

…

kern_sysctl.c

Document the existence of the {0, 6, ...} sysctl.

2016-12-15 15:45:11 +00:00

kern_tc.c

Add labels to sysctls related to clocks.

2016-12-14 12:56:58 +00:00

kern_thr.c

Defer ptracestop() signals that cannot be delivered immediately

2017-02-20 15:53:16 +00:00

kern_thread.c

Do not leak mount references for dying threads.

2017-02-25 10:38:18 +00:00

kern_time.c

Use time_t for intermediate values to avoid overflow in clock_ts_to_ct

2017-01-24 18:05:29 +00:00

kern_timeout.c

Permit timed sleeps for threads other than thread0 before timers are working.

2016-11-25 18:02:43 +00:00

kern_umtx.c

Add sem_clockwait_np()

2017-02-23 19:36:38 +00:00

kern_uuid.c

…

kern_xxx.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

ksched.c

…

link_elf_obj.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

link_elf.c

kern: for pointers replace 0 with NULL.

2016-04-15 16:10:11 +00:00

linker_if.m

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

Make.tags.inc

Bring the tags and links entries for amd64 up to date.

2015-10-27 22:59:24 +00:00

Makefile

Don't create pointless backups of generated files in "make sysent".

2016-07-28 21:29:04 +00:00

makesyscalls.sh

Remove SVR4 (System V Release 4) binary compatibility support.

2017-02-28 05:14:42 +00:00

md4c.c

crypto routines: Hint minimum buffer sizes to the compiler

2016-05-26 19:29:29 +00:00

md5c.c

crypto routines: Hint minimum buffer sizes to the compiler

2016-05-26 19:29:29 +00:00

msi_if.m

Introduce MSI and MSI-X support to intrng. This adds a new msi device

2016-05-16 09:11:40 +00:00

p1003_1b.c

…

pic_if.m

INTRNG: Rework handling with resources. Partially revert r301453.

2016-08-19 10:52:39 +00:00

posix4_mib.c

posix4_mib: Don't overrun facility_initialized array

2016-04-27 00:10:32 +00:00

sched_4bsd.c

Revert r313814 and r313816

2017-02-16 21:18:31 +00:00

sched_ule.c

Revert r313814 and r313816

2017-02-16 21:18:31 +00:00

serdev_if.m

…

stack_protector.c

…

subr_acl_nfs4.c

…

subr_acl_posix1e.c

…

subr_autoconf.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_blist.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_bufring.c

…

subr_bus_dma.c

Fix a bug introduced in r291716:

2016-01-11 20:38:39 +00:00

subr_bus.c

"Buses" is the preferred plural of "bus"

2017-01-15 17:54:01 +00:00

subr_busdma_bufalloc.c

Fix printf format to allow for bus_size_t not being u_long on all platforms.

2015-10-20 03:25:17 +00:00

subr_capability.c

capsicum: plug spurious memset in __cap_rights_init

2015-12-01 02:48:42 +00:00

subr_clock.c

Use time_t for intermediate values to avoid overflow in clock_ts_to_ct

2017-01-24 18:05:29 +00:00

subr_counter.c

Zero return value when counter_rate() switches over to next second and

2016-12-13 20:11:45 +00:00

subr_devmap.c

Include machine/acle-compat.h in cdefs.h on arm if the compiler doesn't

2016-05-25 19:44:26 +00:00

subr_devstat.c

Add support for managing Shingled Magnetic Recording (SMR) drives.

2016-05-19 14:08:36 +00:00

subr_disk.c

…

subr_dummy_vdso_tc.c

…

subr_eventhandler.c

…

subr_fattime.c

…

subr_firmware.c

Fix improper use of "its".

2016-11-08 23:59:41 +00:00

subr_gtaskqueue.c

A few more style bugs lying around in here.

2017-01-26 13:48:45 +00:00

subr_hash.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_hints.c

…

subr_intr.c

Only allow the pic type to be either a PIC or MSI type. All interrupt

2017-02-06 13:08:48 +00:00

subr_kdb.c

…

subr_kobj.c

…

subr_lock.c

locks: follow up r313386

2017-02-07 16:01:07 +00:00

subr_log.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_mbpool.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

subr_mchain.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_module.c

…

subr_msgbuf.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

subr_param.c

Initialize 'ticks' earlier in boot after 'hz' is set.

2016-11-22 01:02:59 +00:00

subr_pcpu.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_pctrie.c

sys: extend use of the howmany() macro when available.

2016-04-26 15:38:17 +00:00

subr_power.c

…

subr_prf.c

Provide a comment on why stdio.h needs to be included.

2017-02-28 21:27:51 +00:00

subr_prof.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_rman.c

Add new bus methods for mapping resources.

2016-05-20 17:57:47 +00:00

subr_rtc.c

Make resettodr_lock accessible outside subr_rtc.c. Protect

2016-09-21 10:15:08 +00:00

subr_sbuf.c

Fail the sbuf if vsnprintf(3) fails.

2015-10-02 09:23:14 +00:00

subr_scanf.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

subr_sfbuf.c

subr_sfbus.c need sys/proc.h for struct thread definition.

2017-02-07 17:31:24 +00:00

subr_sglist.c

Add sglist functions for working with arrays of VM pages.

2016-05-20 23:28:43 +00:00

subr_sleepqueue.c

sleepq_catch_signals: do thread suspension before signal check

2017-02-14 17:13:23 +00:00

subr_smp.c

Handle broadcast NMIs.

2016-10-24 16:40:27 +00:00

subr_stack.c

Add support for a configurable output channel to witness(4).

2015-11-19 05:56:59 +00:00

subr_syscall.c

Defer ptracestop() signals that cannot be delivered immediately

2017-02-20 15:53:16 +00:00

subr_taskqueue.c

While draining a timeout task prevent the taskqueue_enqueue_timeout()

2016-09-29 10:38:20 +00:00

subr_terminal.c

Fix a panic during boot caused by inadequate locking of some vt(4) driver

2017-02-23 01:18:47 +00:00

subr_trap.c

Do not leak mount references for dying threads.

2017-02-25 10:38:18 +00:00

subr_turnstile.c

ddb(4): Add sleepchains to "show allchains"

2016-10-22 18:02:20 +00:00

subr_uio.c

Switch copyout_map() to use vm_mmap_object() instead of vm_mmap().

2017-02-12 20:54:31 +00:00

subr_unit.c

Clean up trailing whitespace

2017-01-14 04:16:13 +00:00

subr_vmem.c

subr_vmem: Fix double-free in error case of vmem_create

2016-05-11 23:16:11 +00:00

subr_witness.c

Make witness_warn() always print to the console.

2017-02-05 02:27:04 +00:00

sys_capability.c

capsicum: perform copyout without the fildesc lock held in sys_cap_ioctls_get

2016-10-21 16:12:23 +00:00

sys_generic.c

Add kern_pread() and kern_pwrite(), and use it in compats instead

2017-01-31 15:35:18 +00:00

sys_pipe.c

Generate syscall tables and update pipe() implementation after r302094.

2016-06-22 21:18:19 +00:00

sys_procdesc.c

Hide the boottime and bootimebin globals, provide the getboottime(9)

2016-07-27 11:08:59 +00:00

sys_process.c

Defer ptracestop() signals that cannot be delivered immediately

2017-02-20 15:53:16 +00:00

sys_socket.c

Set MORETOCOME for AIO write requests on a socket.

2017-01-06 23:41:45 +00:00

syscalls.c

Regenerate all the system call tables to drop "created from" lines.

2017-02-10 19:45:02 +00:00

syscalls.master

Rename the 'flags' argument to getfsstat() to 'mode' and validate it.

2016-12-27 20:21:11 +00:00

systrace_args.c

Regen after r310638.

2016-12-27 20:22:17 +00:00

sysv_ipc.c

…

sysv_msg.c

Remove a comment that was part of copied code, and is misleading in

2016-06-09 15:34:33 +00:00

sysv_sem.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

sysv_shm.c

Add shmatt_t.

2016-07-26 17:23:49 +00:00

tty_compat.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

tty_info.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

tty_inq.c

Check tty_gone() after allocating IO buffers. The tty lock has to be

2017-01-13 16:37:38 +00:00

tty_outq.c

Check tty_gone() after allocating IO buffers. The tty lock has to be

2017-01-13 16:37:38 +00:00

tty_pts.c

sys/kern: spelling fixes in comments.

2016-04-29 22:15:33 +00:00

tty_tty.c

…

tty_ttydisc.c

Don't clear the software flow control flag before draining for last

2016-01-26 14:46:39 +00:00

tty.c

Correct the comments about how much buffer is allocated.

2017-01-13 17:03:23 +00:00

uipc_accf.c

Use correct size type in do_setopt_accept_filter

2016-10-12 00:56:49 +00:00

uipc_debug.c

Refactor the AIO subsystem to permit file-type-specific handling and

2016-03-01 18:12:14 +00:00

uipc_domain.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

uipc_mbuf2.c

Remove writability requirement for single-mbuf, contiguous-range

2017-01-12 06:38:03 +00:00

uipc_mbuf.c

Suppress a warning about m_assertbuf being unused.

2017-01-15 03:53:20 +00:00

uipc_mbufhash.c

…

uipc_mqueue.c

Fix panic with unlocked vnode to vrecycle().

2017-02-18 05:07:53 +00:00

uipc_sem.c

Clean up some style(9) violations.

2016-04-14 17:07:26 +00:00

uipc_shm.c

Consistently handle negative or wrapping offsets in the mmap(2) syscalls.

2017-02-12 21:05:44 +00:00

uipc_sockbuf.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

uipc_socket.c

Merge filt_soread and filt_solisten and decide what to do when checking

2017-02-01 13:12:07 +00:00

uipc_syscalls.c

Add kern_listen(), kern_shutdown(), and kern_socket(), and use them

2017-01-30 12:57:22 +00:00

uipc_usrreq.c

For non-listening AF_UNIX sockets return error code EOPNOTSUPP to match

2017-01-25 22:26:45 +00:00

vfs_acl.c

…

vfs_aio.c

Rework r313352.

2017-02-13 09:04:38 +00:00

vfs_bio.c

Do not set BIO_DONE if the BIO specifies a completion handler.

2017-01-10 21:41:28 +00:00

vfs_cache.c

cache: use vrefact for '.' lookups and refing the rdir in fullpath

2017-01-30 03:20:05 +00:00

vfs_cluster.c

Move bogus_page declaration to vm_page.h and initialization to vm_page.c.

2017-01-04 22:27:19 +00:00

vfs_default.c

Make the code match the comments: If we have ANY buf's that failed

2017-02-21 18:56:06 +00:00

vfs_export.c

Fix build when no INET and INET6 in kernel config.

2016-11-17 16:13:30 +00:00

vfs_extattr.c

…

vfs_hash.c

Add vfs_hash_ref(9) function, which finds a vnode by the hash value

2016-05-11 06:32:22 +00:00

vfs_init.c

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00

vfs_lookup.c

Provide fallback VOP methods for crossmp vnode.

2017-01-22 19:36:02 +00:00

vfs_mount.c

Do not allocate struct statfs on kernel stack.

2017-01-05 17:19:26 +00:00

vfs_mountroot.c

Make root_mount_hold() work after boot. This is important for two

2017-02-06 20:44:34 +00:00

vfs_subr.c

vfs: use atomic_fcmpset in vfs_refcount_*

2017-02-05 03:23:16 +00:00

vfs_syscalls.c

Replace calls to sys_truncate() with kern_truncate().

2017-01-31 15:19:44 +00:00

vfs_vnops.c

Apply noexec mount option for mmap(PROT_EXEC).

2017-02-19 20:51:04 +00:00

vnode_if.src

Renumber license clauses in sys/kern to avoid skipping #3

2016-09-15 13:16:20 +00:00