59dd72d040
dispatched without Giant, and add NETISR_FORCEQUEUE, which allows specific netisr handlers to always be dispatched via a queue (deferred). Mark the usb and if_ppp netisr handlers as NETISR_FORCEQUEUE, and explicitly acquire Giant in those handlers. Previously, any netisr handler not marked NETISR_MPSAFE would necessarily run deferred and with Giant acquired. This change removes Giant scaffolding from the netisr infrastructure, but NETISR_FORCEQUEUE allows non-MPSAFE handlers to continue to force deferred dispatch so as to avoid lock order reversals between their acqusition of Giant and any calling context. It is likely we will be able to remove NETISR_FORCEQUEUE once IFF_NEEDSGIANT is removed, as non-MPSAFE usb and if_ppp drivers will no longer be supported. Reviewed by: bz MFC after: 1 month X-MFC note: We can't remove NETISR_MPSAFE from stable/7 for KPI reasons, but the rest can go back. |
||
---|---|---|
.. | ||
ipx_cksum.c | ||
ipx_if.h | ||
ipx_input.c | ||
ipx_outputfl.c | ||
ipx_pcb.c | ||
ipx_pcb.h | ||
ipx_proto.c | ||
ipx_usrreq.c | ||
ipx_var.h | ||
ipx.c | ||
ipx.h | ||
README | ||
spx_debug.c | ||
spx_debug.h | ||
spx_timer.h | ||
spx_usrreq.c | ||
spx_var.h | ||
spx.h |
$FreeBSD$ This protocol implements IPX/SPX over Ethernet_II frame type 0x8137. Please note: the SPX implementation may require further work and testing to insure proper operation. Mike Mitchell, Network Engineer AMTECH Systems Corporation, Technology and Manufacturing 8600 Jefferson Street, Albuquerque, New Mexico 87113 (505) 856-8000 supervisor@alb.asctmd.com John Hay Some Company Some Address jhay@mikom.csir.co.za Adapted for multi-processor, multi-threaded network stack by Robert N. M. Watson, Computer Laboratory, University of Cambridge. --- Copyright Information --- /*- Copyright (c) 1984, 1985, 1986, 1987, 1993 The Regents of the University of California. All rights reserved. Modifications Copyright (c) 1995, Mike Mitchell Modifications Copyright (c) 1995, John Hay Modifications Copyright (c) 2004-2006 Robert N. M. Watson */ --- TODO --- (1) netipx default socket buffer sizes are very small by contemporary standards, and should be increased following testing and measurement. (2) SPX will free the PCB and socket buffer memory on close(), which means close() in effects terminates the transfer of any outstanding buffered but unsent data. As with TCP, it should instead grab its own reference to the socket so that it is not released, as hold onto it until the data transfer is complete. (3) Raw socket capture of IPX output intercepts packets in the SPX output routine in order to feed them back into the raw socket. This results in recursion into the socket code in the transmit path; instead, captured packets should be fed into a netisr that reinjects them into raw sockets from a new (asynchronous) context. (4) IPX over IP encapsulation needs work to make it properly MPSAFE.