10f81a9b3b
- kvm_close: add a testcase to verify support for errno = EINVAL / -1
(see D10065) when kd == NULL is provided to the libcall.
- kvm_geterr:
-- Add a negative testcase for kd == NULL returning "" (see D10022).
-- Add two positive testcases:
--- test the error case using kvm_write on a O_RDONLY descriptor.
--- test the "no error" case using kvm_read(3) and kvm_nlist(3) as
helper routines and by injecting a bogus error message via
_kvm_err (an internal API) _kvm_err was used as there isn't a
formalized way to clear the error output, and because
kvm_nlist always returns ENOENT with the NULL terminator today.
- kvm_open, kvm_open2:
-- Add some basic negative tests for kvm_open(3) and kvm_open2(3).
Testing positive cases with a specific
`corefile`/`execfile`/`resolver` requires more work and would require
user intervention today in order to reliably test this out.
Reviewed by: markj
MFC after: 2 months
Sponsored by: Dell EMC Isilon
Differential Revision: D10024
118 lines
3.7 KiB
C
118 lines
3.7 KiB
C
/*-
|
|
* Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#include <sys/param.h>
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <kvm.h>
|
|
#include <limits.h>
|
|
#include <paths.h>
|
|
#include <signal.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <atf-c.h>
|
|
|
|
#include "kvm_test_common.h"
|
|
|
|
ATF_TC_WITHOUT_HEAD(kvm_open2_negative_test_nonexistent_corefile);
|
|
ATF_TC_BODY(kvm_open2_negative_test_nonexistent_corefile, tc)
|
|
{
|
|
|
|
errbuf_clear();
|
|
ATF_CHECK(kvm_open2(NULL, "/nonexistent", O_RDONLY, NULL, NULL) == NULL);
|
|
ATF_CHECK(!errbuf_has_error(errbuf));
|
|
errbuf_clear();
|
|
ATF_CHECK(kvm_open2(NULL, "/nonexistent", O_RDONLY,
|
|
errbuf, NULL) == NULL);
|
|
ATF_CHECK(errbuf_has_error(errbuf));
|
|
}
|
|
|
|
ATF_TC_WITHOUT_HEAD(kvm_open2_negative_test_nonexistent_execfile);
|
|
ATF_TC_BODY(kvm_open2_negative_test_nonexistent_execfile, tc)
|
|
{
|
|
|
|
errbuf_clear();
|
|
ATF_CHECK(kvm_open2("/nonexistent", _PATH_DEVZERO, O_RDONLY,
|
|
NULL, NULL) == NULL);
|
|
ATF_CHECK(strlen(errbuf) == 0);
|
|
errbuf_clear();
|
|
ATF_CHECK(kvm_open2("/nonexistent", _PATH_DEVZERO, O_RDONLY,
|
|
errbuf, NULL) == NULL);
|
|
ATF_CHECK(errbuf_has_error(errbuf));
|
|
}
|
|
|
|
ATF_TC(kvm_open2_negative_test_invalid_corefile);
|
|
ATF_TC_HEAD(kvm_open2_negative_test_invalid_corefile, tc)
|
|
{
|
|
|
|
atf_tc_set_md_var(tc, "require.user", "root");
|
|
}
|
|
|
|
ATF_TC_BODY(kvm_open2_negative_test_invalid_corefile, tc)
|
|
{
|
|
kvm_t *kd;
|
|
|
|
errbuf_clear();
|
|
atf_utils_create_file("some-file", "this is a text file");
|
|
kd = kvm_open2(NULL, "some-file", O_RDONLY, errbuf, NULL);
|
|
ATF_CHECK(errbuf_has_error(errbuf));
|
|
ATF_REQUIRE_MSG(kd == NULL, "kvm_open2 succeeded");
|
|
}
|
|
|
|
ATF_TC(kvm_open2_negative_test_invalid_execfile);
|
|
ATF_TC_HEAD(kvm_open2_negative_test_invalid_execfile, tc)
|
|
{
|
|
|
|
atf_tc_set_md_var(tc, "require.user", "root");
|
|
}
|
|
|
|
ATF_TC_BODY(kvm_open2_negative_test_invalid_execfile, tc)
|
|
{
|
|
kvm_t *kd;
|
|
|
|
errbuf_clear();
|
|
atf_utils_create_file("some-file", "this is a text file");
|
|
kd = kvm_open2("some-file", "/bin/sh", O_RDONLY, errbuf, NULL);
|
|
ATF_CHECK(errbuf_has_error(errbuf));
|
|
ATF_REQUIRE_MSG(kd == NULL, "kvm_open2 succeeded unexpectedly");
|
|
}
|
|
|
|
ATF_TP_ADD_TCS(tp)
|
|
{
|
|
|
|
ATF_TP_ADD_TC(tp, kvm_open2_negative_test_invalid_corefile);
|
|
ATF_TP_ADD_TC(tp, kvm_open2_negative_test_invalid_execfile);
|
|
ATF_TP_ADD_TC(tp, kvm_open2_negative_test_nonexistent_corefile);
|
|
ATF_TP_ADD_TC(tp, kvm_open2_negative_test_nonexistent_execfile);
|
|
|
|
return (atf_no_error());
|
|
}
|