430f7286a5
after r298107
Summary of changes:
- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that
namespacing is kept with FILES appropriately, and that this shouldn't need
to be repeated if the namespace changes -- only the definition of PACKAGE
needs to be changed
- Allow PACKAGE to be overridden by callers instead of forcing it to always be
`tests`. In the event we get to the point where things can be split up
enough in the base system, it would make more sense to group the tests
with the blocks they're a part of, e.g. byacc with byacc-tests, etc
- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used
previously.
- Remove unnecessary TESTSPACKAGE definitions; this has been elided into
bsd.tests.mk
- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES;
${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.
- Fix installation of files under data/ subdirectories in lib/libc/tests/hash
and lib/libc/tests/net/getaddrinfo
- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)
Document the proposed changes in share/examples/tests/tests/... via examples
so it's clear that ${PACKAGES}FILES is the suggested way forward in terms of
replacing FILES. share/mk/bsd.README didn't seem like the appropriate method
of communicating that info.
MFC after: never probably
X-MFC with: r298107
PR: 209114
Relnotes: yes
Tested with: buildworld, installworld, checkworld; buildworld, packageworld
Sponsored by: EMC / Isilon Storage Division
103 lines
3.3 KiB
Makefile
103 lines
3.3 KiB
Makefile
# $FreeBSD$
|
|
#
|
|
# You must include bsd.test.mk instead of this file from your Makefile.
|
|
#
|
|
# Internal glue for the build of /usr/tests/.
|
|
|
|
.if !target(__<bsd.test.mk>__)
|
|
.error suite.test.mk cannot be included directly.
|
|
.endif
|
|
|
|
# Name of the test suite these tests belong to. Should rarely be changed for
|
|
# Makefiles built into the FreeBSD src tree.
|
|
TESTSUITE?= FreeBSD
|
|
|
|
# Knob to control the handling of the Kyuafile for this Makefile.
|
|
#
|
|
# If 'yes', a Kyuafile exists in the source tree and is installed into
|
|
# TESTSDIR.
|
|
#
|
|
# If 'auto', a Kyuafile is automatically generated based on the list of test
|
|
# programs built by the Makefile and is installed into TESTSDIR. This is the
|
|
# default and is sufficient in the majority of the cases.
|
|
#
|
|
# If 'no', no Kyuafile is installed.
|
|
KYUAFILE?= auto
|
|
|
|
# Per-test program interface definition.
|
|
#
|
|
# The name provided here must match one of the interface names supported by
|
|
# Kyua as this is later encoded in the Kyuafile test program definitions.
|
|
#TEST_INTERFACE.<test-program>= interface-name
|
|
|
|
# Metadata properties applicable to all test programs.
|
|
#
|
|
# All the variables for a test program defined in the Makefile are appended
|
|
# to the test program's definition in the Kyuafile. This feature can be
|
|
# used to avoid having to explicitly supply a Kyuafile in the source
|
|
# directory, allowing the caller Makefile to rely on the KYUAFILE=auto
|
|
# behavior defined here.
|
|
#TEST_METADATA+= key="value"
|
|
|
|
# Per-test program metadata properties as a list of key/value pairs.
|
|
#
|
|
# These per-test program settings _extend_ the values provided in the
|
|
# unqualified TEST_METADATA variable.
|
|
#TEST_METADATA.<test-program>+= key="value"
|
|
|
|
.if ${KYUAFILE:tl} != "no"
|
|
${PACKAGE}FILES+= Kyuafile
|
|
${PACKAGE}FILESDIR_Kyuafile= ${TESTSDIR}
|
|
.endif
|
|
|
|
.for _T in ${_TESTS}
|
|
_TEST_METADATA.${_T}= ${TEST_METADATA} ${TEST_METADATA.${_T}}
|
|
.endfor
|
|
|
|
.if ${KYUAFILE:tl} == "auto"
|
|
CLEANFILES+= Kyuafile Kyuafile.tmp
|
|
Kyuafile: Makefile
|
|
@{ \
|
|
echo '-- Automatically generated by bsd.test.mk.'; \
|
|
echo; \
|
|
echo 'syntax(2)'; \
|
|
echo; \
|
|
echo 'test_suite("${TESTSUITE}")'; \
|
|
echo; \
|
|
} > ${.TARGET}.tmp
|
|
.for _T in ${_TESTS}
|
|
@echo '${TEST_INTERFACE.${_T}}_test_program{name="${_T}"${_TEST_METADATA.${_T}:C/$/,/:tW:C/^/, /W:C/,$//W}}' \
|
|
>>${.TARGET}.tmp
|
|
.endfor
|
|
.for _T in ${TESTS_SUBDIRS:N.WAIT}
|
|
@echo "include(\"${_T}/${.TARGET}\")" >>${.TARGET}.tmp
|
|
.endfor
|
|
@mv ${.TARGET}.tmp ${.TARGET}
|
|
.endif
|
|
|
|
CHECKDIR?= ${DESTDIR}${TESTSDIR}
|
|
|
|
KYUA= ${LOCALBASE}/bin/kyua
|
|
|
|
# Definition of the "make check" target and supporting variables.
|
|
#
|
|
# This target, by necessity, can only work for native builds (i.e. a FreeBSD
|
|
# host building a release for the same system). The target runs Kyua, which is
|
|
# not in the toolchain, and the tests execute code built for the target host.
|
|
#
|
|
# Due to the dependencies of the binaries built by the source tree and how they
|
|
# are used by tests, it is highly possible for a execution of "make test" to
|
|
# report bogus results unless the new binaries are put in place.
|
|
|
|
realcheck: .PHONY
|
|
@if [ ! -x ${KYUA} ]; then \
|
|
echo; \
|
|
echo "kyua binary not installed at expected location (${.TARGET})"; \
|
|
echo; \
|
|
echo "Please install via pkg install, or specify the path to the kyua"; \
|
|
echo "package via the \$${LOCALBASE} variable, e.g. "; \
|
|
echo "LOCALBASE=\"${LOCALBASE}\""; \
|
|
false; \
|
|
fi
|
|
@${KYUA} test -k ${CHECKDIR}/Kyuafile
|