d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
aaf1597b1d
freebsd-skq/sys
History
glebius aaf1597b1d Fix from r226623 is not sufficient to close all races in pfsync(4). 
The root of problem is re-locking at the end of pfsync_sendout().
Several functions are calling pfsync_sendout() holding pointers
to pf data on stack, and these functions expect this data to be
consistent.

To fix this, the following approach was taken:

- The pfsync_sendout() doesn't call ip_output() directly, but
  enqueues the mbuf on sc->sc_ifp's interfaces queue, that
  is currently unused. Then pfsync netisr is scheduled. PF_LOCK
  isn't dropped in pfsync_sendout().
- The netisr runs through queue and ip_output()s packets
  on it.

Apart from fixing race, this also decouples stack, fixing
potential issues, that may happen, when sending pfsync(4)
packets on input path.

Reviewed by:	eri (a quick review)
2011-10-23 14:59:54 +00:00
..
amd64 People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
arm People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
boot With LOADER_MBR_SUPPORT defined and LOADER_GPT_SUPPORT undefined we would 2011-10-20 15:46:54 +00:00
bsm Add ECAPMODE, "Not permitted in capability mode", a new kernel errno 2011-03-01 13:14:28 +00:00
cam Add descriptor sense support to CAM, and honor sense residuals properly in 2011-10-03 20:32:55 +00:00
cddl Update per-thread I/O statistics collection in ZFS. 2011-10-21 21:49:34 +00:00
compat Control the execution permission of the readable segments for 2011-10-15 12:35:18 +00:00
conf FDT support for MIPS. 2011-10-18 07:29:21 +00:00
contrib Fix from r226623 is not sufficient to close all races in pfsync(4). 2011-10-23 14:59:54 +00:00
crypto Fix a bug in the result of manual assembly. 2011-03-02 14:56:58 +00:00
ddb Follow up to r225203 refining break-to-debugger run-time configuration 2011-08-27 14:24:27 +00:00
dev Add new USB IDs to RUN driver. Update usb.conf. 2011-10-19 10:09:01 +00:00
fs Trace attempts to open a portal device. 2011-10-18 07:31:49 +00:00
gdb Modify kdb_trap() so that it re-calls the dbbe_trap function as long as 2011-02-18 22:25:11 +00:00
geom Add support for Boot Camp. The support is defined as follows: 2011-10-23 02:51:23 +00:00
gnu Second-to-last commit implementing Capsicum capabilities in the FreeBSD 2011-08-11 12:30:23 +00:00
i386 People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
ia64 People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
isa MFC 2011-05-09 18:53:13 +00:00
kern Revisit the capability failure trace points. The initial implementation 2011-10-18 07:28:58 +00:00
kgssapi Add missing break statement to make sure all 3DES etypes really are treated 2011-10-10 09:13:07 +00:00
libkern Add strnlen() to libkern. 2011-10-04 23:53:47 +00:00
mips People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
modules - Follow the lead of dcphy(4) and pnphy(4) and move the reminder of the PHY 2011-10-08 12:33:10 +00:00
net Add missing #includes. 2011-10-21 12:58:34 +00:00
net80211 Fix an unused variable warning/error when invariants isn't enabled. 2011-10-12 10:19:55 +00:00
netatalk
netgraph Free mbuf in case when protocol in unknown in ng_ipfw_rcvdata(). 2011-10-10 09:33:07 +00:00
netinet Add missing #includes. 2011-10-21 12:58:34 +00:00
netinet6 The code change made in r226040 was incomplete and resulted in 2011-10-16 22:24:04 +00:00
netipsec Add missing va_end() in an error case to clean up after va_start() 2011-10-07 21:00:26 +00:00
netipx
netnatm
netncp Change ncp_scan_bindery_object() to pass a constant search string. 2011-10-16 08:44:03 +00:00
netsmb Change some variables from int to size_t. This is more accurate since 2011-01-08 23:06:54 +00:00
nfs In order to maximize the re-usability of kernel code in user space this 2011-09-16 13:58:51 +00:00
nfsclient Merge 220876, 220877, and 221537 from the new NFS client to the old: 2011-08-09 15:29:58 +00:00
nfsserver Fix the NFS servers so that they can do a Lookup of "..", 2011-09-03 00:28:53 +00:00
nlm In order to maximize the re-usability of kernel code in user space this 2011-09-16 13:58:51 +00:00
ofed - change "is is" to "is" or "it is" 2011-10-16 14:30:28 +00:00
opencrypto Add the fo_chown and fo_chmod methods to struct fileops and use them 2011-08-16 20:07:47 +00:00
pc98 MFi386: revision 225936 2011-10-04 13:24:22 +00:00
pci Close a race where SIOCGIFMEDIA ioctl get inconsistent link status. 2011-10-17 19:49:00 +00:00
powerpc People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
rpc Remove an extraneous "already" from a comment introduced by r226081. 2011-10-07 13:16:21 +00:00
security Get rid of D_PSEUDO. 2011-10-18 08:09:44 +00:00
sparc64 People porting FreeBSD to new architectures ought not have to 2011-10-21 06:41:46 +00:00
sys Add missing DEBUG define from r226514. 2011-10-19 07:16:57 +00:00
teken Link the demo application against ncursesw to make Unicode work. 2011-10-13 14:20:27 +00:00
tools GNU awk does not output escaped newlines in multi-line printc statements. This 2011-03-31 21:33:33 +00:00
ufs This update eliminates a lock-order reversal warning discovered 2011-09-27 17:41:48 +00:00
vm VN_NRESERVLEVEL is used in this file but opt_vm is not included 2011-10-22 22:00:35 +00:00
x86 Ignore SRAT memory entries if the memory range does not overlap with an 2011-10-05 16:03:47 +00:00
xdr
xen Properly handle suspend/resume events in the Xen device 2011-09-20 23:44:34 +00:00
Makefile Include sys/xen in cscope tag file generation. 2011-06-10 20:51:41 +00:00