84d2b7df26
as they both interact with the tty code (!MPSAFE) and may sleep if the tty buffer is full (per comment). Modify all consumers of uprintf() and tprintf() to hold Giant around calls into these functions. In most cases, this means adding an acquisition of Giant immediately around the function. In some cases (nfs_timer()), it means acquiring Giant higher up in the callout. With these changes, UFS no longer panics on SMP when either blocks are exhausted or inodes are exhausted under load due to races in the tty code when running without Giant. NB: Some reduction in calls to uprintf() in the svr4 code is probably desirable. NB: In the case of nfs_timer(), calling uprintf() while holding a mutex, or even in a callout at all, is a bad idea, and will generate warnings and potential upset. This needs to be fixed, but was a problem before this change. NB: uprintf()/tprintf() sleeping is generally a bad ideas, as is having non-MPSAFE tty code. MFC after: 1 week |
||
|---|---|---|
| .. | ||
| linux_file.c | ||
| linux_getcwd.c | ||
| linux_ioctl.c | ||
| linux_ioctl.h | ||
| linux_ipc.c | ||
| linux_ipc.h | ||
| linux_mib.c | ||
| linux_mib.h | ||
| linux_misc.c | ||
| linux_signal.c | ||
| linux_signal.h | ||
| linux_socket.c | ||
| linux_socket.h | ||
| linux_stats.c | ||
| linux_sysctl.c | ||
| linux_sysproto.h | ||
| linux_uid16.c | ||
| linux_util.c | ||
| linux_util.h | ||