freebsd kernel with SKQ
Go to file
Olivier Houchard b21a1da537 Close a race.
The RAS implementation would set the end address, then the start
address.  These were used by the kernel to restart a RAS sequence if
it was interrupted.  When the thread switching code ran, it would
check these values and adjust the PC and clear them if it did.

However, there's a small flaw in this scheme.  Thread T1, sets the end
address and gets preempted.  Thread T2 runs and also does a RAS
operation.  This resets end to zero.  Thread T1 now runs again and
sets start and then begins the RAS sequence, but is preempted before
the RAS sequence executes its last instruction.  The kernel code that
would ordinarily restart the RAS sequence doesn't because the PC isn't
between start and 0, so the PC isn't set to the start of the sequence.
So when T1 is resumed again, it is at the wrong location for RAS to
produce the correct results.  This causes the wrong results for the
atomic sequence.

The window for the first race is 3 instructions.  The window for the
second race is 5-10 instructions depending on the atomic operation.
This makes this failure fairly rare and hard to reproduce.

Mutexs are implemented in libthr using atomic operations.  When the
above race would occur, a lock could get stuck locked, causing many
downstream problems, as you might expect.

Also, make sure to reset the start and end address when doing a syscall, or
a malicious process could set them before doing a syscall.

Reviewed by: imp, ups (thanks guys)
Pointy hat to:	cognet
MFC After:	3 days
2007-12-02 12:49:28 +00:00
bin Reduce the WARNS level to avoid a compiler warning about a variable 2007-11-18 01:53:07 +00:00
cddl Remove _SOLARIS_C_SOURCE now that it doesn't do anything in FreeBSD 2007-11-28 22:58:09 +00:00
compat/opensolaris Add more OpenSolaris compatibilty headers. 2007-11-28 21:40:07 +00:00
contrib Remove a couple of definitions which now exist in compatibility headers. 2007-11-28 22:10:36 +00:00
crypto This commit was generated by cvs2svn to compensate for changes in r172767, 2007-10-18 20:19:33 +00:00
etc Add /root/, /.cshrc, and /.profile to the default UpdateIfUnmodified 2007-11-28 22:45:09 +00:00
games Revise the markup. 2007-11-07 12:08:03 +00:00
gnu Tweak -lpmc's name. 2007-11-27 10:00:33 +00:00
include Only protect the prototypes with #ifndef _ASSERT_H_, the standards 2007-12-01 19:28:13 +00:00
kerberos5 While checking over the libraries for 7.0-REL Kris found the following 2007-11-20 04:20:32 +00:00
lib For un-prototyped static inline functions declared in pthread_md.h on 2007-12-01 14:23:29 +00:00
libexec For un-prototyped static inline functions declared in pthread_md.h on 2007-12-01 14:24:44 +00:00
release Use "8-current" manpage entities. 2007-11-30 05:01:23 +00:00
rescue o Build geom for all platforms. 2007-11-04 00:44:10 +00:00
sbin Expand the EXAMPLES section for atacontrol.8 2007-11-28 21:37:25 +00:00
secure - Bump share library version which were missed in last bump 2007-06-18 18:47:54 +00:00
share Modify stack(9) stack_print() and stack_sbuf_print() routines to use new 2007-12-01 22:04:16 +00:00
sys Close a race. 2007-12-02 12:49:28 +00:00
tools Convert errx(-1, ..., strerror(errno)) to err(-1, ...). 2007-11-28 20:38:05 +00:00
usr.bin Add a cross-reference to newgrp(1). 2007-11-30 11:02:36 +00:00
usr.sbin s/effect/affect/ 2007-11-27 06:50:21 +00:00
COPYRIGHT Welcome to 2007 2006-12-31 16:35:29 +00:00
LOCKS Document commit constraints for RELENG_6_*. 2006-01-13 06:51:43 +00:00
MAINTAINERS Update the maintainer id for em driver. 2007-05-23 21:47:19 +00:00
Makefile Do not bail out for cleanworld target just because 2007-10-18 08:41:52 +00:00
Makefile.inc1 Decouple the install tools from the main system as much as possible. 2007-10-31 09:26:42 +00:00
ObsoleteFiles.inc To reduce the impact of possible removal of the syscalls required by 2007-11-29 21:49:08 +00:00
README Simply running ``make world'' will bomb unless you dig up the 2006-06-07 03:33:48 +00:00
UPDATING Mention ADAPTIVE_GIANT removal. 2007-11-28 13:04:11 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree, the most
commonly used one being ``world'', which rebuilds and installs
everything in the FreeBSD system from the source tree except the
kernel, the kernel-modules and the contents of /etc.  The ``world''
target should only be used in cases where the source tree has not
changed from the currently running version.  See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The ``buildkernel'' and ``installkernel'' targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process, documentation
for which can be found at:
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
And in the config(8) man page.
Note: If you want to build and install the kernel with the
``buildkernel'' and ``installkernel'' targets, you might need to build
world before.  More information is available in the handbook.

The sample kernel configuration files reside in the sys/<arch>/conf
sub-directory (assuming that you've installed the kernel sources), the
file named GENERIC being the one used to build your initial installation
kernel.  The file NOTES contains entries and documentation for all possible
devices, not just those commonly used.  It is the successor of the ancient
LINT file, but in contrast to LINT, it is not buildable as a kernel but a
pure reference and documentation file.


Source Roadmap:
---------------
bin		System/user commands.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html