c4da2324a3
on all inputs of the form x.75, where x is an even integer and log2(x) = 21. A similar problem occurred when rounding upward. The bug involves the following snippet copied from rint(): i>>=1; if((i0&i)!=0) i0 = (i0&(~i))|((0x100000)>>j0); The constant 0x100000 should be 0x200000. Apparently this case was never tested. It turns out that the bit manipulation is completely superfluous anyway, so remove it. (It tries to simulate 90% of the rounding process that the FPU does anyway.) Also, the special case of +-0 is handled twice (in different ways), so remove the second instance. Throw in some related simplifications from bde: - Work around a bug where gcc fails to clip to float precision by declaring two float variables as volatile. Previously, we tricked gcc into generating correct code by declaring some float constants as doubles. - Remove additional superfluous bit manipulation. - Minor reorganization. - Include <sys/types.h> explicitly. Note that some of the equivalent lines in rint() also appear to be unnecessary, but I'll defer to the numerical analysts who wrote it, since I can't test all 2^64 cases. Discussed with: bde |
||
|---|---|---|
| .. | ||
| compat | ||
| csu | ||
| libalias | ||
| libarchive | ||
| libatm | ||
| libbind | ||
| libbluetooth | ||
| libbsnmp | ||
| libbz2 | ||
| libc | ||
| libc_r | ||
| libcalendar | ||
| libcam | ||
| libcom_err | ||
| libcompat | ||
| libcrypt | ||
| libdevinfo | ||
| libdevstat | ||
| libdisk | ||
| libedit | ||
| libexpat | ||
| libfetch | ||
| libform | ||
| libftpio | ||
| libgeom | ||
| libio | ||
| libipsec | ||
| libipx | ||
| libisc | ||
| libkiconv | ||
| libkse | ||
| libkvm | ||
| libmd | ||
| libmenu | ||
| libmilter | ||
| libmp | ||
| libncp | ||
| libncurses | ||
| libnetgraph | ||
| libngatm | ||
| libopie | ||
| libpam | ||
| libpanel | ||
| libpcap | ||
| libpthread | ||
| libpthread_dbg | ||
| libradius | ||
| librpcsvc | ||
| libsbuf | ||
| libsdp | ||
| libsm | ||
| libsmb | ||
| libsmdb | ||
| libsmutil | ||
| libstand | ||
| libtacplus | ||
| libtelnet | ||
| libthr | ||
| libufs | ||
| libugidfw | ||
| libusbhid | ||
| libutil | ||
| libvgl | ||
| libwrap | ||
| libxpg4 | ||
| liby | ||
| libypclnt | ||
| libz | ||
| msun | ||
| ncurses | ||
| Makefile | ||
| Makefile.inc | ||