d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ccc5b4e6f4
freebsd-skq/usr.bin
History
Juli Mallett ccc5b4e6f4 Crank WARNS. 
Cast sizeof() to (int), as it's being compared against an int, not a size_t.
If i is changed to a size_t, it means the logic must be slightly changed later
in the flow, where --i is checked to be >= 0.  I am not sure I want to make a
logic change to account for clearing up a warning, when an aesthetic one will
keep from modifying the logic.

Other harmless casts, that I think I've made in the right directions.

Make gpbc() an inline function, rather than an obfuscated macro, make its
scratch space local, rather than global.  The previous macro used a dirty
hack (logical AND in place of a conditional) which would lead GCC to throw
a fit (rightly so) as the logical check, as well as the incrementation of
a variable, were not used for anything.

const'ify a few places where gcc3 yells. xstrdup() some global consts in
places where we xstrdup() when not using consts, but tried to assign them
to non-consts before.

Don't use execv(2) if we don't have the kind of arguments it wants.

Reviewed by:    asmodai obrien tjr
Submitted by:   tjr (a gcc3 build log)
2002-04-20 01:49:10 +00:00
..
apply Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
ar Add .Pp before enumerating options 2002-04-19 23:18:18 +00:00
at mdoc(7) police: markup fixes. 2002-03-15 15:26:57 +00:00
awk Style. 2002-04-10 03:10:03 +00:00
banner remove __P 2002-03-22 01:22:50 +00:00
basename Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
biff Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
brandelf Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
bzip2 Complete bzip2-1.0.2 import. 2002-02-01 16:33:40 +00:00
c89 Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
calendar Add myself. 2002-04-02 03:16:50 +00:00
cap_mkdb Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
chat remove __P 2002-03-22 01:22:50 +00:00
checknr Use `The .Nm utility'. Introduce options with well known sentence. 2002-04-19 23:23:28 +00:00
chflags remove __P 2002-03-22 01:22:50 +00:00
chkey Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
chpass Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
cksum remove __P 2002-03-22 01:22:50 +00:00
cmp remove __P 2002-03-22 01:22:50 +00:00
col Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
colcrt Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
colldef No longer needed to #ifdef __FBSDID, this is now handled by Makefile.inc1. 2002-04-09 11:39:05 +00:00
colrm Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
column remove __P 2002-03-22 01:22:50 +00:00
comm Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
compile_et
compress Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
ctags Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
cut Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
dig
dirname remove __P 2002-03-22 01:22:50 +00:00
dnskeygen
dnsquery
doscmd Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
du Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
ee Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
elf2aout Utility to create a.out [kernels] from an ELF one. 2002-03-28 02:17:27 +00:00
enigma Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
env remove __P 2002-03-22 01:22:50 +00:00
expand Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
false Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
fetch Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
file Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
file2c Modernize my email address 2002-03-25 13:53:46 +00:00
find Fix to WARNS=2 level. 2002-04-15 19:27:41 +00:00
finger Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
fmt Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
fold Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
from Introduce flags enumeration with standard 2002-03-26 12:15:31 +00:00
fstat .Ar filename ... is equivalent to .Ar. 2002-04-12 21:31:24 +00:00
fsync Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
ftp Connect lukemftp to the build as the default ftp client. Lukemftp 2001-12-13 23:46:44 +00:00
gcore Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
gencat Add FBSDID. Spelling. Remove unused includes. Check more malloc failures. 2002-03-26 12:39:08 +00:00
getconf mdoc(7) police: utilize the new .Ex macro. 2001-08-15 09:09:47 +00:00
getopt Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
gprof Include <stdint.h> for definition of intmax_t and/or uintmax_t. 2002-03-25 05:23:45 +00:00
head 1) Staticise. 2002-03-30 17:17:26 +00:00
hesinfo remove __P 2002-03-22 01:22:50 +00:00
hexdump Use `The .Nm utility' 2002-04-19 23:44:58 +00:00
host
id remove __P 2002-03-22 01:22:50 +00:00
indent 1) Const enough things to avoid warnings. 2002-03-30 17:10:20 +00:00
ipcrm remove __P 2002-03-22 01:22:50 +00:00
ipcs 1) Add missing prototypes for fmt_perm and cvt_time. 2002-03-30 16:46:04 +00:00
join Support -o 0 in join(1) as per SUS. 2002-03-26 03:44:04 +00:00
jot remove __P 2002-03-22 01:22:50 +00:00
kdump I now don't seem to be able to reproduce the -DNOCLEAN buildworld 2002-04-11 14:49:32 +00:00
kenv Add a reference to the kenv(2) manpage. 2002-04-18 18:49:41 +00:00
keylogin Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
keylogout
killall Skip zombies. Add an option (-z) to revert to the historical behaviour 2002-04-14 22:25:57 +00:00
ktrace 1) Clean up vendor and ID strings. 2002-04-01 10:49:11 +00:00
ktrdump Add a man page. 2002-04-02 04:26:37 +00:00
lam Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
last remove __P 2002-03-22 01:22:50 +00:00
lastcomm remove __P 2002-03-22 01:22:50 +00:00
ldd remove __P 2002-03-22 01:22:50 +00:00
leave remove __P 2002-03-22 01:22:50 +00:00
less Update for less v371 2002-01-07 20:37:33 +00:00
lessecho
lesskey
lex Back out rev. 1.6 (NOLIB bootstrap helper) OBE'd by Makefile.inc1,v 1.96. 2002-03-28 10:53:49 +00:00
limits Warns cleanups: 2002-04-13 21:28:17 +00:00
locate remove __P 2002-03-22 01:22:50 +00:00
lock remove __P 2002-03-22 01:22:50 +00:00
lockf Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
logger 1) Use FBSDID for vendor string. 2002-04-01 11:06:00 +00:00
login Remove unused #define. 2002-04-16 22:07:15 +00:00
logname remove __P 2002-03-22 01:22:50 +00:00
look remove __P 2002-03-22 01:22:50 +00:00
lorder
lsvfs Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
m4 Crank WARNS. 2002-04-20 01:49:10 +00:00
mail remove __P 2002-03-22 01:33:25 +00:00
make Move the sysV variable substitution up with the BSD feature that replaced it. 2002-04-19 04:08:35 +00:00
makewhatis
mesg remove __P 2002-03-22 01:33:25 +00:00
minigzip Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
mkdep Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
mkfifo remove __P 2002-03-22 01:33:25 +00:00
mklocale o Move NTOHL() and associated macros into <sys/param.h>. These are 2002-02-18 20:35:27 +00:00
mkstr Add FBSDID. Do not put spaces inside [] in usage string. Test memory allocation 2002-04-12 13:08:00 +00:00
mktemp remove __P 2002-03-22 01:33:25 +00:00
msgs Fixed some style bugs: 2002-04-18 13:02:17 +00:00
mt Make `make WARNS=3' succeed, notably, use %d to printf daddr_t value. 2002-04-12 13:16:04 +00:00
ncal Remove gcc specific compiler flags, at least one of which doesn't work with 2002-01-08 08:53:12 +00:00
ncplist
ncplogin Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
netstat Print IFT_ETHER addresses with ether_ntoa(3) (with leading zeros). 2002-04-06 10:02:20 +00:00
newkey remove __P 2002-03-22 01:33:25 +00:00
nfsstat remove __P 2002-03-22 01:33:25 +00:00
nice remove __P 2002-03-22 01:33:25 +00:00
nl remove __P 2002-03-22 01:33:25 +00:00
nm remove __P 2002-03-22 01:33:25 +00:00
nohup remove __P 2002-03-22 01:33:25 +00:00
objformat Remove leaf node WARNS?=2 (that mainly I added). This should 2002-02-08 22:31:43 +00:00
opieinfo Add opie lib dir to includes list 2002-01-03 21:20:29 +00:00
opiekey Add opie lib dir to includes list 2002-01-03 21:20:29 +00:00
opiepasswd Add opie lib dir to includes list 2002-01-03 21:20:29 +00:00
pagesize
passwd PAMified passwd(1). Some NIS-related issues remain to be solved, but this 2002-04-15 03:02:57 +00:00
paste remove __P 2002-03-22 01:33:25 +00:00
pr Add P1003.1-2001 -f and -p options. 2002-03-31 18:44:36 +00:00
printenv remove __P 2002-03-22 01:33:25 +00:00
printf remove __P 2002-03-22 01:33:25 +00:00
quota remove __P 2002-03-22 01:33:25 +00:00
ranlib remove __P 2002-03-22 01:33:25 +00:00
renice o Fix an arguments number check in -n case. 2002-04-10 13:38:09 +00:00
rev remove __P 2002-03-22 01:33:25 +00:00
rlogin Replaced exists() tests with two equivalent defined(). 2002-04-18 07:01:35 +00:00
rpcgen remove __P 2002-03-22 01:33:25 +00:00
rpcinfo The clnt_create(KEYSERVSOCK, CRYPT_PROG, CRYPT_VERS, "unix") hacks 2002-02-05 19:26:04 +00:00
rs remove __P 2002-03-22 01:33:25 +00:00
rsh Replaced exists() tests with two equivalent defined(). 2002-04-18 07:01:35 +00:00
rup If the remote uptime is less than one minute, print the uptime in 2001-10-17 01:44:34 +00:00
ruptime remove __P 2002-03-22 01:33:25 +00:00
rusers I've been meaning to do this for a while. Add an underscore to the 2002-01-19 23:20:02 +00:00
rwall Revert/fix the most controversial parts of the last commit: 2002-03-07 14:11:41 +00:00
rwho remove __P 2002-03-22 01:33:25 +00:00
sasc remove __P 2002-03-22 01:42:45 +00:00
script remove __P 2002-03-22 01:42:45 +00:00
sed Fix an ages-old bug in sed(1), which resulted in the absolutely valid 2002-04-12 19:46:05 +00:00
shar
showmount remove __P 2002-03-22 01:42:45 +00:00
size remove __P 2002-03-22 01:42:45 +00:00
smbutil Add bmake glue for src/contrib/smbfs and connect userland smbfs 2001-12-14 11:41:22 +00:00
sockstat Drop maintainership of this, it serves no purpose. 2002-04-15 19:36:50 +00:00
soelim remove __P 2002-03-22 01:42:45 +00:00
split remove __P 2002-03-22 01:42:45 +00:00
strings remove __P 2002-03-22 01:42:45 +00:00
strip remove __P 2002-03-22 01:42:45 +00:00
su Fix a few typos. 2002-03-30 11:47:18 +00:00
symorder remove __P 2002-03-22 01:42:45 +00:00
systat Remove previously unneeded and now incorrect cast of user_from_uid() 2002-04-13 21:09:55 +00:00
tail Fix up vendor IDs. 2002-04-13 20:59:48 +00:00
talk remove __P 2002-03-22 01:42:45 +00:00
tconv Remove WARNS?=2 and -Wall. WARNS?=2 is going to be the default. 2001-12-12 00:06:52 +00:00
tcopy Include <stdint.h> for definition of intmax_t and/or uintmax_t. 2002-03-25 05:23:45 +00:00
tee remove __P 2002-03-22 01:42:45 +00:00
telnet Remove WARNS?=2 and -Wall. WARNS?=2 is going to be the default. 2001-12-12 00:06:52 +00:00
tftp Add some constness to make this WARNS clean again. 2002-04-13 18:38:16 +00:00
time remove __P 2002-03-22 01:42:45 +00:00
tip Don't attempt to chflags(1) non-existent executable. 2002-04-17 12:15:02 +00:00
top remove __P 2002-03-22 01:42:45 +00:00
touch remove __P 2002-03-22 01:42:45 +00:00
tput remove __P 2002-03-22 01:42:45 +00:00
tr remove __P 2002-03-22 01:42:45 +00:00
true Remove WARNS?=2 and -Wall. WARNS?=2 is going to be the default. 2001-12-12 00:06:52 +00:00
truncate remove __P 2002-03-22 01:42:45 +00:00
truss I now don't seem to be able to reproduce the -DNOCLEAN buildworld 2002-04-11 14:49:32 +00:00
tset remove __P 2002-03-22 01:42:45 +00:00
tsort remove __P 2002-03-22 01:42:45 +00:00
tty remove __P 2002-03-22 01:42:45 +00:00
uac Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
ul remove __P 2002-03-22 01:42:45 +00:00
uname remove __P 2002-03-22 01:42:45 +00:00
unexpand remove __P 2002-03-22 01:42:45 +00:00
unifdef remove __P 2002-03-22 01:42:45 +00:00
uniq Use LC_ALL to pick collate 2002-04-19 08:16:01 +00:00
units Add tbl and tbsp as contractions of tablespoon, and tsp for teaspoon. 2001-12-18 11:25:58 +00:00
unvis remove __P 2002-03-22 01:42:45 +00:00
usbhidctl Style nits. 2002-04-15 09:33:34 +00:00
users remove __P 2002-03-22 01:42:45 +00:00
uudecode Bump WARNS to 4. 2002-04-20 00:20:54 +00:00
uuencode Bump WARNS to 4. 2002-04-20 00:20:54 +00:00
vacation Update build infrastructure for sendmail 8.12. 2002-02-17 22:05:07 +00:00
vgrind remove __P 2002-03-22 01:42:45 +00:00
vi remove __P 2002-03-22 01:42:45 +00:00
vis remove __P 2002-03-22 01:42:45 +00:00
vmstat Remove malloc_type's ks_limit. 2002-04-15 04:05:53 +00:00
w remove __P 2002-03-22 01:42:45 +00:00
wall WARNS=2 fix, use __FBSDID(). 2001-12-11 22:22:15 +00:00
wc remove __P 2002-03-22 01:42:45 +00:00
what remove __P 2002-03-22 01:42:45 +00:00
whereis
which Off by one error in checking max file name length. 2002-03-09 15:30:42 +00:00
who remove __P 2002-03-22 01:42:45 +00:00
whois Leave the `copyright' variable exposed, since the main purpose of it 2002-03-07 10:06:00 +00:00
window Remove NO_WERRORs and WARNS=n's. To be revisited after GCC3. 2002-02-08 23:07:37 +00:00
write remove __P 2002-03-22 01:42:45 +00:00
xargs In the case where we can't open /dev/tty, fall back to -t behaviour. 2002-04-19 23:58:00 +00:00
xinstall No longer needed to #ifdef __FBSDID, this is now handled by Makefile.inc1. 2002-04-09 11:39:05 +00:00
xlint Don't unnecessarily include bsd.own.mk. 2002-04-15 09:37:12 +00:00
xstr remove __P 2002-03-22 01:42:45 +00:00
yacc mdoc police: use .El to end the list in the ENVIRONMENT section. 2002-04-17 21:34:47 +00:00
yes Remove WARNS=2 as this is to become default. 2001-12-11 22:56:05 +00:00
ypcat Remove NO_WERRORs and WARNS=n's. To be revisited after GCC3. 2002-02-08 23:07:37 +00:00
ypmatch Remove NO_WERRORs and WARNS=n's. To be revisited after GCC3. 2002-02-08 23:07:37 +00:00
ypwhich 1) Remove blank line between include of sys/cdefs.h and __FBSDID 2002-02-27 14:32:43 +00:00
Makefile Revert last change, to be revisited later. 2002-04-12 16:50:52 +00:00
Makefile.inc Backout -Werror protection. No need to walk all over the upcoming 2002-02-06 18:13:12 +00:00