631df11d04
This change takes capsicum-test from upstream and applies some local changes to make the tests work on FreeBSD when executed via Kyua. The local modifications are as follows: 1. Make `OpenatTest.WithFlag` pass with the new dot-dot lookup behavior in FreeBSD 12.x+. 2. capsicum-test references a set of helper binaries: `mini-me`, `mini-me.noexec`, and `mini-me.setuid`, as part of the execve/fexecve tests, via execve, fexecve, and open. It achieves this upstream by assuming `mini-me*` is in the current directory, however, in order for Kyua to execute `capsicum-test`, it needs to provide a full path to `mini-me*`. In order to achieve this, I made `capsicum-test` cache the executable's path from argv[0] in main(..) and use the cached value to compute the path to `mini-me*` as part of the execve/fexecve testcases. 3. The capsicum-test test suite assumes that it's always being run on CAPABILITIES enabled kernels. However, there's a chance that the test will be run on a host without a CAPABILITIES enabled kernel, so we must check for the support before running the tests. The way to achieve this is to add the relevant `feature_present("security_capabilities")` check to SetupEnvironment::SetUp() and skip the tests when the support is not available. While here, add a check for `kern.trap_enotcap` being enabled. As noted by markj@ in https://github.com/google/capsicum-test/issues/23, this sysctl being enabled can trigger non-deterministic failures. Therefore, the tests should be skipped if this sysctl is enabled. All local changes have been submitted to the capsicum-test project (https://github.com/google/capsicum-test) and are in various stages of review. Please see the following pull requests for more details: 1. https://github.com/google/capsicum-test/pull/35 2. https://github.com/google/capsicum-test/pull/41 3. https://github.com/google/capsicum-test/pull/42 Reviewed by: asomers Discussed with: emaste, markj Approved by: emaste (mentor) MFC after: 2 months Differential Revision: https://reviews.freebsd.org/D19758
157 lines
4.2 KiB
C++
157 lines
4.2 KiB
C++
#include <sys/types.h>
|
|
#ifdef __linux__
|
|
#include <sys/vfs.h>
|
|
#include <linux/magic.h>
|
|
#elif defined(__FreeBSD__)
|
|
#include <sys/sysctl.h>
|
|
#endif
|
|
#include <ctype.h>
|
|
#include <errno.h>
|
|
#include <libgen.h>
|
|
#include <pwd.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <iostream>
|
|
#include "gtest/gtest.h"
|
|
#include "capsicum-test.h"
|
|
|
|
// For versions of googletest that lack GTEST_SKIP.
|
|
#ifndef GTEST_SKIP
|
|
#define GTEST_SKIP GTEST_FAIL
|
|
#endif
|
|
|
|
std::string tmpdir;
|
|
|
|
class SetupEnvironment : public ::testing::Environment
|
|
{
|
|
public:
|
|
SetupEnvironment() : teardown_tmpdir_(false) {}
|
|
void SetUp() override {
|
|
CheckCapsicumSupport();
|
|
if (tmpdir.empty()) {
|
|
std::cerr << "Generating temporary directory root: ";
|
|
CreateTemporaryRoot();
|
|
} else {
|
|
std::cerr << "User provided temporary directory root: ";
|
|
}
|
|
std::cerr << tmpdir << std::endl;
|
|
}
|
|
void CheckCapsicumSupport() {
|
|
#ifdef __FreeBSD__
|
|
int rc;
|
|
bool trap_enotcap_enabled;
|
|
size_t trap_enotcap_enabled_len = sizeof(trap_enotcap_enabled);
|
|
|
|
if (feature_present("security_capabilities") == 0) {
|
|
GTEST_SKIP() << "Skipping tests because capsicum support is not "
|
|
<< "enabled in the kernel.";
|
|
}
|
|
// If this OID is enabled, it will send SIGTRAP to the process when
|
|
// `ENOTCAPABLE` is returned.
|
|
const char *oid = "kern.trap_enotcap";
|
|
rc = sysctlbyname(oid, &trap_enotcap_enabled, &trap_enotcap_enabled_len,
|
|
nullptr, 0);
|
|
if (rc != 0) {
|
|
GTEST_FAIL() << "sysctlbyname failed: " << strerror(errno);
|
|
}
|
|
if (trap_enotcap_enabled) {
|
|
GTEST_SKIP() << "Debug sysctl, " << oid << ", enabled. "
|
|
<< "Skipping tests because its enablement invalidates the "
|
|
<< "test results.";
|
|
}
|
|
#endif /* FreeBSD */
|
|
}
|
|
void CreateTemporaryRoot() {
|
|
char *tmpdir_name = tempnam(nullptr, "cptst");
|
|
|
|
ASSERT_NE(tmpdir_name, nullptr);
|
|
ASSERT_EQ(mkdir(tmpdir_name, 0700), 0) <<
|
|
"Could not create temp directory, " << tmpdir_name << ": " <<
|
|
strerror(errno);
|
|
tmpdir = std::string(tmpdir_name);
|
|
free(tmpdir_name);
|
|
teardown_tmpdir_ = true;
|
|
}
|
|
void TearDown() override {
|
|
if (teardown_tmpdir_) {
|
|
rmdir(tmpdir.c_str());
|
|
}
|
|
}
|
|
private:
|
|
bool teardown_tmpdir_;
|
|
};
|
|
|
|
std::string capsicum_test_bindir;
|
|
|
|
int main(int argc, char* argv[]) {
|
|
// Set up the test program path, so capsicum-test can find programs, like
|
|
// mini-me* when executed from an absolute path.
|
|
{
|
|
char *new_path, *old_path, *program_name;
|
|
|
|
program_name = strdup(argv[0]);
|
|
assert(program_name);
|
|
capsicum_test_bindir = std::string(dirname(program_name));
|
|
free(program_name);
|
|
|
|
old_path = getenv("PATH");
|
|
assert(old_path);
|
|
|
|
assert(asprintf(&new_path, "%s:%s", capsicum_test_bindir.c_str(),
|
|
old_path) > 0);
|
|
assert(setenv("PATH", new_path, 1) == 0);
|
|
}
|
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
for (int ii = 1; ii < argc; ii++) {
|
|
if (strcmp(argv[ii], "-v") == 0) {
|
|
verbose = true;
|
|
} else if (strcmp(argv[ii], "-T") == 0) {
|
|
ii++;
|
|
assert(ii < argc);
|
|
tmpdir = argv[ii];
|
|
struct stat info;
|
|
stat(tmpdir.c_str(), &info);
|
|
assert(S_ISDIR(info.st_mode));
|
|
} else if (strcmp(argv[ii], "-t") == 0) {
|
|
force_mt = true;
|
|
} else if (strcmp(argv[ii], "-F") == 0) {
|
|
force_nofork = true;
|
|
} else if (strcmp(argv[ii], "-u") == 0) {
|
|
if (++ii >= argc) {
|
|
std::cerr << "-u needs argument" << std::endl;
|
|
exit(1);
|
|
}
|
|
if (isdigit(argv[ii][0])) {
|
|
other_uid = atoi(argv[ii]);
|
|
} else {
|
|
struct passwd *p = getpwnam(argv[ii]);
|
|
if (!p) {
|
|
std::cerr << "Failed to get entry for " << argv[ii] << ", errno=" << errno << std::endl;
|
|
exit(1);
|
|
}
|
|
other_uid = p->pw_uid;
|
|
}
|
|
}
|
|
}
|
|
if (other_uid == 0) {
|
|
struct stat info;
|
|
if (stat(argv[0], &info) == 0) {
|
|
other_uid = info.st_uid;
|
|
}
|
|
}
|
|
|
|
#ifdef __linux__
|
|
// Check whether our temporary directory is on a tmpfs volume.
|
|
struct statfs fsinfo;
|
|
statfs(tmpdir.c_str(), &fsinfo);
|
|
tmpdir_on_tmpfs = (fsinfo.f_type == TMPFS_MAGIC);
|
|
#endif
|
|
|
|
testing::AddGlobalTestEnvironment(new SetupEnvironment());
|
|
int rc = RUN_ALL_TESTS();
|
|
ShowSkippedTests(std::cerr);
|
|
return rc;
|
|
}
|