2018-01-29 13:11:29 +00:00
|
|
|
/* SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
* Copyright(c) 2010-2014 Intel Corporation.
|
|
|
|
* Copyright(c) 2014 6WIND S.A.
|
2012-09-04 12:54:00 +00:00
|
|
|
*/
|
2018-01-29 13:11:29 +00:00
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
#include <stdio.h>
|
|
|
|
|
|
|
|
#include "test.h"
|
|
|
|
|
|
|
|
#include <string.h>
|
|
|
|
#include <stdarg.h>
|
2012-12-19 23:00:00 +00:00
|
|
|
#include <libgen.h>
|
2012-09-04 12:54:00 +00:00
|
|
|
#include <stdlib.h>
|
|
|
|
#include <errno.h>
|
|
|
|
#include <unistd.h>
|
2012-12-19 23:00:00 +00:00
|
|
|
#include <dirent.h>
|
2012-09-04 12:54:00 +00:00
|
|
|
#include <sys/wait.h>
|
2012-12-19 23:00:00 +00:00
|
|
|
#include <sys/file.h>
|
2014-02-10 11:49:10 +00:00
|
|
|
#include <limits.h>
|
2019-03-13 17:06:50 +00:00
|
|
|
#include <fcntl.h>
|
2012-09-04 12:54:00 +00:00
|
|
|
|
2019-06-15 06:42:27 +00:00
|
|
|
#include <rte_lcore.h>
|
2012-09-04 12:54:00 +00:00
|
|
|
#include <rte_debug.h>
|
|
|
|
#include <rte_string_fns.h>
|
|
|
|
|
|
|
|
#include "process.h"
|
|
|
|
|
2014-12-09 10:11:12 +00:00
|
|
|
#define DEFAULT_MEM_SIZE "18"
|
2012-09-04 12:54:00 +00:00
|
|
|
#define mp_flag "--proc-type=secondary"
|
|
|
|
#define no_hpet "--no-hpet"
|
|
|
|
#define no_huge "--no-huge"
|
|
|
|
#define no_shconf "--no-shconf"
|
2014-03-01 12:14:45 +00:00
|
|
|
#define pci_whitelist "--pci-whitelist"
|
|
|
|
#define vdev "--vdev"
|
2012-12-19 23:00:00 +00:00
|
|
|
#define memtest "memtest"
|
|
|
|
#define memtest1 "memtest1"
|
|
|
|
#define memtest2 "memtest2"
|
2018-02-06 02:21:38 +00:00
|
|
|
#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20)
|
2012-09-04 12:54:00 +00:00
|
|
|
#define launch_proc(ARGV) process_dup(ARGV, \
|
|
|
|
sizeof(ARGV)/(sizeof(ARGV[0])), __func__)
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
enum hugepage_action {
|
|
|
|
HUGEPAGE_CHECK_EXISTS = 0,
|
|
|
|
HUGEPAGE_CHECK_LOCKED,
|
|
|
|
HUGEPAGE_DELETE,
|
|
|
|
HUGEPAGE_INVALID
|
|
|
|
};
|
|
|
|
|
|
|
|
/* if string contains a hugepage path */
|
|
|
|
static int
|
|
|
|
get_hugepage_path(char * src, int src_len, char * dst, int dst_len)
|
|
|
|
{
|
|
|
|
#define NUM_TOKENS 4
|
|
|
|
char *tokens[NUM_TOKENS];
|
|
|
|
|
|
|
|
/* if we couldn't properly split the string */
|
|
|
|
if (rte_strsplit(src, src_len, tokens, NUM_TOKENS, ' ') < NUM_TOKENS)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (strncmp(tokens[2], "hugetlbfs", sizeof("hugetlbfs")) == 0) {
|
2019-04-03 14:45:04 +00:00
|
|
|
strlcpy(dst, tokens[1], dst_len);
|
2012-12-19 23:00:00 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Cycles through hugepage directories and looks for hugepage
|
|
|
|
* files associated with a given prefix. Depending on value of
|
|
|
|
* action, the hugepages are checked if they exist, checked if
|
|
|
|
* they can be locked, or are simply deleted.
|
|
|
|
*
|
|
|
|
* Returns 1 if it finds at least one hugepage matching the action
|
|
|
|
* Returns 0 if no matching hugepages were found
|
|
|
|
* Returns -1 if it encounters an error
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
process_hugefiles(const char * prefix, enum hugepage_action action)
|
|
|
|
{
|
|
|
|
FILE * hugedir_handle = NULL;
|
|
|
|
DIR * hugepage_dir = NULL;
|
|
|
|
struct dirent *dirent = NULL;
|
|
|
|
|
|
|
|
char hugefile_prefix[PATH_MAX] = {0};
|
|
|
|
char hugedir[PATH_MAX] = {0};
|
|
|
|
char line[PATH_MAX] = {0};
|
|
|
|
|
|
|
|
int fd, lck_result, result = 0;
|
|
|
|
|
2014-06-24 18:15:28 +00:00
|
|
|
const int prefix_len = snprintf(hugefile_prefix,
|
2012-12-19 23:00:00 +00:00
|
|
|
sizeof(hugefile_prefix), "%smap_", prefix);
|
2013-03-12 11:03:00 +00:00
|
|
|
if (prefix_len <= 0 || prefix_len >= (int)sizeof(hugefile_prefix)
|
|
|
|
|| prefix_len >= (int)sizeof(dirent->d_name)) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error creating hugefile filename prefix\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* get hugetlbfs mountpoints from /proc/mounts */
|
|
|
|
hugedir_handle = fopen("/proc/mounts", "r");
|
|
|
|
|
|
|
|
if (hugedir_handle == NULL) {
|
|
|
|
printf("Error parsing /proc/mounts!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* read and parse script output */
|
|
|
|
while (fgets(line, sizeof(line), hugedir_handle) != NULL) {
|
|
|
|
|
|
|
|
/* check if we have a hugepage filesystem path */
|
|
|
|
if (!get_hugepage_path(line, sizeof(line), hugedir, sizeof(hugedir)))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/* check if directory exists */
|
|
|
|
if ((hugepage_dir = opendir(hugedir)) == NULL) {
|
|
|
|
fclose(hugedir_handle);
|
|
|
|
printf("Error reading %s: %s\n", hugedir, strerror(errno));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
while ((dirent = readdir(hugepage_dir)) != NULL) {
|
|
|
|
if (memcmp(dirent->d_name, hugefile_prefix, prefix_len) != 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
switch (action) {
|
|
|
|
case HUGEPAGE_CHECK_EXISTS:
|
|
|
|
{
|
|
|
|
/* file exists, return */
|
|
|
|
result = 1;
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case HUGEPAGE_DELETE:
|
|
|
|
{
|
|
|
|
char file_path[PATH_MAX] = {0};
|
|
|
|
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(file_path, sizeof(file_path),
|
2012-12-19 23:00:00 +00:00
|
|
|
"%s/%s", hugedir, dirent->d_name);
|
2014-06-03 23:42:50 +00:00
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
/* remove file */
|
|
|
|
if (remove(file_path) < 0) {
|
|
|
|
printf("Error deleting %s - %s!\n",
|
|
|
|
dirent->d_name, strerror(errno));
|
|
|
|
closedir(hugepage_dir);
|
|
|
|
result = -1;
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
result = 1;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case HUGEPAGE_CHECK_LOCKED:
|
|
|
|
{
|
|
|
|
/* try and lock the file */
|
|
|
|
fd = openat(dirfd(hugepage_dir), dirent->d_name, O_RDONLY);
|
|
|
|
|
|
|
|
/* this shouldn't happen */
|
|
|
|
if (fd == -1) {
|
|
|
|
printf("Error opening %s - %s!\n",
|
|
|
|
dirent->d_name, strerror(errno));
|
|
|
|
closedir(hugepage_dir);
|
|
|
|
result = -1;
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* non-blocking lock */
|
|
|
|
lck_result = flock(fd, LOCK_EX | LOCK_NB);
|
|
|
|
|
|
|
|
/* if lock succeeds, there's something wrong */
|
|
|
|
if (lck_result != -1) {
|
|
|
|
result = 0;
|
|
|
|
|
|
|
|
/* unlock the resulting lock */
|
|
|
|
flock(fd, LOCK_UN);
|
|
|
|
close(fd);
|
|
|
|
closedir(hugepage_dir);
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
result = 1;
|
|
|
|
close(fd);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
/* shouldn't happen */
|
|
|
|
default:
|
|
|
|
goto end;
|
|
|
|
} /* switch */
|
|
|
|
|
|
|
|
} /* read hugepage directory */
|
|
|
|
closedir(hugepage_dir);
|
|
|
|
} /* read /proc/mounts */
|
|
|
|
end:
|
|
|
|
fclose(hugedir_handle);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2019-03-06 16:22:39 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_LINUX
|
2012-12-19 23:00:00 +00:00
|
|
|
/*
|
|
|
|
* count the number of "node*" files in /sys/devices/system/node/
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
get_number_of_sockets(void)
|
|
|
|
{
|
|
|
|
struct dirent *dirent = NULL;
|
|
|
|
const char * nodedir = "/sys/devices/system/node/";
|
|
|
|
DIR * dir = NULL;
|
|
|
|
int result = 0;
|
|
|
|
|
|
|
|
/* check if directory exists */
|
|
|
|
if ((dir = opendir(nodedir)) == NULL) {
|
2013-03-12 11:03:00 +00:00
|
|
|
/* if errno==ENOENT this means we don't have NUMA support */
|
|
|
|
if (errno == ENOENT) {
|
|
|
|
printf("No NUMA nodes detected: assuming 1 available socket\n");
|
|
|
|
return 1;
|
|
|
|
}
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error opening %s: %s\n", nodedir, strerror(errno));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
while ((dirent = readdir(dir)) != NULL)
|
|
|
|
if (strncmp(dirent->d_name, "node", sizeof("node") - 1) == 0)
|
|
|
|
result++;
|
|
|
|
|
|
|
|
closedir(dir);
|
|
|
|
return result;
|
|
|
|
}
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2013-09-18 10:00:00 +00:00
|
|
|
/*
|
|
|
|
* Test that the app doesn't run with invalid whitelist option.
|
|
|
|
* Final tests ensures it does run with valid options as sanity check (one
|
|
|
|
* test for with Domain+BDF, second for just with BDF)
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_whitelist_flag(void)
|
|
|
|
{
|
|
|
|
unsigned i;
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2013-09-18 10:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2013-09-18 10:00:00 +00:00
|
|
|
|
|
|
|
const char *wlinval[][11] = {
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "error", "", ""},
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "0:0:0", "", ""},
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "0:error:0.1", "", ""},
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "0:0:0.1error", "", ""},
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "error0:0:0.1", "", ""},
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "0:0:0.1.2", "", ""},
|
2013-09-18 10:00:00 +00:00
|
|
|
};
|
|
|
|
/* Test with valid whitelist option */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *wlval1[] = {prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "00FF:09:0B.3"};
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *wlval2[] = {prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "09:0B.3", pci_whitelist, "0a:0b.1"};
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *wlval3[] = {prgname, prefix, mp_flag,
|
2014-03-01 12:14:45 +00:00
|
|
|
pci_whitelist, "09:0B.3,type=test",
|
|
|
|
pci_whitelist, "08:00.1,type=normal",
|
|
|
|
};
|
2013-09-18 10:00:00 +00:00
|
|
|
|
|
|
|
for (i = 0; i < sizeof(wlinval) / sizeof(wlinval[0]); i++) {
|
|
|
|
if (launch_proc(wlinval[i]) == 0) {
|
|
|
|
printf("Error - process did run ok with invalid "
|
|
|
|
"whitelist parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (launch_proc(wlval1) != 0 ) {
|
|
|
|
printf("Error - process did not run ok with valid whitelist\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(wlval2) != 0 ) {
|
|
|
|
printf("Error - process did not run ok with valid whitelist value set\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(wlval3) != 0 ) {
|
|
|
|
printf("Error - process did not run ok with valid whitelist + args\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/*
|
2013-09-18 10:00:00 +00:00
|
|
|
* Test that the app doesn't run with invalid blacklist option.
|
2012-09-04 12:54:00 +00:00
|
|
|
* Final test ensures it does run with valid options as sanity check
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_invalid_b_flag(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
const char *blinval[][9] = {
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag, "-b", "error"},
|
|
|
|
{prgname, prefix, mp_flag, "-b", "0:0:0"},
|
|
|
|
{prgname, prefix, mp_flag, "-b", "0:error:0.1"},
|
|
|
|
{prgname, prefix, mp_flag, "-b", "0:0:0.1error"},
|
|
|
|
{prgname, prefix, mp_flag, "-b", "error0:0:0.1"},
|
|
|
|
{prgname, prefix, mp_flag, "-b", "0:0:0.1.2"},
|
2012-09-04 12:54:00 +00:00
|
|
|
};
|
|
|
|
/* Test with valid blacklist option */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *blval[] = {prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-b", "FF:09:0B.3"};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i != sizeof (blinval) / sizeof (blinval[0]); i++) {
|
|
|
|
if (launch_proc(blinval[i]) == 0) {
|
|
|
|
printf("Error - process did run ok with invalid "
|
|
|
|
"blacklist parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (launch_proc(blval) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid blacklist value\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-07-01 16:13:57 +00:00
|
|
|
/*
|
|
|
|
* Test that the app doesn't run with invalid vdev option.
|
|
|
|
* Final test ensures it does run with valid options as sanity check
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_invalid_vdev_flag(void)
|
|
|
|
{
|
2019-06-15 06:42:28 +00:00
|
|
|
#ifdef RTE_LIBRTE_PMD_RING
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-11-15 20:34:09 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point, and we also need to
|
|
|
|
* run another primary process here */
|
|
|
|
const char * prefix = no_shconf;
|
|
|
|
#else
|
|
|
|
const char * prefix = "--file-prefix=vdev";
|
|
|
|
#endif
|
|
|
|
|
2014-07-01 16:13:57 +00:00
|
|
|
/* Test with invalid vdev option */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *vdevinval[] = {prgname, prefix, no_huge,
|
2019-06-15 06:42:26 +00:00
|
|
|
vdev, "eth_dummy"};
|
2014-07-01 16:13:57 +00:00
|
|
|
|
|
|
|
/* Test with valid vdev option */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *vdevval1[] = {prgname, prefix, no_huge,
|
2019-06-15 06:42:26 +00:00
|
|
|
vdev, "net_ring0"};
|
2014-07-01 16:13:57 +00:00
|
|
|
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *vdevval2[] = {prgname, prefix, no_huge,
|
2019-06-15 06:42:26 +00:00
|
|
|
vdev, "net_ring0,args=test"};
|
2014-07-01 16:13:57 +00:00
|
|
|
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *vdevval3[] = {prgname, prefix, no_huge,
|
2019-06-15 06:42:26 +00:00
|
|
|
vdev, "net_ring0,nodeaction=r1:0:CREATE"};
|
2014-07-01 16:13:57 +00:00
|
|
|
|
|
|
|
if (launch_proc(vdevinval) == 0) {
|
|
|
|
printf("Error - process did run ok with invalid "
|
|
|
|
"vdev parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(vdevval1) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid vdev value\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(vdevval2) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid vdev value,"
|
|
|
|
"with dummy args\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(vdevval3) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid vdev value,"
|
|
|
|
"with valid args\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
2019-06-15 06:42:28 +00:00
|
|
|
#else
|
|
|
|
return TEST_SKIPPED;
|
2014-07-01 16:13:57 +00:00
|
|
|
#endif
|
2019-06-15 06:42:28 +00:00
|
|
|
}
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Test that the app doesn't run with invalid -r option.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_invalid_r_flag(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
const char *rinval[][9] = {
|
2019-06-15 06:42:26 +00:00
|
|
|
{prgname, prefix, mp_flag, "-r", "error"},
|
|
|
|
{prgname, prefix, mp_flag, "-r", "0"},
|
|
|
|
{prgname, prefix, mp_flag, "-r", "-1"},
|
|
|
|
{prgname, prefix, mp_flag, "-r", "17"},
|
2012-09-04 12:54:00 +00:00
|
|
|
};
|
|
|
|
/* Test with valid blacklist option */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *rval[] = {prgname, prefix, mp_flag, "-r", "16"};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i != sizeof (rinval) / sizeof (rinval[0]); i++) {
|
|
|
|
if (launch_proc(rinval[i]) == 0) {
|
|
|
|
printf("Error - process did run ok with invalid "
|
|
|
|
"-r (rank) parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (launch_proc(rval) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid -r (rank) value\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2014-06-27 14:09:32 +00:00
|
|
|
* Test that the app doesn't run without the coremask/corelist flags. In all cases
|
2012-09-04 12:54:00 +00:00
|
|
|
* should give an error and fail to run
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_missing_c_flag(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/* -c flag but no coremask value */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv1[] = { prgname, prefix, mp_flag, "-c"};
|
2015-02-15 05:47:31 +00:00
|
|
|
/* No -c, -l or --lcores flag at all */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv2[] = { prgname, prefix, mp_flag};
|
2012-09-04 12:54:00 +00:00
|
|
|
/* bad coremask value */
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv3[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-c", "error" };
|
2012-09-04 12:54:00 +00:00
|
|
|
/* sanity check of tests - valid coremask value */
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv4[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-c", "1" };
|
2014-06-27 14:09:32 +00:00
|
|
|
/* -l flag but no corelist value */
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv5[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l"};
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv6[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", " " };
|
2014-06-27 14:09:32 +00:00
|
|
|
/* bad corelist values */
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv7[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "error" };
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv8[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "1-" };
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv9[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "1," };
|
2015-02-15 05:47:31 +00:00
|
|
|
const char *argv10[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "1#2" };
|
2019-01-17 12:13:12 +00:00
|
|
|
/* core number is negative value */
|
|
|
|
const char * const argv11[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "-5" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv12[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "-5-7" };
|
2019-01-17 12:13:12 +00:00
|
|
|
/* core number is maximum value */
|
|
|
|
const char * const argv13[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", RTE_STR(RTE_MAX_LCORE) };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv14[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "1-"RTE_STR(RTE_MAX_LCORE) };
|
2014-06-27 14:09:32 +00:00
|
|
|
/* sanity check test - valid corelist value */
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv15[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-l", "1-2,3" };
|
2015-02-15 05:47:31 +00:00
|
|
|
|
|
|
|
/* --lcores flag but no lcores value */
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv16[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv17[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", " " };
|
2015-02-15 05:47:31 +00:00
|
|
|
/* bad lcores value */
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv18[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "1-3-5" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv19[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "0-1,,2" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv20[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "0-,1" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv21[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "(0-,2-4)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv22[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "(-1,2)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv23[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "(2-4)@(2-4-6)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv24[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "(a,2)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv25[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "1-3@(1,3)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv26[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "3@((1,3)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv27[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "(4-7)=(1,3)" };
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv28[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores", "[4-7]@(1,3)" };
|
2015-02-15 05:47:31 +00:00
|
|
|
/* sanity check of tests - valid lcores value */
|
2019-01-17 12:13:12 +00:00
|
|
|
const char * const argv29[] = { prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"--lcores",
|
2015-02-15 05:47:31 +00:00
|
|
|
"0-1,2@(5-7),(3-5)@(0,2),(0,6),7"};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
2015-09-25 20:37:16 +00:00
|
|
|
if (launch_proc(argv2) != 0) {
|
|
|
|
printf("Error - "
|
|
|
|
"process did not run ok when missing -c flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
if (launch_proc(argv1) == 0
|
|
|
|
|| launch_proc(argv3) == 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
2015-09-25 20:37:16 +00:00
|
|
|
"process ran without error with invalid -c flag\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv4) != 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
|
|
|
"process did not run ok with valid coremask value\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2014-06-27 14:09:32 +00:00
|
|
|
|
2015-02-15 05:47:31 +00:00
|
|
|
/* start -l test */
|
2014-06-27 14:09:32 +00:00
|
|
|
if (launch_proc(argv5) == 0
|
|
|
|
|| launch_proc(argv6) == 0
|
|
|
|
|| launch_proc(argv7) == 0
|
|
|
|
|| launch_proc(argv8) == 0
|
|
|
|
|| launch_proc(argv9) == 0
|
2019-01-17 12:13:12 +00:00
|
|
|
|| launch_proc(argv10) == 0
|
|
|
|
|| launch_proc(argv11) == 0
|
|
|
|
|| launch_proc(argv12) == 0
|
|
|
|
|| launch_proc(argv13) == 0
|
|
|
|
|| launch_proc(argv14) == 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
|
|
|
"process ran without error with invalid -l flag\n");
|
2014-06-27 14:09:32 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2019-06-15 06:42:27 +00:00
|
|
|
if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&
|
|
|
|
rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&
|
|
|
|
launch_proc(argv15) != 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
|
|
|
"process did not run ok with valid corelist value\n");
|
2014-06-27 14:09:32 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2015-02-15 05:47:31 +00:00
|
|
|
|
|
|
|
/* start --lcores tests */
|
2019-01-17 12:13:12 +00:00
|
|
|
if (launch_proc(argv16) == 0 || launch_proc(argv17) == 0 ||
|
2015-02-15 05:47:31 +00:00
|
|
|
launch_proc(argv18) == 0 || launch_proc(argv19) == 0 ||
|
|
|
|
launch_proc(argv20) == 0 || launch_proc(argv21) == 0 ||
|
2019-01-17 12:13:12 +00:00
|
|
|
launch_proc(argv22) == 0 || launch_proc(argv23) == 0 ||
|
|
|
|
launch_proc(argv24) == 0 || launch_proc(argv25) == 0 ||
|
|
|
|
launch_proc(argv26) == 0 || launch_proc(argv27) == 0 ||
|
|
|
|
launch_proc(argv28) == 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
|
|
|
"process ran without error with invalid --lcore flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2019-06-15 06:42:27 +00:00
|
|
|
if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&
|
|
|
|
rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&
|
|
|
|
rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) &&
|
|
|
|
rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) &&
|
|
|
|
launch_proc(argv29) != 0) {
|
2015-02-15 05:47:31 +00:00
|
|
|
printf("Error - "
|
|
|
|
"process did not run ok with valid corelist value\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-07-08 08:28:30 +00:00
|
|
|
/*
|
|
|
|
* Test --master-lcore option with matching coremask
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_master_lcore_flag(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-07-08 08:28:30 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char *prefix = "";
|
|
|
|
#else
|
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
|
|
|
#endif
|
|
|
|
|
2019-06-15 06:42:27 +00:00
|
|
|
if (!rte_lcore_is_enabled(0) || !rte_lcore_is_enabled(1))
|
|
|
|
return TEST_SKIPPED;
|
|
|
|
|
2014-07-08 08:28:30 +00:00
|
|
|
/* --master-lcore flag but no value */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv1[] = { prgname, prefix, mp_flag,
|
|
|
|
"-c", "3", "--master-lcore"};
|
2014-07-08 08:28:30 +00:00
|
|
|
/* --master-lcore flag with invalid value */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv2[] = { prgname, prefix, mp_flag,
|
|
|
|
"-c", "3", "--master-lcore", "-1"};
|
|
|
|
const char *argv3[] = { prgname, prefix, mp_flag,
|
|
|
|
"-c", "3", "--master-lcore", "X"};
|
2014-07-08 08:28:30 +00:00
|
|
|
/* master lcore not in coremask */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv4[] = { prgname, prefix, mp_flag,
|
|
|
|
"-c", "3", "--master-lcore", "2"};
|
2014-07-08 08:28:30 +00:00
|
|
|
/* valid value */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv5[] = { prgname, prefix, mp_flag,
|
|
|
|
"-c", "3", "--master-lcore", "1"};
|
2014-07-08 08:28:30 +00:00
|
|
|
/* valid value set before coremask */
|
2019-06-15 06:42:25 +00:00
|
|
|
const char *argv6[] = { prgname, prefix, mp_flag,
|
|
|
|
"--master-lcore", "1", "-c", "3"};
|
2014-07-08 08:28:30 +00:00
|
|
|
|
|
|
|
if (launch_proc(argv1) == 0
|
|
|
|
|| launch_proc(argv2) == 0
|
|
|
|
|| launch_proc(argv3) == 0
|
|
|
|
|| launch_proc(argv4) == 0) {
|
|
|
|
printf("Error - process ran without error with wrong --master-lcore\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv5) != 0
|
|
|
|
|| launch_proc(argv6) != 0) {
|
|
|
|
printf("Error - process did not run ok with valid --master-lcore\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/*
|
2015-11-06 15:15:13 +00:00
|
|
|
* Test that the app doesn't run with invalid -n flag option.
|
|
|
|
* Final test ensures it does run with valid options as sanity check
|
2012-09-04 12:54:00 +00:00
|
|
|
* Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf
|
|
|
|
* flags.
|
|
|
|
*/
|
|
|
|
static int
|
2015-11-06 15:15:13 +00:00
|
|
|
test_invalid_n_flag(void)
|
2012-09-04 12:54:00 +00:00
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/* -n flag but no value */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = { prgname, prefix, no_huge, no_shconf,
|
|
|
|
"-n"};
|
2012-09-04 12:54:00 +00:00
|
|
|
/* bad numeric value */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = { prgname, prefix, no_huge, no_shconf,
|
|
|
|
"-n", "e" };
|
2016-04-04 16:19:55 +00:00
|
|
|
/* zero is invalid */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv3[] = { prgname, prefix, no_huge, no_shconf,
|
|
|
|
"-n", "0" };
|
2012-09-04 12:54:00 +00:00
|
|
|
/* sanity test - check with good value */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv4[] = { prgname, prefix, no_huge, no_shconf,
|
|
|
|
"-n", "2" };
|
2015-11-06 15:15:13 +00:00
|
|
|
/* sanity test - check with no -n flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv5[] = { prgname, prefix, no_huge, no_shconf};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
if (launch_proc(argv1) == 0
|
|
|
|
|| launch_proc(argv2) == 0
|
2015-11-06 15:15:13 +00:00
|
|
|
|| launch_proc(argv3) == 0) {
|
|
|
|
printf("Error - process ran without error when"
|
|
|
|
"invalid -n flag\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2015-11-06 15:15:13 +00:00
|
|
|
if (launch_proc(argv4) != 0) {
|
2012-09-04 12:54:00 +00:00
|
|
|
printf("Error - process did not run ok with valid num-channel value\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2015-11-06 15:15:13 +00:00
|
|
|
if (launch_proc(argv5) != 0) {
|
|
|
|
printf("Error - process did not run ok without -n flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Test that the app runs with HPET, and without HPET
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_no_hpet_flag(void)
|
|
|
|
{
|
2018-07-25 13:44:26 +00:00
|
|
|
char prefix[PATH_MAX] = "";
|
2014-02-10 11:49:10 +00:00
|
|
|
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
return 0;
|
2018-07-25 13:44:26 +00:00
|
|
|
#else
|
|
|
|
char tmp[PATH_MAX];
|
2012-12-19 23:00:00 +00:00
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2018-07-25 13:44:26 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/* With --no-hpet */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = {prgname, prefix, mp_flag, no_hpet};
|
2012-09-04 12:54:00 +00:00
|
|
|
/* Without --no-hpet */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = {prgname, prefix, mp_flag};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
if (launch_proc(argv1) != 0) {
|
|
|
|
printf("Error - process did not run ok with --no-hpet flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv2) != 0) {
|
|
|
|
printf("Error - process did not run ok without --no-hpet flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
/*
|
2015-07-29 03:54:29 +00:00
|
|
|
* Test that the app runs with --no-huge and doesn't run when --socket-mem are
|
|
|
|
* specified with --no-huge.
|
2012-12-19 23:00:00 +00:00
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_no_huge_flag(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point, and we also need to
|
|
|
|
* run another primary process here */
|
|
|
|
const char * prefix = no_shconf;
|
|
|
|
#else
|
|
|
|
const char * prefix = "--file-prefix=nohuge";
|
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
/* With --no-huge */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = {prgname, prefix, no_huge};
|
2012-12-19 23:00:00 +00:00
|
|
|
/* With --no-huge and -m */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = {prgname, prefix, no_huge,
|
2014-11-05 12:11:17 +00:00
|
|
|
"-m", DEFAULT_MEM_SIZE};
|
2014-02-10 11:49:10 +00:00
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
/* With --no-huge and --socket-mem */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv3[] = {prgname, prefix, no_huge,
|
2014-11-05 12:11:17 +00:00
|
|
|
"--socket-mem=" DEFAULT_MEM_SIZE};
|
2012-12-19 23:00:00 +00:00
|
|
|
/* With --no-huge, -m and --socket-mem */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv4[] = {prgname, prefix, no_huge,
|
2014-11-05 12:11:17 +00:00
|
|
|
"-m", DEFAULT_MEM_SIZE, "--socket-mem=" DEFAULT_MEM_SIZE};
|
2012-12-19 23:00:00 +00:00
|
|
|
if (launch_proc(argv1) != 0) {
|
|
|
|
printf("Error - process did not run ok with --no-huge flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2015-07-29 03:54:29 +00:00
|
|
|
if (launch_proc(argv2) != 0) {
|
|
|
|
printf("Error - process did not run ok with --no-huge and -m flags\n");
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target does not support NUMA, hence no --socket-mem tests */
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
if (launch_proc(argv3) == 0) {
|
|
|
|
printf("Error - process run ok with --no-huge and --socket-mem "
|
|
|
|
"flags\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv4) == 0) {
|
|
|
|
printf("Error - process run ok with --no-huge, -m and "
|
|
|
|
"--socket-mem flags\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
static int
|
|
|
|
test_misc_flags(void)
|
|
|
|
{
|
2013-06-03 00:00:00 +00:00
|
|
|
char hugepath[PATH_MAX] = {0};
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
const char * nosh_prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
2014-02-10 11:49:10 +00:00
|
|
|
const char * nosh_prefix = "--file-prefix=noshconf";
|
|
|
|
FILE * hugedir_handle = NULL;
|
|
|
|
char line[PATH_MAX] = {0};
|
2013-06-03 00:00:00 +00:00
|
|
|
unsigned i, isempty = 1;
|
2012-12-19 23:00:00 +00:00
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2013-06-03 00:00:00 +00:00
|
|
|
/*
|
|
|
|
* get first valid hugepage path
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* get hugetlbfs mountpoints from /proc/mounts */
|
|
|
|
hugedir_handle = fopen("/proc/mounts", "r");
|
|
|
|
|
|
|
|
if (hugedir_handle == NULL) {
|
|
|
|
printf("Error opening /proc/mounts!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* read /proc/mounts */
|
|
|
|
while (fgets(line, sizeof(line), hugedir_handle) != NULL) {
|
|
|
|
|
|
|
|
/* find first valid hugepath */
|
|
|
|
if (get_hugepage_path(line, sizeof(line), hugepath, sizeof(hugepath)))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
fclose(hugedir_handle);
|
|
|
|
|
|
|
|
/* check if path is not empty */
|
|
|
|
for (i = 0; i < sizeof(hugepath); i++)
|
|
|
|
if (hugepath[i] != '\0')
|
|
|
|
isempty = 0;
|
|
|
|
|
|
|
|
if (isempty) {
|
|
|
|
printf("No mounted hugepage dir found!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2013-06-03 00:00:00 +00:00
|
|
|
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
/* check that some general flags don't prevent things from working.
|
|
|
|
* All cases, apart from the first, app should run.
|
2017-06-07 05:05:06 +00:00
|
|
|
* No further testing of output done.
|
2012-09-04 12:54:00 +00:00
|
|
|
*/
|
|
|
|
/* sanity check - failure with invalid option */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv0[] = {prgname, prefix, mp_flag, "--invalid-opt"};
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
/* With --no-pci */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = {prgname, prefix, mp_flag, "--no-pci"};
|
2012-09-04 12:54:00 +00:00
|
|
|
/* With -v */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = {prgname, prefix, mp_flag, "-v"};
|
2013-06-03 00:00:00 +00:00
|
|
|
/* With valid --syslog */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv3[] = {prgname, prefix, mp_flag,
|
2013-06-03 00:00:00 +00:00
|
|
|
"--syslog", "syslog"};
|
|
|
|
/* With empty --syslog (should fail) */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv4[] = {prgname, prefix, mp_flag, "--syslog"};
|
2013-06-03 00:00:00 +00:00
|
|
|
/* With invalid --syslog */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv5[] = {prgname, prefix, mp_flag, "--syslog", "error"};
|
2018-07-16 16:34:04 +00:00
|
|
|
/* With no-sh-conf, also use no-huge to ensure this test runs on BSD */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv6[] = {prgname, "-m", DEFAULT_MEM_SIZE,
|
2018-07-16 16:34:04 +00:00
|
|
|
no_shconf, nosh_prefix, no_huge};
|
2014-02-10 11:49:10 +00:00
|
|
|
|
2013-06-03 00:00:00 +00:00
|
|
|
/* With --huge-dir */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv7[] = {prgname, "-m", DEFAULT_MEM_SIZE,
|
2013-06-03 00:00:00 +00:00
|
|
|
"--file-prefix=hugedir", "--huge-dir", hugepath};
|
|
|
|
/* With empty --huge-dir (should fail) */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv8[] = {prgname, "-m", DEFAULT_MEM_SIZE,
|
2013-06-03 00:00:00 +00:00
|
|
|
"--file-prefix=hugedir", "--huge-dir"};
|
|
|
|
/* With invalid --huge-dir */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv9[] = {prgname, "-m", DEFAULT_MEM_SIZE,
|
2013-06-03 00:00:00 +00:00
|
|
|
"--file-prefix=hugedir", "--huge-dir", "invalid"};
|
|
|
|
/* Secondary process with invalid --huge-dir (should run as flag has no
|
|
|
|
* effect on secondary processes) */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv10[] = {prgname, prefix, mp_flag,
|
|
|
|
"--huge-dir", "invalid"};
|
2013-06-03 00:00:00 +00:00
|
|
|
|
2014-02-12 15:32:25 +00:00
|
|
|
/* try running with base-virtaddr param */
|
|
|
|
const char *argv11[] = {prgname, "--file-prefix=virtaddr",
|
2019-06-15 06:42:26 +00:00
|
|
|
"--base-virtaddr=0x12345678"};
|
2014-02-12 15:32:25 +00:00
|
|
|
|
2014-06-13 14:52:49 +00:00
|
|
|
/* try running with --vfio-intr INTx flag */
|
|
|
|
const char *argv12[] = {prgname, "--file-prefix=intr",
|
2019-06-15 06:42:26 +00:00
|
|
|
"--vfio-intr=legacy"};
|
2014-06-13 14:52:49 +00:00
|
|
|
|
|
|
|
/* try running with --vfio-intr MSI flag */
|
|
|
|
const char *argv13[] = {prgname, "--file-prefix=intr",
|
2019-06-15 06:42:26 +00:00
|
|
|
"--vfio-intr=msi"};
|
2014-06-13 14:52:49 +00:00
|
|
|
|
|
|
|
/* try running with --vfio-intr MSI-X flag */
|
|
|
|
const char *argv14[] = {prgname, "--file-prefix=intr",
|
2019-06-15 06:42:26 +00:00
|
|
|
"--vfio-intr=msix"};
|
2014-06-13 14:52:49 +00:00
|
|
|
|
|
|
|
/* try running with --vfio-intr invalid flag */
|
|
|
|
const char *argv15[] = {prgname, "--file-prefix=intr",
|
2019-06-15 06:42:26 +00:00
|
|
|
"--vfio-intr=invalid"};
|
2014-06-13 14:52:49 +00:00
|
|
|
|
2018-07-16 16:34:04 +00:00
|
|
|
/* run all tests also applicable to FreeBSD first */
|
2012-09-04 12:54:00 +00:00
|
|
|
|
|
|
|
if (launch_proc(argv0) == 0) {
|
|
|
|
printf("Error - process ran ok with invalid flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv1) != 0) {
|
|
|
|
printf("Error - process did not run ok with --no-pci flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv2) != 0) {
|
|
|
|
printf("Error - process did not run ok with -v flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2018-07-16 16:34:04 +00:00
|
|
|
if (launch_proc(argv6) != 0) {
|
|
|
|
printf("Error - process did not run ok with --no-shconf flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2018-07-16 16:34:04 +00:00
|
|
|
/* no more tests to be done on FreeBSD */
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
|
2013-06-03 00:00:00 +00:00
|
|
|
if (launch_proc(argv3) != 0) {
|
|
|
|
printf("Error - process did not run ok with --syslog flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv4) == 0) {
|
|
|
|
printf("Error - process run ok with empty --syslog flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv5) == 0) {
|
|
|
|
printf("Error - process run ok with invalid --syslog flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv7) != 0) {
|
|
|
|
printf("Error - process did not run ok with --huge-dir flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv8) == 0) {
|
|
|
|
printf("Error - process run ok with empty --huge-dir flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv9) == 0) {
|
|
|
|
printf("Error - process run ok with invalid --huge-dir flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv10) != 0) {
|
|
|
|
printf("Error - secondary process did not run ok with invalid --huge-dir flag\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-02-12 15:32:25 +00:00
|
|
|
if (launch_proc(argv11) != 0) {
|
|
|
|
printf("Error - process did not run ok with --base-virtaddr parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-13 14:52:49 +00:00
|
|
|
if (launch_proc(argv12) != 0) {
|
|
|
|
printf("Error - process did not run ok with "
|
|
|
|
"--vfio-intr INTx parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv13) != 0) {
|
|
|
|
printf("Error - process did not run ok with "
|
|
|
|
"--vfio-intr MSI parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv14) != 0) {
|
|
|
|
printf("Error - process did not run ok with "
|
|
|
|
"--vfio-intr MSI-X parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (launch_proc(argv15) == 0) {
|
|
|
|
printf("Error - process run ok with "
|
|
|
|
"--vfio-intr invalid parameter\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2012-12-19 23:00:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
test_file_prefix(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* 1. check if current process hugefiles are locked
|
|
|
|
* 2. try to run secondary process without a corresponding primary process
|
|
|
|
* (while failing to run, it will also remove any unused hugepage files)
|
|
|
|
* 3. check if current process hugefiles are still in place and are locked
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
* 4. run a primary process with memtest1 prefix in default and legacy
|
|
|
|
* mem mode
|
|
|
|
* 5. check if memtest1 hugefiles are created in case of legacy mem
|
|
|
|
* mode, and deleted in case of default mem mode
|
|
|
|
* 6. run a primary process with memtest2 prefix in default and legacy
|
|
|
|
* mem modes
|
|
|
|
* 7. check that memtest2 hugefiles are present in the hugedir after a
|
|
|
|
* run in legacy mode, and not present at all after run in default
|
|
|
|
* mem mode
|
2012-12-19 23:00:00 +00:00
|
|
|
*/
|
2018-07-25 13:44:26 +00:00
|
|
|
char prefix[PATH_MAX] = "";
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
return 0;
|
2018-07-25 13:44:26 +00:00
|
|
|
#else
|
|
|
|
if (get_current_prefix(prefix, sizeof(prefix)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
/* this should fail unless the test itself is run with "memtest" prefix */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv0[] = {prgname, mp_flag, "-m",
|
2019-06-15 06:42:25 +00:00
|
|
|
DEFAULT_MEM_SIZE, "--file-prefix=" memtest };
|
2012-12-19 23:00:00 +00:00
|
|
|
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
/* primary process with memtest1 and default mem mode */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = {prgname, "-m",
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
DEFAULT_MEM_SIZE, "--file-prefix=" memtest1 };
|
2012-12-19 23:00:00 +00:00
|
|
|
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
/* primary process with memtest1 and legacy mem mode */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = {prgname, "-m",
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
DEFAULT_MEM_SIZE, "--file-prefix=" memtest1,
|
|
|
|
"--legacy-mem" };
|
|
|
|
|
|
|
|
/* primary process with memtest2 and legacy mem mode */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv3[] = {prgname, "-m",
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
DEFAULT_MEM_SIZE, "--file-prefix=" memtest2,
|
|
|
|
"--legacy-mem" };
|
|
|
|
|
|
|
|
/* primary process with memtest2 and default mem mode */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv4[] = {prgname, "-m",
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 };
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2019-07-03 07:13:30 +00:00
|
|
|
/* primary process with --in-memory mode */
|
|
|
|
const char * const argv5[] = {prgname, "-m",
|
|
|
|
DEFAULT_MEM_SIZE, "--in-memory" };
|
|
|
|
|
|
|
|
/* primary process with memtest1 and --in-memory mode */
|
|
|
|
const char * const argv6[] = {prgname, "-m",
|
|
|
|
DEFAULT_MEM_SIZE, "--in-memory",
|
|
|
|
"--file-prefix=" memtest1 };
|
|
|
|
|
|
|
|
/* primary process with parent file-prefix and --in-memory mode */
|
|
|
|
const char * const argv7[] = {prgname, "-m",
|
|
|
|
DEFAULT_MEM_SIZE, "--in-memory", "--file-prefix", prefix };
|
|
|
|
|
|
|
|
/* primary process with memtest1 and --single-file-segments mode */
|
|
|
|
const char * const argv8[] = {prgname, "-m",
|
|
|
|
DEFAULT_MEM_SIZE, "--single-file-segments",
|
|
|
|
"--file-prefix=" memtest1 };
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
/* check if files for current prefix are present */
|
|
|
|
if (process_hugefiles(prefix, HUGEPAGE_CHECK_EXISTS) != 1) {
|
|
|
|
printf("Error - hugepage files for %s were not created!\n", prefix);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* checks if files for current prefix are locked */
|
|
|
|
if (process_hugefiles(prefix, HUGEPAGE_CHECK_LOCKED) != 1) {
|
|
|
|
printf("Error - hugepages for current process aren't locked!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if files for secondary process are present */
|
|
|
|
if (process_hugefiles(memtest, HUGEPAGE_CHECK_EXISTS) == 1) {
|
|
|
|
/* check if they are not locked */
|
|
|
|
if (process_hugefiles(memtest, HUGEPAGE_CHECK_LOCKED) == 1) {
|
|
|
|
printf("Error - hugepages for current process are locked!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
/* they aren't locked, delete them */
|
|
|
|
else {
|
|
|
|
if (process_hugefiles(memtest, HUGEPAGE_DELETE) != 1) {
|
|
|
|
printf("Error - deleting hugepages failed!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv0) == 0) {
|
|
|
|
printf("Error - secondary process ran ok without primary process\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if files for current prefix are present */
|
|
|
|
if (process_hugefiles(prefix, HUGEPAGE_CHECK_EXISTS) != 1) {
|
|
|
|
printf("Error - hugepage files for %s were not created!\n", prefix);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* checks if files for current prefix are locked */
|
|
|
|
if (process_hugefiles(prefix, HUGEPAGE_CHECK_LOCKED) != 1) {
|
|
|
|
printf("Error - hugepages for current process aren't locked!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
/* we're running this process in default memory mode, which means it
|
|
|
|
* should clean up after itself on exit and leave no hugepages behind.
|
|
|
|
*/
|
2012-12-19 23:00:00 +00:00
|
|
|
if (launch_proc(argv1) != 0) {
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
printf("Error - failed to run with --file-prefix=%s\n",
|
|
|
|
memtest1);
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if memtest1_map0 is present */
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
|
|
|
|
printf("Error - hugepage files for %s were not deleted!\n",
|
|
|
|
memtest1);
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
/* now, we're running a process under the same prefix, but with legacy
|
|
|
|
* mem mode - this should leave behind hugepage files.
|
|
|
|
*/
|
2012-12-19 23:00:00 +00:00
|
|
|
if (launch_proc(argv2) != 0) {
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
printf("Error - failed to run with --file-prefix=%s\n",
|
|
|
|
memtest1);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if memtest1_map0 is present */
|
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 1) {
|
|
|
|
printf("Error - hugepage files for %s were not created!\n",
|
|
|
|
memtest1);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv3) != 0) {
|
|
|
|
printf("Error - failed to run with --file-prefix=%s\n",
|
|
|
|
memtest2);
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest2 are present */
|
|
|
|
if (process_hugefiles(memtest2, HUGEPAGE_CHECK_EXISTS) != 1) {
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
printf("Error - hugepage files for %s were not created!\n",
|
|
|
|
memtest2);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest1 are present */
|
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
|
|
|
|
printf("Error - hugepage files for %s were not deleted!\n",
|
|
|
|
memtest1);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* this process will run in default mem mode, so it should not leave any
|
|
|
|
* hugepage files behind.
|
|
|
|
*/
|
|
|
|
if (launch_proc(argv4) != 0) {
|
|
|
|
printf("Error - failed to run with --file-prefix=%s\n",
|
|
|
|
memtest2);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest2 are present */
|
|
|
|
if (process_hugefiles(memtest2, HUGEPAGE_CHECK_EXISTS) != 0) {
|
|
|
|
printf("Error - hugepage files for %s were not deleted!\n",
|
|
|
|
memtest2);
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest1 are present */
|
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
|
test: fix hugepage file handling in EAL flags autotest
Before 18.05, DPDK could not release memory back to the system
neither at runtime nor before shutting down. Over the course of
18.05 up to 18.11, code was introduced to release memory at
runtime, as well as an rte_eal_cleanup() function that is supposed
to release all EAL-allocated memory before shutting down DPDK.
When 3f9e31d71d63 ("test: clean up on exit") was introduced, the
test application started to use rte_eal_cleanup() to release all
used memory after execution. However, the EAL flags autotest
still relies on the old behavior of leaving stuff behind in the
hugetlbfs.
The fix is twofold. First, the test to check for leftover files
in hugetlbfs is no longer valid as it is, because test application
now removes all files from hugetlbfs after exit. However, if we
use the --legacy-mem option, then old behavior of leaving files
in hugetlbfs after execution is restored. So the first fix is to
add --legacy-mem to all the tests that expect files in hugetlbfs
to be leftover.
However, we also need to test if default memory mode *doesn't*
leave any files behind, so we also extend the test to check for
these scenarios as well. So, both memtest1 and memtest2 are run
in legacy and default mem modes, and are checked for any leftover
files that are or are not supposed to be there.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2018-11-15 12:18:05 +00:00
|
|
|
printf("Error - hugepage files for %s were not deleted!\n",
|
|
|
|
memtest1);
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2019-07-03 07:13:30 +00:00
|
|
|
/* this process will run in --in-memory mode, so it should not leave any
|
|
|
|
* hugepage files behind.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* test case to check eal-options with --in-memory mode */
|
|
|
|
if (launch_proc(argv5) != 0) {
|
|
|
|
printf("Error - failed to run with --in-memory mode\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*test case to check eal-options with --in-memory mode with
|
|
|
|
* custom file-prefix.
|
|
|
|
*/
|
|
|
|
if (launch_proc(argv6) != 0) {
|
|
|
|
printf("Error - failed to run with --in-memory mode\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest1 are present */
|
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
|
|
|
|
printf("Error - hugepage files for %s were created and not deleted!\n",
|
|
|
|
memtest1);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* test case to check eal-options with --in-memory mode with
|
|
|
|
* parent file-prefix.
|
|
|
|
*/
|
|
|
|
if (launch_proc(argv7) != 0) {
|
|
|
|
printf("Error - failed to run with --file-prefix=%s\n", prefix);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* this process will run in --single-file-segments mode,
|
|
|
|
* so it should not leave any hugepage files behind.
|
|
|
|
*/
|
|
|
|
if (launch_proc(argv8) != 0) {
|
|
|
|
printf("Error - failed to run with --single-file-segments mode\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if hugefiles for memtest1 are present */
|
|
|
|
if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
|
|
|
|
printf("Error - hugepage files for %s were not deleted!\n",
|
|
|
|
memtest1);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Tests for correct handling of -m and --socket-mem flags
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
test_memory_flags(void)
|
|
|
|
{
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* BSD target doesn't support prefixes at this point */
|
|
|
|
const char * prefix = "";
|
|
|
|
#else
|
2012-12-19 23:00:00 +00:00
|
|
|
char prefix[PATH_MAX], tmp[PATH_MAX];
|
|
|
|
if (get_current_prefix(tmp, sizeof(tmp)) == NULL) {
|
|
|
|
printf("Error - unable to get current prefix!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
/* valid -m flag and mp flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv0[] = {prgname, prefix, mp_flag,
|
2019-06-15 06:42:25 +00:00
|
|
|
"-m", DEFAULT_MEM_SIZE};
|
2014-02-12 15:32:25 +00:00
|
|
|
|
|
|
|
/* valid -m flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv1[] = {prgname,
|
2014-11-05 12:11:17 +00:00
|
|
|
"--file-prefix=" memtest, "-m", DEFAULT_MEM_SIZE};
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2019-01-25 07:55:58 +00:00
|
|
|
/* valid (zero) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv2[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem=0,0,0,0"};
|
|
|
|
|
|
|
|
/* invalid (incomplete) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv3[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem=2,2,"};
|
|
|
|
|
|
|
|
/* invalid (mixed with invalid data) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv4[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem=2,2,Fred"};
|
|
|
|
|
|
|
|
/* invalid (with numeric value as last character) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv5[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem=2,2,Fred0"};
|
|
|
|
|
|
|
|
/* invalid (with empty socket) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv6[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem=2,,2"};
|
|
|
|
|
|
|
|
/* invalid (null) --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv7[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, "--socket-mem="};
|
|
|
|
|
|
|
|
/* valid --socket-mem specified together with -m flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv8[] = {prgname,
|
2014-11-05 12:11:17 +00:00
|
|
|
"--file-prefix=" memtest, "-m", DEFAULT_MEM_SIZE, "--socket-mem=2,2"};
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
/* construct an invalid socket mask with 2 megs on each socket plus
|
|
|
|
* extra 2 megs on socket that doesn't exist on current system */
|
|
|
|
char invalid_socket_mem[SOCKET_MEM_STRLEN];
|
|
|
|
char buf[SOCKET_MEM_STRLEN]; /* to avoid copying string onto itself */
|
2014-02-10 11:49:10 +00:00
|
|
|
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
int i, num_sockets = 1;
|
|
|
|
#else
|
2018-02-06 02:21:38 +00:00
|
|
|
int i, num_sockets = RTE_MIN(get_number_of_sockets(),
|
|
|
|
RTE_MAX_NUMA_NODES);
|
2014-02-10 11:49:10 +00:00
|
|
|
#endif
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2018-02-06 02:21:38 +00:00
|
|
|
if (num_sockets <= 0) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error - cannot get number of sockets!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(invalid_socket_mem, sizeof(invalid_socket_mem), "--socket-mem=");
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
/* add one extra socket */
|
|
|
|
for (i = 0; i < num_sockets + 1; i++) {
|
2014-11-05 12:11:17 +00:00
|
|
|
snprintf(buf, sizeof(buf), "%s%s", invalid_socket_mem, DEFAULT_MEM_SIZE);
|
2018-03-12 11:33:00 +00:00
|
|
|
strlcpy(invalid_socket_mem, buf, sizeof(invalid_socket_mem));
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
if (num_sockets + 1 - i > 1) {
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(buf, sizeof(buf), "%s,", invalid_socket_mem);
|
2018-03-12 11:33:00 +00:00
|
|
|
strlcpy(invalid_socket_mem, buf,
|
|
|
|
sizeof(invalid_socket_mem));
|
2012-12-19 23:00:00 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* construct a valid socket mask with 2 megs on each existing socket */
|
|
|
|
char valid_socket_mem[SOCKET_MEM_STRLEN];
|
|
|
|
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(valid_socket_mem, sizeof(valid_socket_mem), "--socket-mem=");
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
/* add one extra socket */
|
|
|
|
for (i = 0; i < num_sockets; i++) {
|
2014-11-05 12:11:17 +00:00
|
|
|
snprintf(buf, sizeof(buf), "%s%s", valid_socket_mem, DEFAULT_MEM_SIZE);
|
2018-03-12 11:33:00 +00:00
|
|
|
strlcpy(valid_socket_mem, buf, sizeof(valid_socket_mem));
|
2012-12-19 23:00:00 +00:00
|
|
|
|
|
|
|
if (num_sockets - i > 1) {
|
2014-06-24 18:15:28 +00:00
|
|
|
snprintf(buf, sizeof(buf), "%s,", valid_socket_mem);
|
2018-03-12 11:33:00 +00:00
|
|
|
strlcpy(valid_socket_mem, buf,
|
|
|
|
sizeof(valid_socket_mem));
|
2012-12-19 23:00:00 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* invalid --socket-mem flag (with extra socket) */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv9[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, invalid_socket_mem};
|
|
|
|
|
|
|
|
/* valid --socket-mem flag */
|
2019-06-15 06:42:26 +00:00
|
|
|
const char *argv10[] = {prgname,
|
2012-12-19 23:00:00 +00:00
|
|
|
"--file-prefix=" memtest, valid_socket_mem};
|
|
|
|
|
|
|
|
if (launch_proc(argv0) != 0) {
|
2014-02-10 11:49:10 +00:00
|
|
|
printf("Error - secondary process failed with valid -m flag !\n");
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2019-03-06 16:22:40 +00:00
|
|
|
#ifdef RTE_EXEC_ENV_FREEBSD
|
2014-02-10 11:49:10 +00:00
|
|
|
/* no other tests are applicable to BSD */
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
|
2012-12-19 23:00:00 +00:00
|
|
|
if (launch_proc(argv1) != 0) {
|
2014-02-12 15:32:25 +00:00
|
|
|
printf("Error - process failed with valid -m flag!\n");
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2019-01-25 07:55:58 +00:00
|
|
|
if (launch_proc(argv2) != 0) {
|
|
|
|
printf("Error - process failed with valid (zero) --socket-mem!\n");
|
2012-12-19 23:00:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv3) == 0) {
|
|
|
|
printf("Error - process run ok with invalid "
|
|
|
|
"(incomplete) --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv4) == 0) {
|
|
|
|
printf("Error - process run ok with invalid "
|
|
|
|
"(mixed with invalid input) --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv5) == 0) {
|
|
|
|
printf("Error - process run ok with invalid "
|
|
|
|
"(mixed with invalid input with a numeric value as "
|
|
|
|
"last character) --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv6) == 0) {
|
|
|
|
printf("Error - process run ok with invalid "
|
|
|
|
"(with empty socket) --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv7) == 0) {
|
|
|
|
printf("Error - process run ok with invalid (null) --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv8) == 0) {
|
|
|
|
printf("Error - process run ok with --socket-mem and -m specified!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv9) == 0) {
|
|
|
|
printf("Error - process run ok with extra socket in --socket-mem!\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (launch_proc(argv10) != 0) {
|
|
|
|
printf("Error - process failed with valid --socket-mem!\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2012-12-19 23:00:00 +00:00
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-08-18 11:29:23 +00:00
|
|
|
static int
|
2012-09-04 12:54:00 +00:00
|
|
|
test_eal_flags(void)
|
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
ret = test_missing_c_flag();
|
|
|
|
if (ret < 0) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error in test_missing_c_flag()\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-07-08 08:28:30 +00:00
|
|
|
ret = test_master_lcore_flag();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_master_lcore_flag()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-11-06 15:15:13 +00:00
|
|
|
ret = test_invalid_n_flag();
|
2012-09-04 12:54:00 +00:00
|
|
|
if (ret < 0) {
|
2015-11-06 15:15:13 +00:00
|
|
|
printf("Error in test_invalid_n_flag()\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = test_no_hpet_flag();
|
|
|
|
if (ret < 0) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error in test_no_hpet_flag()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = test_no_huge_flag();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_no_huge_flag()\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-09-18 10:00:00 +00:00
|
|
|
ret = test_whitelist_flag();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_invalid_whitelist_flag()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2012-09-04 12:54:00 +00:00
|
|
|
ret = test_invalid_b_flag();
|
|
|
|
if (ret < 0) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error in test_invalid_b_flag()\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-07-01 16:13:57 +00:00
|
|
|
#ifdef RTE_LIBRTE_PMD_RING
|
|
|
|
ret = test_invalid_vdev_flag();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_invalid_vdev_flag()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
#endif
|
2012-09-04 12:54:00 +00:00
|
|
|
ret = test_invalid_r_flag();
|
|
|
|
if (ret < 0) {
|
2012-12-19 23:00:00 +00:00
|
|
|
printf("Error in test_invalid_r_flag()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = test_memory_flags();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_memory_flags()\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = test_file_prefix();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_file_prefix()\n");
|
2012-09-04 12:54:00 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = test_misc_flags();
|
|
|
|
if (ret < 0) {
|
|
|
|
printf("Error in test_misc_flags()");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-07-13 12:38:13 +00:00
|
|
|
REGISTER_TEST_COMMAND(eal_flags_autotest, test_eal_flags);
|
2019-06-15 06:42:28 +00:00
|
|
|
|
|
|
|
/* subtests used in meson for CI */
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_c_opt_autotest, test_missing_c_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_master_opt_autotest, test_master_lcore_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_n_opt_autotest, test_invalid_n_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_hpet_autotest, test_no_hpet_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_no_huge_autotest, test_no_huge_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_whitelist_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_b_opt_autotest, test_invalid_b_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_vdev_opt_autotest, test_invalid_vdev_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_r_opt_autotest, test_invalid_r_flag);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_mem_autotest, test_memory_flags);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_file_prefix_autotest, test_file_prefix);
|
|
|
|
REGISTER_TEST_COMMAND(eal_flags_misc_autotest, test_misc_flags);
|