mbuf: fix logic of user mempool ops API

The existing rte_eal_mbuf_default mempool ops can return the compile time
default ops name if the user has not provided command line inputs for
mempool ops name. It will break the logic of best mempool ops as it will
never return platform hw mempool ops.

This patch introduces a new API to just return the user mempool ops only.

Fixes: 8b0f7f4341 ("mbuf: maintain user and compile time mempool ops name")

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
This commit is contained in:
Nipun Gupta 2018-02-02 13:33:01 +05:30 committed by Thomas Monjalon
parent ce42ae42bc
commit 028e4b1dbc
5 changed files with 28 additions and 1 deletions

View File

@ -82,6 +82,13 @@ struct internal_config internal_config;
/* used by rte_rdtsc() */
int rte_cycles_vmware_tsc_map;
/* Return user provided mbuf pool ops name */
const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void)
{
return internal_config.user_mbuf_pool_ops_name;
}
/* Return mbuf pool ops name */
const char *
rte_eal_mbuf_default_mempool_ops(void)

View File

@ -451,6 +451,18 @@ static inline int rte_gettid(void)
*/
enum rte_iova_mode rte_eal_iova_mode(void);
/**
* @warning
* @b EXPERIMENTAL: this API may change without prior notice
*
* Get user provided pool ops name for mbuf
*
* @return
* returns user provided pool ops name.
*/
const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void);
/**
* Get default pool ops name for mbuf
*

View File

@ -92,6 +92,13 @@ struct internal_config internal_config;
/* used by rte_rdtsc() */
int rte_cycles_vmware_tsc_map;
/* Return user provided mbuf pool ops name */
const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void)
{
return internal_config.user_mbuf_pool_ops_name;
}
/* Return mbuf pool ops name */
const char *
rte_eal_mbuf_default_mempool_ops(void)

View File

@ -220,6 +220,7 @@ EXPERIMENTAL {
rte_eal_devargs_remove;
rte_eal_hotplug_add;
rte_eal_hotplug_remove;
rte_eal_mbuf_user_pool_ops;
rte_mp_action_register;
rte_mp_action_unregister;
rte_mp_sendmsg;

View File

@ -74,7 +74,7 @@ rte_mbuf_user_mempool_ops(void)
mz = rte_memzone_lookup("mbuf_user_pool_ops");
if (mz == NULL)
return rte_eal_mbuf_default_mempool_ops();
return rte_eal_mbuf_user_pool_ops();
return mz->addr;
}