d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

kvargs: remove useless size field

Browse Source 
This value was not very useful as the size of the table is fixed (equals
RTE_KVARGS_MAX).

By the way, the memset in the initialization function was wrong (size
too short). Even if it was not really an issue since we rely on the
"count" field, it is now fixed by this patch.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Olivier Matz 2014-01-28 17:06:37 +01:00 committed by David Marchand
parent 991543e815
commit 03b611b713
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/librte_kvargs/rte_kvargs.c
View File

@ -48,8 +48,7 @@ int
rte_kvargs_init(struct rte_kvargs *kvlist)
{
kvlist->count = 0;
kvlist->size = RTE_KVARGS_MAX;
memset(kvlist->pairs, 0, kvlist->size);
memset(kvlist->pairs, 0, sizeof(kvlist->pairs));
return 0;
}
@ -64,7 +63,7 @@ rte_kvargs_add_pair(struct rte_kvargs *kvlist, char *key, char *val)
struct rte_kvargs_pair* entry;
/* is the list full? */
if (kvlist->count >= kvlist->size) {
if (kvlist->count >= RTE_KVARGS_MAX) {
RTE_LOG(ERR, PMD, "Couldn't add %s, key/value list is full\n", key);
return -1;
}

1
lib/librte_kvargs/rte_kvargs.h
View File

@ -71,7 +71,6 @@ struct rte_kvargs_pair {
/** Store a list of key/value associations */
struct rte_kvargs {
unsigned count; /**< number of entries in the list */
size_t size; /**< maximum number of entries */
struct rte_kvargs_pair pairs[RTE_KVARGS_MAX]; /**< list of key/values */
};