d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

config/x86: skip GNU binutils bug check for LLVM

Browse Source 
AVX512 was disabled when GNU binutils were missing or had a known bug,
even if LLVM binutils were used for the build,
because binutils-avx512-check.sh was invoked regardless and failed.
In particular, this was the case for FreeBSD with clang (default).
Run the check only when GNU binutils are used.

Fixes: 68b1f1cda5 ("build: check AVX512 rather than binutils version")
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Dmitry Kozlyuk 2021-11-13 00:48:24 +03:00 committed by Thomas Monjalon
parent 329f73eb35
commit 04f9fac660
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
config/x86/meson.build
View File

@ -2,9 +2,10 @@
# Copyright(c) 2017-2020 Intel Corporation
# get binutils version for the workaround of Bug 97
if not is_windows
binutils_ok = run_command(binutils_avx512_check)
if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f')
binutils_ok = true
if not is_windows and (is_linux or cc.get_id() == 'gcc')
binutils_ok = run_command(binutils_avx512_check).returncode() == 0
if not binutils_ok and cc.has_argument('-mno-avx512f')
machine_args += '-mno-avx512f'
warning('Binutils error with AVX512 assembly, disabling AVX512 support')
endif

2
lib/acl/meson.build
View File

@ -36,7 +36,7 @@ if dpdk_conf.has('RTE_ARCH_X86')
# compile AVX512 version if:
# we are building 64-bit binary AND binutils can generate proper code
if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0
if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok
# compile AVX512 version if either:
# a. we have AVX512 supported in minimum instruction set

2
lib/fib/meson.build
View File

@ -14,7 +14,7 @@ deps += ['rib']
# compile AVX512 version if:
# we are building 64-bit binary AND binutils can generate proper code
if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0
if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok
# compile AVX512 version if either:
# a. we have AVX512F supported in minimum instruction set baseline
# b. it's not minimum instruction set, but supported by compiler