d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bitrate: fix registration to match API description

Browse Source 
rte_stats_bitrate_reg() API states it returns 'Zero on success'.

However, the implementation directly returns the return of
rte_metrics_reg_names() which may be zero or positive on success,
with a positive value also indicating the index.

The user of rte_stats_bitrate_reg() should not care about the
index as it is stored in the opaque rte_stats_bitrates struct.

Change the implementation of rte_stats_bitrate_reg() to match
the API description by always returning zero on success.

Fixes: 2ad7ba9a65 ("bitrate: add bitrate statistics library")

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
This commit is contained in:
Kevin Traynor 2021-07-09 16:19:36 +01:00 committed by Thomas Monjalon
parent 71ecc415c5
commit 06ae9f0f92
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/bitratestats/rte_bitrate.c
View File

@ -55,8 +55,10 @@ rte_stats_bitrate_reg(struct rte_stats_bitrates *bitrate_data)
return -EINVAL;
return_value = rte_metrics_reg_names(&names[0], RTE_DIM(names));
if (return_value >= 0)
if (return_value >= 0) {
bitrate_data->id_stats_set = return_value;
return 0;
}
return return_value;
}