d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vdpa/mlx5: fix event setup

Browse Source 
The completion event mechanism should work only if at least one of the
virtqs has valid callfd to be notified on.

When all the virtqs works with poll mode, the event mechanism should not
be configured.

The driver didn't take it into account and crashed in the above case.

Do not configure event interrupt when all the virtqs are in poll mode.

Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues")

Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
This commit is contained in:
Matan Azrad 2020-02-25 08:43:48 +00:00 committed by Thomas Monjalon
parent e392aa889c
commit 06da8cccb6
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/vdpa/mlx5/mlx5_vdpa_event.c
View File

@ -241,8 +241,14 @@ mlx5_vdpa_interrupt_handler(void *cb_arg)
int
mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
{
int flags = fcntl(priv->eventc->fd, F_GETFL);
int ret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);
int flags;
int ret;
if (!priv->eventc)
/* All virtqs are in poll mode. */
return 0;
flags = fcntl(priv->eventc->fd, F_GETFL);
ret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);
if (ret) {
DRV_LOG(ERR, "Failed to change event channel FD.");
rte_errno = errno;