d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

scripts: fix checkpatch help

Browse Source 
When started without defining DPDK_CHECKPATCH_PATH, the usage was not
displayed.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
This commit is contained in:
Olivier Matz 2016-02-16 15:36:54 +01:00 committed by Thomas Monjalon
parent 4e72892c33
commit 0853f25d25
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/checkpatches.sh
View File

@ -34,10 +34,6 @@
# - DPDK_CHECKPATCH_PATH # - DPDK_CHECKPATCH_PATH
# - DPDK_CHECKPATCH_LINE_LENGTH # - DPDK_CHECKPATCH_LINE_LENGTH
. scripts/load-devel-config.sh . scripts/load-devel-config.sh
if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
exit 1
fi
length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
@ -51,7 +47,12 @@ SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
NEW_TYPEDEFS,COMPARISON_TO_NULL" NEW_TYPEDEFS,COMPARISON_TO_NULL"
print_usage () { print_usage () {
echo "usage: $(basename $0) [-q] [-v] [patch1 [patch2] ...]]" cat <<- END_OF_HELP
usage: $(basename $0) [-q] [-v] [patch1 [patch2] ...]]
Run Linux kernel checkpatch.pl with DPDK options.
The environment variable DPDK_CHECKPATCH_PATH must be set.
END_OF_HELP
} }
quiet=false quiet=false
@ -66,6 +67,13 @@ while getopts hqv ARG ; do
done done
shift $(($OPTIND - 1)) shift $(($OPTIND - 1))
if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
print_usage >&2
echo
echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
exit 1
fi
status=0 status=0
for p in "$@" ; do for p in "$@" ; do
! $verbose || printf '\n### %s\n\n' "$p" ! $verbose || printf '\n### %s\n\n' "$p"