d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/bonding: fix crash when stopping mode 4 port

Browse Source 
When stopping a bonded port all slaves are deactivated. Attempting
to deactivate a slave that was never activated will result in a segfault
when mode 4 is used.

Fixes: 7486331308f6 ("net/bonding: stop and deactivate slaves on stop")
Cc: stable@dpdk.org

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Chas Williams <chas3@att.com>
This commit is contained in:
Radu Nicolau 2018-11-08 15:26:42 +00:00 committed by Ferruh Yigit
parent 39ae74caa0
commit 0911d4ec01
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/bonding/rte_eth_bond_pmd.c
View File

@ -2181,9 +2181,14 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
internals->link_status_polling_enabled = 0;
for (i = 0; i < internals->slave_count; i++) {
internals->slaves[i].last_link_status = 0;
rte_eth_dev_stop(internals->slaves[i].port_id);
deactivate_slave(eth_dev, internals->slaves[i].port_id);
uint16_t slave_id = internals->slaves[i].port_id;
if (find_slave_by_id(internals->active_slaves,
internals->active_slave_count, slave_id) !=
internals->active_slave_count) {
internals->slaves[i].last_link_status = 0;
rte_eth_dev_stop(slave_id);
deactivate_slave(eth_dev, slave_id);
}
}
}