From 099da89792e611ddcd177f5ff06d6ab6bd82dd0f Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Wed, 22 Jun 2022 23:11:40 -0400 Subject: [PATCH] raw/ifpga: fix integer overflow for N3000 Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga() is evaluated using 32-bit arithmetic, which would overflow potentially. Change tx_chunks to type "uint64_t" to avoid such issue. Coverity issue: 379203 Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver") Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen Xu --- drivers/raw/ifpga/afu_pmd_n3000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c index 8708164485..5120df5f77 100644 --- a/drivers/raw/ifpga/afu_pmd_n3000.c +++ b/drivers/raw/ifpga/afu_pmd_n3000.c @@ -1158,7 +1158,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx *ctx, uint64_t dst, uint64_t src, uint64_t count_left = count; uint64_t dma_chunks = 0; uint64_t offset = 0; - uint32_t tx_chunks = 0; + uint64_t tx_chunks = 0; uint64_t *tmp_buf = NULL; int ret = 0; @@ -1213,7 +1213,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx *ctx, uint64_t dst, uint64_t src, offset = tx_chunks * ctx->dma_buf_size; count_left -= offset; IFPGA_RAWDEV_PMD_DEBUG("0x%"PRIx64" --> 0x%"PRIx64 - " (%u...0x%"PRIx64")", + " (%"PRIu64"...0x%"PRIx64")", src, dst, tx_chunks, count_left); tmp_buf = (uint64_t *)rte_malloc(NULL, ctx->dma_buf_size, DMA_ALIGN_BYTES);