d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix potential out of bounds read

Browse Source 
After the last enabled port has been seen, and the last time we
evaluate the loop condition, there is an out of bounds read in
ports[p].enabled because p is equal to size, which is the length of
ports.

Signed-off-by: Julien Cretin <julien.cretin@trust-in-soft.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
This commit is contained in:
Julien Cretin 2015-03-09 14:21:09 +01:00 committed by Thomas Monjalon
parent 42a0325632
commit 12a8e30fd7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/test-pmd/testpmd.c
View File

@ -332,7 +332,7 @@ find_next_port(portid_t p, struct rte_port *ports, int size)
if (ports == NULL)
rte_exit(-EINVAL, "failed to find a next port id\n");
while ((ports[p].enabled == 0) && (p < size))
while ((p < size) && (ports[p].enabled == 0))
p++;
return p;
}