net/tap: allow full length names

The code for set_interface_name was incorrectly assuming that
space for null byte was necessary with snprintf/strlcpy.

Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by Keith Wiles <keith.wiles@intel.com>
This commit is contained in:
Stephen Hemminger 2019-01-11 12:35:15 -08:00 committed by Ferruh Yigit
parent 1d7490bc7c
commit 12ad0b6572

View File

@ -1892,10 +1892,10 @@ set_interface_name(const char *key __rte_unused,
char *name = (char *)extra_args;
if (value)
strlcpy(name, value, RTE_ETH_NAME_MAX_LEN - 1);
strlcpy(name, value, RTE_ETH_NAME_MAX_LEN);
else
snprintf(name, RTE_ETH_NAME_MAX_LEN - 1, "%s%d",
DEFAULT_TAP_NAME, (tap_unit - 1));
snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s%d",
DEFAULT_TAP_NAME, tap_unit - 1);
return 0;
}