d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples/power: fix strcpy buffer overrun

Browse Source 
replace strcpy with strlcpy to prevent buffer overrun
With fix, attempting to use a VERY lonng vm name results in a nicely
truncated 32 character name rather than a segfault:
Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd]

Using strlcpy rather than rte_strlcpy, as the rte_ version is only a
fallback.

As well as the fix in main.c, this patch also changes an occurrence of
rte_strlcpy in channel_manager.c and channel_monitor.c to strlcpy.

Fixes: 59287933a0bb ("examples/vm_power: add options to guest app")
Cc: stable@dpdk.org

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
This commit is contained in:
David Hunt 2019-07-16 12:19:00 +01:00 committed by Thomas Monjalon
parent d601426a27
commit 135393d456
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/vm_power_manager/channel_manager.c
View File

@ -588,7 +588,7 @@ add_host_channels(void)
goto error;
}
chan_infos[i] = chan_info;
rte_strlcpy(chan_info->channel_path, socket_path,
strlcpy(chan_info->channel_path, socket_path,
sizeof(chan_info->channel_path));
if (setup_host_channel_info(&chan_info, i) < 0) {

2
examples/vm_power_manager/channel_monitor.c
View File

@ -309,7 +309,7 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt,
vm_name);
return -1;
}
rte_strlcpy(pkt->vm_name, vm_name, VM_MAX_NAME_SZ);
strlcpy(pkt->vm_name, vm_name, VM_MAX_NAME_SZ);
pkt->resource_id = resource_id;
}
return 0;

2
examples/vm_power_manager/guest_cli/main.c
View File

@ -65,7 +65,7 @@ parse_args(int argc, char **argv)
switch (opt) {
/* portmask */
case 'n':
strcpy(policy->vm_name, optarg);
strlcpy(policy->vm_name, optarg, VM_MAX_NAME_SZ);
printf("Setting VM Name to [%s]\n", policy->vm_name);
break;
case 'b':