From 136ab94a5b069929b96fcc60eef113ef258131a3 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Sat, 29 Jun 2019 13:58:49 +0200 Subject: [PATCH] net/atlantic: add missing experimental API tags Those symbols are declared in the library map but the prototypes are missing the experimental tag. Without it, existing users won't notice it is experimental. Fixes: ec0dec44ecb9 ("net/atlantic: enable MACsec configuration") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Adrien Mazarguil Acked-by: Neil Horman --- drivers/net/atlantic/rte_pmd_atlantic.c | 12 ++++++------ drivers/net/atlantic/rte_pmd_atlantic.h | 24 ++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/net/atlantic/rte_pmd_atlantic.c b/drivers/net/atlantic/rte_pmd_atlantic.c index 5bf4da27fd..2962f5c6cb 100644 --- a/drivers/net/atlantic/rte_pmd_atlantic.c +++ b/drivers/net/atlantic/rte_pmd_atlantic.c @@ -8,7 +8,7 @@ #include "atl_ethdev.h" -__rte_experimental int +int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot) { @@ -24,7 +24,7 @@ rte_pmd_atl_macsec_enable(uint16_t port, return atl_macsec_enable(dev, encr, repl_prot); } -__rte_experimental int +int rte_pmd_atl_macsec_disable(uint16_t port) { struct rte_eth_dev *dev; @@ -39,7 +39,7 @@ rte_pmd_atl_macsec_disable(uint16_t port) return atl_macsec_disable(dev); } -__rte_experimental int +int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac) { struct rte_eth_dev *dev; @@ -54,7 +54,7 @@ rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac) return atl_macsec_config_txsc(dev, mac); } -__rte_experimental int +int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi) { struct rte_eth_dev *dev; @@ -69,7 +69,7 @@ rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi) return atl_macsec_config_rxsc(dev, mac, pi); } -__rte_experimental int +int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key) { @@ -85,7 +85,7 @@ rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, return atl_macsec_select_txsa(dev, idx, an, pn, key); } -__rte_experimental int +int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key) { diff --git a/drivers/net/atlantic/rte_pmd_atlantic.h b/drivers/net/atlantic/rte_pmd_atlantic.h index e4db7c6c27..c0208569b6 100644 --- a/drivers/net/atlantic/rte_pmd_atlantic.h +++ b/drivers/net/atlantic/rte_pmd_atlantic.h @@ -14,6 +14,9 @@ #include /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable MACsec offload. * * @param port @@ -29,9 +32,13 @@ * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Disable MACsec offload. * * @param port @@ -41,9 +48,13 @@ int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot); * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_disable(uint16_t port); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Configure Tx SC (Secure Connection). * * @param port @@ -55,9 +66,13 @@ int rte_pmd_atl_macsec_disable(uint16_t port); * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Configure Rx SC (Secure Connection). * * @param port @@ -71,9 +86,13 @@ int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac); * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable Tx SA (Secure Association). * * @param port @@ -92,10 +111,14 @@ int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi); * - (-ENOTSUP) if hardware doesn't support this feature. * - (-EINVAL) if bad parameter. */ +__rte_experimental int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable Rx SA (Secure Association). * * @param port @@ -114,6 +137,7 @@ int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, * - (-ENOTSUP) if hardware doesn't support this feature. * - (-EINVAL) if bad parameter. */ +__rte_experimental int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key);