d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: update Rx offload after setting MTU

Browse Source 
Currently, Rx offload capabilities and max_rx_pkt_len in the struct
variable named rte_port are not updated after setting mtu successfully
in port_mtu_set function by 'port config mtu <port_id> <value>' command.
This may lead to reconfig mtu to the initial value in the driver when
recalling rte_eth_dev_configure API interface.

This patch updates Rx offload capabilities and max_rx_pkt_len after
setting mtu successfully when configuring mtu.

Fixes: ae03d0d18a ("app/testpmd: command to configure MTU")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Wei Hu (Xavier) 2020-02-13 09:57:43 +08:00 committed by Ferruh Yigit
parent 0654d4a8ad
commit 150c9ac2df
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/test-pmd/config.c
View File

@ -1215,7 +1215,9 @@ void
port_mtu_set(portid_t port_id, uint16_t mtu) port_mtu_set(portid_t port_id, uint16_t mtu)
{ {
int diag; int diag;
struct rte_port *rte_port = &ports[port_id];
struct rte_eth_dev_info dev_info; struct rte_eth_dev_info dev_info;
uint16_t eth_overhead;
int ret; int ret;
if (port_id_is_invalid(port_id, ENABLED_WARN)) if (port_id_is_invalid(port_id, ENABLED_WARN))
@ -1231,8 +1233,25 @@ port_mtu_set(portid_t port_id, uint16_t mtu)
return; return;
} }
diag = rte_eth_dev_set_mtu(port_id, mtu); diag = rte_eth_dev_set_mtu(port_id, mtu);
if (diag == 0) if (diag == 0 &&
dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) {
/*
* Ether overhead in driver is equal to the difference of
* max_rx_pktlen and max_mtu in rte_eth_dev_info when the
* device supports jumbo frame.
*/
eth_overhead = dev_info.max_rx_pktlen - dev_info.max_mtu;
if (mtu > RTE_ETHER_MAX_LEN - eth_overhead) {
rte_port->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
rte_port->dev_conf.rxmode.max_rx_pkt_len =
mtu + eth_overhead;
} else
rte_port->dev_conf.rxmode.offloads &=
~DEV_RX_OFFLOAD_JUMBO_FRAME;
return; return;
}
printf("Set MTU failed. diag=%d\n", diag); printf("Set MTU failed. diag=%d\n", diag);
} }