d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5: fix setting VF default MAC through representor

Browse Source 
With kernel bonding, there was an error when setting VF MAC address
through representor. The Netlink API requires ifindex of owner PF, not
bonding device ifindex.

Uses owner PF ifindex to modify VF default MAC in case of bonding
device.

Fixes: c21e5facf7 ("net/mlx5: use bond index for netdev operations")
Cc: stable@dpdk.org

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
This commit is contained in:
Xueming Li 2021-03-28 13:48:13 +00:00 committed by Raslan Darawsheh
parent f5f4c48237
commit 1ce7d26d1a
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/net/mlx5/mlx5_mac.c
View File

@ -154,6 +154,7 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
{
uint16_t port_id;
struct mlx5_priv *priv = dev->data->dev_private;
struct mlx5_priv *pf_priv;
/*
* Configuring the VF instead of its representor,
@ -162,17 +163,21 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
if (priv->representor && !mlx5_is_hpf(dev)) {
DRV_LOG(DEBUG, "VF represented by port %u setting primary MAC address",
dev->data->port_id);
if (priv->pf_bond >= 0) {
/* Bonding, get owner PF ifindex from shared data. */
return mlx5_os_vf_mac_addr_modify
(priv,
priv->sh->bond.ports[priv->pf_bond].ifindex,
mac_addr,
MLX5_REPRESENTOR_REPR(priv->representor_id));
}
RTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data->port_id) {
priv = rte_eth_devices[port_id].data->dev_private;
if (priv->master == 1) {
priv = dev->data->dev_private;
pf_priv = rte_eth_devices[port_id].data->dev_private;
if (pf_priv->master == 1)
return mlx5_os_vf_mac_addr_modify
(priv,
mlx5_ifindex(&rte_eth_devices[port_id]),
mac_addr,
(priv, pf_priv->if_index, mac_addr,
MLX5_REPRESENTOR_REPR
(priv->representor_id));
}
}
rte_errno = -ENOTSUP;
return rte_errno;