d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

buildtools/chkincs: check missing C++ guards

Browse Source 
Simply compiling a C header with a C++ compiler is not enough to flag
missing 'extern "C"' guards. To catch missing guards, we can just use a
simple grep for the 'extern "C"' part, and error out if any files have a
miss.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
This commit is contained in:
Bruce Richardson 2022-02-15 17:30:29 +00:00 committed by Thomas Monjalon
parent b232b2aa21
commit 1ee492bdc4
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
buildtools/chkincs/meson.build
View File

@ -37,6 +37,16 @@ if not add_languages('cpp', required: false)
subdir_done() subdir_done()
endif endif
# check for extern C in files, since this is not detected as an error by the compiler
grep = find_program('grep', required: false)
if grep.found()
errlist = run_command([grep, '--files-without-match', '^extern "C"', dpdk_chkinc_headers],
check: false, capture: true).stdout().split()
if errlist != []
error('Files missing C++ \'extern "C"\' guards:\n- ' + '\n- '.join(errlist))
endif
endif
gen_cpp_files = generator(gen_c_file_for_header, gen_cpp_files = generator(gen_c_file_for_header,
output: '@BASENAME@.cpp', output: '@BASENAME@.cpp',
arguments: ['@INPUT@', '@OUTPUT@']) arguments: ['@INPUT@', '@OUTPUT@'])