d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/cxgbe: fix null dereference on CLIP failure

Browse Source 
Coverity issue: 302872
Fixes: 3f2c1e209c ("net/cxgbe: add Compressed Local IP region")

Signed-off-by: Shagun Agrawal <shaguna@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
This commit is contained in:
Shagun Agrawal 2018-07-26 13:49:32 +05:30 committed by Thomas Monjalon
parent 0caa07034a
commit 217d181626
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/cxgbe/clip_tbl.c
View File

@ -105,7 +105,7 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev,
struct adapter *adap = ethdev2adap(dev);
struct clip_tbl *ctbl = adap->clipt;
struct clip_entry *ce;
int ret;
int ret = 0;
if (!ctbl)
return NULL;
@ -120,12 +120,10 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev,
ce->type = FILTER_TYPE_IPV6;
rte_atomic32_set(&ce->refcnt, 1);
ret = clip6_get_mbox(dev, lip);
if (ret) {
if (ret)
dev_debug(adap,
"CLIP FW ADD CMD failed: %d",
ret);
ce = NULL;
}
} else {
ce->type = FILTER_TYPE_IPV4;
}
@ -136,7 +134,7 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev,
}
t4_os_write_unlock(&ctbl->lock);
return ce;
return ret ? NULL : ce;
}
/**