From 21bdbf24321de9f0336a0e6e0bc618a1e094aa4c Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 10 Dec 2021 14:09:52 +0000 Subject: [PATCH] crypto/ipsec_mb: fix tainted data for session Downcasting a void * to struct aesni_gcm_session * caused the session data to be treated as tainted. Removing the void * temporary variable and adding a cast avoids this issue. Coverity issue: 374377 Fixes: 746825e5c0ea ("crypto/ipsec_mb: move aesni_gcm PMD") Cc: stable@dpdk.org Signed-off-by: Ciara Power Acked-by: Fan Zhang --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c index 2c203795ab..e5ad629fe5 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c @@ -713,19 +713,17 @@ aesni_gcm_process_bulk(struct rte_cryptodev *dev, __rte_unused union rte_crypto_sym_ofs ofs, struct rte_crypto_sym_vec *vec) { - void *sess_priv; struct aesni_gcm_session *s; struct gcm_context_data gdata_ctx; IMB_MGR *mb_mgr; - sess_priv = get_sym_session_private_data(sess, dev->driver_id); - if (unlikely(sess_priv == NULL)) { + s = (struct aesni_gcm_session *) get_sym_session_private_data(sess, + dev->driver_id); + if (unlikely(s == NULL)) { aesni_gcm_fill_error_code(vec, EINVAL); return 0; } - s = sess_priv; - /* get per-thread MB MGR, create one if needed */ mb_mgr = get_per_thread_mb_mgr(); if (unlikely(mb_mgr == NULL))