From 232eb09fdf21d0e48423d58dcc19f472d3fab630 Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Wed, 9 Nov 2022 03:40:17 +0200 Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert In order to share flow items translate code, flow items translation of spec and mask was split individually. In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, the assert looks redundant. This commit removes the unneeded GENEVE option length assert. Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value translation") Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 57af95b8a9..ff1e7ff455 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9601,13 +9601,9 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, memcpy(&opt_data_key, data, RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4), sizeof(opt_data_key))); - MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <= - sizeof(opt_data_key)); memcpy(&opt_data_mask, geneve_opt_m->data, RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4), sizeof(opt_data_mask))); - MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <= - sizeof(opt_data_mask)); MLX5_SET(fte_match_set_misc3, misc3_v, geneve_tlv_option_0_data, rte_be_to_cpu_32(opt_data_key & opt_data_mask));