d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: remove unused parameter in Rx header split

Browse Source 
Protocol header sequence checking is supported in the ethdev library,
the application does not need to do it again.

Coverity issue: 381396
Fixes: 52e2e7edcf ("app/testpmd: add protocol-based buffer split")

Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
This commit is contained in:
Yuan Wang 2022-10-12 22:29:15 +08:00 committed by Andrew Rybchenko
parent f66323717e
commit 23f2dfd3ca
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/test-pmd/cmdline.c
View File

@ -3440,7 +3440,7 @@ get_ptype(char *value)
unsigned int
parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
unsigned int *parsed_items, int check_hdrs_sequence)
unsigned int *parsed_items)
{
unsigned int nb_item;
char *cur;
@ -3462,8 +3462,6 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
fprintf(stderr, "Number of %s = %u > %u (maximum items)\n",
item_name, nb_item + 1, max_items);
free(str2);
if (!check_hdrs_sequence)
return nb_item;
return nb_item;
}
@ -3854,7 +3852,7 @@ cmd_set_rxhdrs_parsed(void *parsed_result,
res = parsed_result;
nb_segs = parse_hdrs_list(res->values, "segment hdrs",
MAX_SEGS_BUFFER_SPLIT, seg_hdrs, 0);
MAX_SEGS_BUFFER_SPLIT, seg_hdrs);
if (nb_segs > 0)
set_rx_pkt_hdrs(seg_hdrs, nb_segs);
cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1);

2
app/test-pmd/parameters.c
View File

@ -1278,7 +1278,7 @@ launch_args_parse(int argc, char** argv)
nb_segs = parse_hdrs_list
(optarg, "rxpkt segments",
MAX_SEGS_BUFFER_SPLIT,
seg_hdrs, 0);
seg_hdrs);
if (nb_segs > 0)
set_rx_pkt_hdrs(seg_hdrs, nb_segs);
else

2
app/test-pmd/testpmd.h
View File

@ -854,7 +854,7 @@ unsigned int parse_item_list(const char *str, const char *item_name,
unsigned int *parsed_items, int check_unique_values);
unsigned int parse_hdrs_list(const char *str, const char *item_name,
unsigned int max_item,
unsigned int *parsed_items, int check_unique_values);
unsigned int *parsed_items);
void launch_args_parse(int argc, char** argv);
void cmd_reconfig_device_queue(portid_t id, uint8_t dev, uint8_t queue);
void cmdline_read_from_file(const char *filename);