d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/test: fix misplaced braces in devargs check

Browse Source 
This patch fixes two occurrences where a call to strncmp had the closing
brace in the wrong place. Changing this form:
	if (strncmp(X,Y,sizeof(X) != 0))
which does a comparison of length 1, to
	if (strncmp(X,Y,sizeof(X)) != 0)
which does the correct length comparison and then compares the result to
zero in the "if" part, as the author presumably originally intended.

Reported-by: Larry Wang <liang-min.wang@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
This commit is contained in:
Bruce Richardson 2014-11-19 09:06:13 +00:00 committed by Thomas Monjalon
parent 21cdbc4254
commit 2613862481
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/test/test_devargs.c
View File

@ -90,9 +90,9 @@ test_devargs(void)
goto fail;
devargs = TAILQ_FIRST(&devargs_list);
if (strncmp(devargs->virtual.drv_name, "eth_ring1",
sizeof(devargs->virtual.drv_name) != 0))
sizeof(devargs->virtual.drv_name)) != 0)
goto fail;
if (strncmp(devargs->args, "k1=val,k2=val2", sizeof(devargs->args) != 0))
if (strncmp(devargs->args, "k1=val,k2=val2", sizeof(devargs->args)) != 0)
goto fail;
free_devargs_list();