d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/tap: fix memcpy with incorrect size

Browse Source 
Fix incorrect sizeof operation being used for getting mac addr size.

Found while compiling with arm64 clang.
drivers/net/tap/rte_eth_tap.c:1410:40: error: argument to 'sizeof' in
    'memcpy' call is the same pointer type 'struct ether_addr *' as the
    destination; expected 'struct ether_addr' or an explicit length
    [-Werror,-Wsizeof-pointer-memaccess]
       rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr));
                  ~~~~~~~~~~~~~~            ^~~~~~~~~~~~~~~~

Fixes: bcab6c1d27fa ("net/tap: allow user MAC to be passed as args")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
This commit is contained in:
Pavan Nikhilesh 2018-04-06 17:00:31 +05:30 committed by Ferruh Yigit
parent a922c6a789
commit 28aa16db4a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/tap/rte_eth_tap.c
View File

@ -1407,7 +1407,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
if (is_zero_ether_addr(mac_addr))
eth_random_addr((uint8_t *)&pmd->eth_addr);
else
rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr));
rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr));
/* Immediately create the netdevice (this will create the 1st queue). */
/* rx queue */