d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples/bbdev: fix memory leak in stats print

Browse Source 
xstats and xstats_names buffers were allocated for
the purpose of printing eth_xstats, but were not
freed before exit.
A fix is added to free before exit points.

Coverity issue: 257013
Fixes: 1ffee690ea ("examples/bbdev: add sample app")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
This commit is contained in:
Amr Mokhtar 2018-01-31 14:30:29 +00:00 committed by Thomas Monjalon
parent bf271db171
commit 2a5aa6e7a5
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
examples/bbdev_app/main.c
View File

@ -585,21 +585,28 @@ print_stats(struct stats_lcore_params *stats_lcore)
"Failed to calloc memory for xstats");
ret = rte_eth_xstats_get(port_id, xstats, len);
if (ret < 0 || ret > len)
if (ret < 0 || ret > len) {
free(xstats);
rte_exit(EXIT_FAILURE,
"rte_eth_xstats_get(%u) len%i failed: %d",
port_id, len, ret);
}
xstats_names = calloc(len, sizeof(*xstats_names));
if (xstats_names == NULL)
if (xstats_names == NULL) {
free(xstats);
rte_exit(EXIT_FAILURE,
"Failed to calloc memory for xstats_names");
}
ret = rte_eth_xstats_get_names(port_id, xstats_names, len);
if (ret < 0 || ret > len)
if (ret < 0 || ret > len) {
free(xstats);
free(xstats_names);
rte_exit(EXIT_FAILURE,
"rte_eth_xstats_get_names(%u) len%i failed: %d",
port_id, len, ret);
}
for (i = 0; i < len; i++) {
if (xstats[i].value > 0)
@ -630,6 +637,9 @@ print_stats(struct stats_lcore_params *stats_lcore)
continue;
print_lcore_stats(stats_lcore->lconf[l_id].lcore_stats, l_id);
}
free(xstats);
free(xstats_names);
}
static int