d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ice/base: check memory pointer before copying

Browse Source 
The ice_memdup doesn't check the new allocated memory pointer, it calls
the rte_memcpy directly. It should check it.

Fixes: 5f0978e962 ("net/ice/base: add OS specific implementation")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
This commit is contained in:
Haiyue Wang 2020-03-31 14:50:34 +08:00 committed by Ferruh Yigit
parent d2e5322900
commit 2adbccec40
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/net/ice/base/ice_osdep.h
View File

@ -24,6 +24,8 @@
#include <rte_random.h>
#include <rte_io.h>
#include "ice_alloc.h"
#include "../ice_logs.h"
#ifndef __INTEL_NET_BASE_OSDEP__
@ -193,7 +195,6 @@ struct ice_virt_mem {
#define ice_memset(a, b, c, d) memset((a), (b), (c))
#define ice_memcpy(a, b, c, d) rte_memcpy((a), (b), (c))
#define ice_memdup(a, b, c, d) rte_memcpy(ice_malloc(a, c), b, c)
/* SW spinlock */
struct ice_lock {
@ -225,6 +226,19 @@ ice_destroy_lock(__rte_unused struct ice_lock *sp)
struct ice_hw;
static __rte_always_inline void *
ice_memdup(__rte_unused struct ice_hw *hw, const void *src, size_t size,
__rte_unused enum ice_memcpy_type dir)
{
void *p;
p = ice_malloc(hw, size);
if (p)
rte_memcpy(p, src, size);
return p;
}
static inline void *
ice_alloc_dma_mem(__rte_unused struct ice_hw *hw,
struct ice_dma_mem *mem, u64 size)