From 2ba9a32c96a1846ebfbb92c64640cfe233551ec1 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Thu, 14 Dec 2017 15:21:40 +0100 Subject: [PATCH] devtools: enhance error message in get maintainer script When the DPDK_GETMAINTAINER_PATH variable was not set, the error message from get-maintainer.sh was quite cheap: $ devtools/get-maintainer.sh --help usage: get-maintainer.sh Cannot execute DPDK_GETMAINTAINER_PATH Add a more detailed explanation about this variable in the help. Signed-off-by: Olivier Matz Acked-by: Ferruh Yigit --- devtools/get-maintainer.sh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh index 5ae6b5aed1..5a25913078 100755 --- a/devtools/get-maintainer.sh +++ b/devtools/get-maintainer.sh @@ -42,15 +42,16 @@ options="$options --no-rolestats" print_usage () { cat <<- END_OF_HELP usage: $(basename $0) + + The DPDK_GETMAINTAINER_PATH variable should be set to the full path to + the get_maintainer.pl script located in Linux kernel sources. Example: + DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl + + Also refer to devtools/load-devel-config to store your configuration. END_OF_HELP } -# Requires DPDK_GETMAINTAINER_PATH devel config option set, -# please check devtools/load-devel-config. -# DPDK_GETMAINTAINER_PATH should be full path to the get_maintainer.pl script, -# like: -# DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl - +# Requires DPDK_GETMAINTAINER_PATH devel config option set if [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then print_usage >&2 echo